r343761 - [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array

2018-10-04 Thread Petr Pavlu via cfe-commits
Author: petr.pavlu Date: Thu Oct 4 02:25:44 2018 New Revision: 343761 URL: http://llvm.org/viewvc/llvm-project?rev=343761&view=rev Log: [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array Fix code for constant evaluation of __builtin_memcpy() and __builtin_memmove() that

r330507 - [libclang] Fix LibclangReparseTest.FileName when TMPDIR is set to a symlink

2018-04-21 Thread Petr Pavlu via cfe-commits
Author: petr.pavlu Date: Sat Apr 21 07:35:18 2018 New Revision: 330507 URL: http://llvm.org/viewvc/llvm-project?rev=330507&view=rev Log: [libclang] Fix LibclangReparseTest.FileName when TMPDIR is set to a symlink Fix testing of clang_File_tryGetRealPathName() in LibclangReparseTest.FileName when

r336842 - Fix setting of empty implicit-section-name attribute

2018-07-11 Thread Petr Pavlu via cfe-commits
Author: petr.pavlu Date: Wed Jul 11 13:17:54 2018 New Revision: 336842 URL: http://llvm.org/viewvc/llvm-project?rev=336842&view=rev Log: Fix setting of empty implicit-section-name attribute Code in `CodeGenModule::SetFunctionAttributes()` could set an empty attribute `implicit-section-name` on a

[PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

2015-09-30 Thread Petr Pavlu via cfe-commits
petpav01 created this revision. petpav01 added a subscriber: cfe-commits. Libc++ provides valarray transcendentals with replacement types. These functions are implemented either as `template` or `template`, where `_Expr` can be `__val_expr` or `valarray`. The patch provides additional function t

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

2015-10-03 Thread Petr Pavlu via cfe-commits
petpav01 added a comment. It would be probably better if the patch changed the original templates to take only `__val_expr` as there is now no need for them to match valarray too. This should be a simple change but requires additional tests so I will wait for initial feedback that this approach

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

2015-10-25 Thread Petr Pavlu via cfe-commits
petpav01 added a comment. Thank you for having a look at this patch. I should get to updating it as requested soon. Apologies for the delay. http://reviews.llvm.org/D13289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

2016-01-15 Thread Petr Pavlu via cfe-commits
petpav01 added a comment. Ping. I would still like to address this problem. Could I please get a review on the last version of the patch? Thanks, Petr http://reviews.llvm.org/D13289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

2015-11-18 Thread Petr Pavlu via cfe-commits
petpav01 updated this revision to Diff 40486. petpav01 added a comment. I am not sure if I understand the comment about [17.6.5.4] correctly. It is not clear to me how this part of the standard prevents the user from specifying explicit template parameters for standard functions. It seems odd th

Re: [PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

2015-12-11 Thread Petr Pavlu via cfe-commits
petpav01 updated this revision to Diff 42506. petpav01 added a comment. Updated patch adds more tests and fixes a problem introduced in the previous revision where templates taking `__val_expr` were not correctly protected by SFINAE from immediate context (it introduced same problem with explici