Re: [PATCH] D61914: [Support][Test] Time profiler: add regression test

2019-06-07 Thread Puyan Lotfi via cfe-commits
--target= Sent from ProtonMail Mobile On Fri, Jun 7, 2019 at 2:01 PM, Anton Afanasyev via Phabricator wrote: > anton-afanasyev marked an inline comment as done. > anton-afanasyev added a comment. > > In D61914#1534508 , @plotfi wrote: > >>

r363648 - [NFC] Undoing r363646 to fix bots.

2019-06-17 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Mon Jun 17 22:15:59 2019 New Revision: 363648 URL: http://llvm.org/viewvc/llvm-project?rev=363648=rev Log: [NFC] Undoing r363646 to fix bots. -DBUILD_SHARED_LIBS=ON is still having problem caused by layering issues with D60974. Locally there weren't problems building with

r363646 - [NFC] Fixing -DBUILD_SHARED_LIBS=ON problem caused by layering issue in D60974

2019-06-17 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Mon Jun 17 21:40:03 2019 New Revision: 363646 URL: http://llvm.org/viewvc/llvm-project?rev=363646=rev Log: [NFC] Fixing -DBUILD_SHARED_LIBS=ON problem caused by layering issue in D60974 Modified: cfe/trunk/lib/Frontend/CMakeLists.txt Modified:

r363626 - [clang-ifs] Clang Interface Stubs, first version.

2019-06-17 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Mon Jun 17 15:46:54 2019 New Revision: 363626 URL: http://llvm.org/viewvc/llvm-project?rev=363626=rev Log: [clang-ifs] Clang Interface Stubs, first version. Clang interface stubs (previously referred to as clang-ifsos) is a new frontend action in clang that allows the

r363878 - [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).

2019-06-19 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Wed Jun 19 13:51:35 2019 New Revision: 363878 URL: http://llvm.org/viewvc/llvm-project?rev=363878=rev Log: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC). This is a NFC refactor move of CodegenNameGeneratorImpl from clang::Index to clang:AST

r363908 - [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC).

2019-06-19 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Wed Jun 19 23:01:06 2019 New Revision: 363908 URL: http://llvm.org/viewvc/llvm-project?rev=363908=rev Log: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC). The original pimpl pattern used between CodegenNameGenerator and CodegenNameGeneratorImpl did a good

r363963 - [NFC] Fix for InterfaceStubs tests (adding REQUIRES: x86-registered-target).

2019-06-20 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Thu Jun 20 11:28:21 2019 New Revision: 363963 URL: http://llvm.org/viewvc/llvm-project?rev=363963=rev Log: [NFC] Fix for InterfaceStubs tests (adding REQUIRES: x86-registered-target). clang-hexagon-elf bot was failing with: 'No available targets are compatible with triple

r363948 - [clang-ifs] Clang Interface Stubs, first version (second landing attempt).

2019-06-20 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Thu Jun 20 09:59:48 2019 New Revision: 363948 URL: http://llvm.org/viewvc/llvm-project?rev=363948=rev Log: [clang-ifs] Clang Interface Stubs, first version (second landing attempt). This change reverts r363649; effectively re-landing r363626. At this point

r368734 - [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases

2019-08-13 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Tue Aug 13 11:42:03 2019 New Revision: 368734 URL: http://llvm.org/viewvc/llvm-project?rev=368734=rev Log: [NFC][clang] Adding argument based Phase list filtering to getComplicationPhases This patch removes usage of FinalPhase from anywhere outside of the scope where it is

Re: [PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

2019-08-04 Thread Puyan Lotfi via cfe-commits
https://reviews.llvm.org/D65704 https://reviews.llvm.org/D65708 Thanks! PL On Thu, Aug 1, 2019 at 5:42 PM Jan Korous wrote: > Oh! Interesting! Thanks for investigating this. > > I'm happy to review the patch. > > On Aug 1, 2019, at 5:17 PM, Puyan Lotfi > wrote: > > Hi Jan, Thanks for the

r368881 - [NFC][clang] Moving argument handling: Driver::BuildActions -> handleArguments

2019-08-14 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Wed Aug 14 10:02:21 2019 New Revision: 368881 URL: http://llvm.org/viewvc/llvm-project?rev=368881=rev Log: [NFC][clang] Moving argument handling: Driver::BuildActions -> handleArguments This patch simply moves code that already exists into a new function. Specifically I think

r369719 - [clang][ifs] Dropping older experimental interface stub formats.

2019-08-22 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Thu Aug 22 16:44:34 2019 New Revision: 369719 URL: http://llvm.org/viewvc/llvm-project?rev=369719=rev Log: [clang][ifs] Dropping older experimental interface stub formats. I've been working on a new tool, llvm-ifs, for merging interface stub files generated by clang and I've

r369715 - [clang][ifs] New interface stubs format (llvm triple based).

2019-08-22 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Thu Aug 22 16:29:22 2019 New Revision: 369715 URL: http://llvm.org/viewvc/llvm-project?rev=369715=rev Log: [clang][ifs] New interface stubs format (llvm triple based). After posting llvm-ifs on phabricator, I made some progress in hardening up how I think the format for

r367345 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

2019-07-30 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Tue Jul 30 12:03:17 2019 New Revision: 367345 URL: http://llvm.org/viewvc/llvm-project?rev=367345=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3. Dropping the 'u' entry and the entire Flags table from Types.def. Now it'll be a bit easier to tablegenify

r367478 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 3.

2019-07-31 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Wed Jul 31 13:40:08 2019 New Revision: 367478 URL: http://llvm.org/viewvc/llvm-project?rev=367478=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 3. Second landing attempt: Changed TY_ObjCXXHeader to TY_PP_ObjCXXHeader to fix

Re: [PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

2019-08-02 Thread Puyan Lotfi via cfe-commits
Hi Jan, Thanks for the follow up! Me and Compnerd narrowed down the issue to the inotify file count limit being exceeded as the cause. DirectoryWatcherLinux::create() in DirectoryWatcher-linux.cpp also doesn't properly perror, I'll post a patch for this shortly to print perror info if the file

r368108 - [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in create

2019-08-06 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Tue Aug 6 16:25:34 2019 New Revision: 368108 URL: http://llvm.org/viewvc/llvm-project?rev=368108=rev Log: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in create I also have replaced all the instances of "auto DW = DirectoryWatcher::create" with

r368393 - [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions.

2019-08-08 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Thu Aug 8 21:55:09 2019 New Revision: 368393 URL: http://llvm.org/viewvc/llvm-project?rev=368393=rev Log: [clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions. I am working to remove this concept of the "FinalPhase" in the clang driver, but it is used in a

Re: r367979 - [clang][DirectoryWatcher] Adding llvm::Expected error handling to create.

2019-08-06 Thread Puyan Lotfi via cfe-commits
Mac builds. I > fixed it in r367984. > > From: cfe-commits on behalf of Puyan > Lotfi via cfe-commits > Reply-To: Puyan Lotfi > Date: Monday, August 5, 2019 at 10:11 PM > To: "cfe-commits@lists.llvm.org" > Subject: r367979 - [clang][DirectoryWatcher] Adding llvm:

r367968 - [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable

2019-08-05 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Mon Aug 5 18:26:46 2019 New Revision: 367968 URL: http://llvm.org/viewvc/llvm-project?rev=367968=rev Log: [NFC][DirectoryWatchedTests] Unlocks mutexes before signaling condition variable This should not affect actual behavior, but should pessimize the threading less by

r367979 - [clang][DirectoryWatcher] Adding llvm::Expected error handling to create.

2019-08-05 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Mon Aug 5 22:12:23 2019 New Revision: 367979 URL: http://llvm.org/viewvc/llvm-project?rev=367979=rev Log: [clang][DirectoryWatcher] Adding llvm::Expected error handling to create. Prior to this patch Unix style errno error reporting from the inotify layer was used by

r366761 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 1.

2019-07-22 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Mon Jul 22 16:10:10 2019 New Revision: 366761 URL: http://llvm.org/viewvc/llvm-project?rev=366761=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 1. Moves list of phases into Types.def table: Currently Types.def contains a table of strings that are used to

r367063 - [NFC][clang] Refactor getCompilationPhases()+Types.def step 2.

2019-07-25 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Thu Jul 25 15:05:55 2019 New Revision: 367063 URL: http://llvm.org/viewvc/llvm-project?rev=367063=rev Log: [NFC][clang] Refactor getCompilationPhases()+Types.def step 2. - Removing a few of the entries in the Flags for the Types.def table. - Removing redundant parts of

r373538 - [clang][ifs] Clang Interface Stubs ToolChain plumbing.

2019-10-02 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Wed Oct 2 15:50:07 2019 New Revision: 373538 URL: http://llvm.org/viewvc/llvm-project?rev=373538=rev Log: [clang][ifs] Clang Interface Stubs ToolChain plumbing. This patch enables end to end support for generating ELF interface stubs directly from clang. Now the following:

r373549 - Fixing broken builds due to r373538 due to test that should have been deleted.

2019-10-02 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Wed Oct 2 17:41:13 2019 New Revision: 373549 URL: http://llvm.org/viewvc/llvm-project?rev=373549=rev Log: Fixing broken builds due to r373538 due to test that should have been deleted. test/InterfaceStubs/object.cpp should have been deleted. Removed:

[clang] 79e345f - [clang][IFS] Adds support for more decl types in clang interface stubs.

2019-11-08 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-08T20:27:25-05:00 New Revision: 79e345fbcc822e914fac4838dd7a4f2ddbb5fcad URL: https://github.com/llvm/llvm-project/commit/79e345fbcc822e914fac4838dd7a4f2ddbb5fcad DIFF: https://github.com/llvm/llvm-project/commit/79e345fbcc822e914fac4838dd7a4f2ddbb5fcad.diff

[clang] 1257146 - [clang][IFS][test] Fixing buildbot test fails for clang-ifs.

2019-11-08 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-08T21:06:23-05:00 New Revision: 1257146eb41485e91cb13a6b0ccc2fb7faa68b75 URL: https://github.com/llvm/llvm-project/commit/1257146eb41485e91cb13a6b0ccc2fb7faa68b75 DIFF: https://github.com/llvm/llvm-project/commit/1257146eb41485e91cb13a6b0ccc2fb7faa68b75.diff

[clang] e782192 - [clang][IFS][test][NFC] Tightening up clang-ifs tests to use -cc1 more often.

2019-11-13 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-14T02:25:22-05:00 New Revision: e782192d5e6540b0cbb957a6b738d98e24c88ee3 URL: https://github.com/llvm/llvm-project/commit/e782192d5e6540b0cbb957a6b738d98e24c88ee3 DIFF: https://github.com/llvm/llvm-project/commit/e782192d5e6540b0cbb957a6b738d98e24c88ee3.diff

[clang] c72aef9 - [clang][IFS][test] Removing -shared, fixing triple: driver-test.c/windows.cpp.

2019-11-13 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-14T02:43:40-05:00 New Revision: c72aef999c3359f4305bf99116be604e16844aab URL: https://github.com/llvm/llvm-project/commit/c72aef999c3359f4305bf99116be604e16844aab DIFF: https://github.com/llvm/llvm-project/commit/c72aef999c3359f4305bf99116be604e16844aab.diff

[clang] 07e4451 - [clang][IFS] Adding support for new clang interface stubs decl types.

2019-12-04 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-12-04T19:10:47-05:00 New Revision: 07e445103e363c85ce7313c542dee20b2294fe72 URL: https://github.com/llvm/llvm-project/commit/07e445103e363c85ce7313c542dee20b2294fe72 DIFF: https://github.com/llvm/llvm-project/commit/07e445103e363c85ce7313c542dee20b2294fe72.diff

[clang] 4ef9110 - [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

2019-12-04 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-12-04T20:03:57-05:00 New Revision: 4ef9110b8d1004840d70477382c6bd10fb487fb6 URL: https://github.com/llvm/llvm-project/commit/4ef9110b8d1004840d70477382c6bd10fb487fb6 DIFF: https://github.com/llvm/llvm-project/commit/4ef9110b8d1004840d70477382c6bd10fb487fb6.diff

[clang] d694594 - [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

2019-12-09 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-12-09T14:47:17-05:00 New Revision: d694594d7650571dec40cc0ef9db6087963d62a0 URL: https://github.com/llvm/llvm-project/commit/d694594d7650571dec40cc0ef9db6087963d62a0 DIFF: https://github.com/llvm/llvm-project/commit/d694594d7650571dec40cc0ef9db6087963d62a0.diff

[clang] 58ea00b - [clang][IFS] Driver pipeline: generate interface stubs after standard pipeline.

2019-11-18 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T01:18:02-05:00 New Revision: 58ea00b51fe9b011301484957556872fced7dd08 URL: https://github.com/llvm/llvm-project/commit/58ea00b51fe9b011301484957556872fced7dd08 DIFF: https://github.com/llvm/llvm-project/commit/58ea00b51fe9b011301484957556872fced7dd08.diff

[clang] d044dcc - Revert "[clang][IFS] Driver pipeline: generate interface stubs after standard pipeline."

2019-11-18 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T02:08:22-05:00 New Revision: d044dcc5e492181b1517347013a780d9eda6c3c3 URL: https://github.com/llvm/llvm-project/commit/d044dcc5e492181b1517347013a780d9eda6c3c3 DIFF: https://github.com/llvm/llvm-project/commit/d044dcc5e492181b1517347013a780d9eda6c3c3.diff

[clang] f37356d - [clang][IFS][test] Removing driver-test.c. Test is still too brittle.

2019-11-19 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T21:42:17-05:00 New Revision: f37356d6f60ae5db978611621d3a375ed87ec0f0 URL: https://github.com/llvm/llvm-project/commit/f37356d6f60ae5db978611621d3a375ed87ec0f0 DIFF: https://github.com/llvm/llvm-project/commit/f37356d6f60ae5db978611621d3a375ed87ec0f0.diff

[clang] 27b229d - Revert "[clang][IFS][test] Removing driver-test.c. Test is still too brittle."

2019-11-19 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T21:59:10-05:00 New Revision: 27b229dc17b2ea1d06fe566df8631bb2fff7b1c8 URL: https://github.com/llvm/llvm-project/commit/27b229dc17b2ea1d06fe566df8631bb2fff7b1c8 DIFF: https://github.com/llvm/llvm-project/commit/27b229dc17b2ea1d06fe566df8631bb2fff7b1c8.diff

[clang] 6c6d348 - Revert "[clang][IFS] Fixing unsupported emulation mode on clang-ppc64be-linux bot."

2019-11-19 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T21:59:22-05:00 New Revision: 6c6d34883a3003693cbf0ab3edf19eb999c1a62d URL: https://github.com/llvm/llvm-project/commit/6c6d34883a3003693cbf0ab3edf19eb999c1a62d DIFF: https://github.com/llvm/llvm-project/commit/6c6d34883a3003693cbf0ab3edf19eb999c1a62d.diff

[clang] 1b38748 - [clang][IFS] Fixing unsupported emulation mode on clang-ppc64be-linux bot.

2019-11-19 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T19:27:46-05:00 New Revision: 1b387484b9b38a4a1e98a9d22a9a26065b0d184e URL: https://github.com/llvm/llvm-project/commit/1b387484b9b38a4a1e98a9d22a9a26065b0d184e DIFF: https://github.com/llvm/llvm-project/commit/1b387484b9b38a4a1e98a9d22a9a26065b0d184e.diff

[clang] 7342912 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (3)

2019-11-20 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-20T16:22:50-05:00 New Revision: 73429126c91c2065c6f6ef29b3eec1b7798502bb URL: https://github.com/llvm/llvm-project/commit/73429126c91c2065c6f6ef29b3eec1b7798502bb DIFF: https://github.com/llvm/llvm-project/commit/73429126c91c2065c6f6ef29b3eec1b7798502bb.diff

[clang] fec3ca7 - [clang][IFS][test] GreenDragon and Fuchsia Darwin bot fix: BindArchClass Nest.

2019-11-20 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-20T22:12:28-05:00 New Revision: fec3ca77bbce6917c103963b7b85b60dfb865c7b URL: https://github.com/llvm/llvm-project/commit/fec3ca77bbce6917c103963b7b85b60dfb865c7b DIFF: https://github.com/llvm/llvm-project/commit/fec3ca77bbce6917c103963b7b85b60dfb865c7b.diff

Re: [clang] 7342912 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (3)

2019-11-20 Thread Puyan Lotfi via cfe-commits
conflict-test.c >     Clang :: InterfaceStubs/object-float.c > > Here's the build log from out bot: > http://lab.llvm.org:8080/green/job/clang-stage1-RA/3929/console > > Can you please resolve the issue with the tests? > Thanks, > Alex > > On Wed, 20 Nov 2019 at

Re: [clang] 7342912 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (3)

2019-11-20 Thread Puyan Lotfi via cfe-commits
u please resolve the issue with the tests? > > Thanks, > > Alex > > > > On Wed, 20 Nov 2019 at 14:16, Puyan Lotfi via cfe-commits > > wrote: > > > > > Author: Puyan Lotfi > > > Date: 2019-11-20T16:22:50-05:00 > > > New Revis

[clang] ea8e028 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (2)

2019-11-19 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T17:47:38-05:00 New Revision: ea8e02822341e2421b94167d828d3f224e767424 URL: https://github.com/llvm/llvm-project/commit/ea8e02822341e2421b94167d828d3f224e767424 DIFF: https://github.com/llvm/llvm-project/commit/ea8e02822341e2421b94167d828d3f224e767424.diff

[clang] 377d70c - [clang][IFS] Fixing failing bots that do not have PPC target or "orbis-ld"

2019-11-19 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T18:12:07-05:00 New Revision: 377d70cdea733e36107e99d9148864d24797d51c URL: https://github.com/llvm/llvm-project/commit/377d70cdea733e36107e99d9148864d24797d51c DIFF: https://github.com/llvm/llvm-project/commit/377d70cdea733e36107e99d9148864d24797d51c.diff

[clang] 29fd1e1 - [clang][IFS] Attempting to fix missing 'orbis-ld' on scei-ps4-ubuntu bot.

2019-11-19 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-19T18:34:49-05:00 New Revision: 29fd1e1f4a372f3870e054da24b57a4f45861808 URL: https://github.com/llvm/llvm-project/commit/29fd1e1f4a372f3870e054da24b57a4f45861808 DIFF: https://github.com/llvm/llvm-project/commit/29fd1e1f4a372f3870e054da24b57a4f45861808.diff

[clang] 4873319 - [clang][IFS][test] Reverting driver-test.c to what it was prior to e782192d5e6

2019-11-14 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2019-11-14T03:39:16-05:00 New Revision: 4873319f973ba86c5d1226e87cdc3a7c085451bb URL: https://github.com/llvm/llvm-project/commit/4873319f973ba86c5d1226e87cdc3a7c085451bb DIFF: https://github.com/llvm/llvm-project/commit/4873319f973ba86c5d1226e87cdc3a7c085451bb.diff

r374061 - [clang][ifs] Clang Interface Stubs ToolChain plumbing.

2019-10-08 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Tue Oct 8 08:23:14 2019 New Revision: 374061 URL: http://llvm.org/viewvc/llvm-project?rev=374061=rev Log: [clang][ifs] Clang Interface Stubs ToolChain plumbing. Second Landing Attempt: This patch enables end to end support for generating ELF interface stubs directly from

r373552 - Fixing broken builds due to r373538, issues with filepath and hexagon toolchain.

2019-10-02 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Wed Oct 2 18:19:51 2019 New Revision: 373552 URL: http://llvm.org/viewvc/llvm-project?rev=373552=rev Log: Fixing broken builds due to r373538, issues with filepath and hexagon toolchain. It appears there are some issues with the hexagon toolchain, and also the file path for

r374573 - [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs

2019-10-11 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Fri Oct 11 10:24:11 2019 New Revision: 374573 URL: http://llvm.org/viewvc/llvm-project?rev=374573=rev Log: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs The clang IFS ASTConsumer was asserting on enums, records (struct definitions in C), and

r374632 - [clang][IFS] Updating tests to pass on -fvisibility=hidden builds (NFCi).

2019-10-11 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Fri Oct 11 19:46:57 2019 New Revision: 374632 URL: http://llvm.org/viewvc/llvm-project?rev=374632=rev Log: [clang][IFS] Updating tests to pass on -fvisibility=hidden builds (NFCi). Special thanks to JamesNagurne who got to the bottom of this; landing this on his behalf.

r374638 - [clang][IFS] Fixing spelling errors in interface-stubs OPT flag (NFC).

2019-10-12 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Fri Oct 11 23:25:07 2019 New Revision: 374638 URL: http://llvm.org/viewvc/llvm-project?rev=374638=rev Log: [clang][IFS] Fixing spelling errors in interface-stubs OPT flag (NFC). This is just a long standing spelling error that was found recently. Modified:

r374798 - [clang][IFS] Escape mangled names so MS ABI doesn't break YAML parsing.

2019-10-14 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Mon Oct 14 11:03:03 2019 New Revision: 374798 URL: http://llvm.org/viewvc/llvm-project?rev=374798=rev Log: [clang][IFS] Escape mangled names so MS ABI doesn't break YAML parsing. Microsoft's ABI mangles names differently than Itanium and this breaks the LLVM yaml parser

r374805 - [clang][IFS][test] Fixing lit test breakages on macOS due to r374798

2019-10-14 Thread Puyan Lotfi via cfe-commits
Author: zer0 Date: Mon Oct 14 11:57:29 2019 New Revision: 374805 URL: http://llvm.org/viewvc/llvm-project?rev=374805=rev Log: [clang][IFS][test] Fixing lit test breakages on macOS due to r374798 Adding the quotes breaks tests because on Darwin the name mangling is prefixed with an underscore.

[clang] a506f7f - [clang][IFS][test] Fixing mangled name of a test for Darwin.

2020-01-13 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2020-01-13T17:01:48-05:00 New Revision: a506f7f9105eec4baac296d21c922457d6f4b52a URL: https://github.com/llvm/llvm-project/commit/a506f7f9105eec4baac296d21c922457d6f4b52a DIFF: https://github.com/llvm/llvm-project/commit/a506f7f9105eec4baac296d21c922457d6f4b52a.diff

[clang] bd8c882 - [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

2020-01-13 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2020-01-13T16:04:27-05:00 New Revision: bd8c8827d96f09be502f0da6897c1aef89e45c30 URL: https://github.com/llvm/llvm-project/commit/bd8c8827d96f09be502f0da6897c1aef89e45c30 DIFF: https://github.com/llvm/llvm-project/commit/bd8c8827d96f09be502f0da6897c1aef89e45c30.diff

[clang] b7526cc - [NFC][clang][IFS] Adding braces to if-statement as prep for D71301.

2020-01-13 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2020-01-13T16:04:27-05:00 New Revision: b7526cc21ce55c8b53250df3d659fbdae3f894a7 URL: https://github.com/llvm/llvm-project/commit/b7526cc21ce55c8b53250df3d659fbdae3f894a7 DIFF: https://github.com/llvm/llvm-project/commit/b7526cc21ce55c8b53250df3d659fbdae3f894a7.diff

[clang] c38e425 - [clang][IFS][test] Temporary work around for in-process cc1 ASAN issues.

2020-01-21 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2020-01-21T22:56:20-05:00 New Revision: c38e42527b21acee8d01a016d5bfa2fb83202e29 URL: https://github.com/llvm/llvm-project/commit/c38e42527b21acee8d01a016d5bfa2fb83202e29 DIFF: https://github.com/llvm/llvm-project/commit/c38e42527b21acee8d01a016d5bfa2fb83202e29.diff

[clang] e3033c0 - [llvm][clang][IFS] Enhancing the llvm-ifs yaml format for symbol lists.

2020-04-01 Thread Puyan Lotfi via cfe-commits
Author: Puyan Lotfi Date: 2020-04-01T10:49:06-04:00 New Revision: e3033c0ce5517efddbf92a079ad1e0ca4868591f URL: https://github.com/llvm/llvm-project/commit/e3033c0ce5517efddbf92a079ad1e0ca4868591f DIFF: https://github.com/llvm/llvm-project/commit/e3033c0ce5517efddbf92a079ad1e0ca4868591f.diff

[clang] f22d276 - [NFC] Fix some spelling errors in clang Driver Options.td

2020-08-26 Thread Puyan Lotfi via cfe-commits
Author: Yang Zhihui Date: 2020-08-26T04:58:38-04:00 New Revision: f22d27624b6532a5542b283de9ce586c72c6b846 URL: https://github.com/llvm/llvm-project/commit/f22d27624b6532a5542b283de9ce586c72c6b846 DIFF: https://github.com/llvm/llvm-project/commit/f22d27624b6532a5542b283de9ce586c72c6b846.diff

[clang-tools-extra] llvm-canon (PR #68176)

2023-10-08 Thread Puyan Lotfi via cfe-commits
plotfi wrote: > Please don't use the term canon/canonicalize for this pass or tool. LLVM has > an existing notion of "canonicalization" which does not coincide with what is > being done here. The term comes from an older pass that did similar algorithms on MIR. They are only borrowing the

[clang] llvm-canon (PR #68176)

2023-10-08 Thread Puyan Lotfi via cfe-commits
plotfi wrote: > Please don't use the term canon/canonicalize for this pass or tool. LLVM has > an existing notion of "canonicalization" which does not coincide with what is > being done here. The term comes from an older pass that did similar algorithms on MIR. They are only borrowing the

[clang] llvm-canon (PR #68176)

2023-10-05 Thread Puyan Lotfi via cfe-commits
plotfi wrote: I recall approving the original PR on phab. I can re-review if needed. This work was approved to land before, so personally I think it might be overkill to RFC it on discourse again but I am not certain of the right process to take. > Added @plotfi as a reviewer; one drive-by

[clang] [WIP][ObjC] objc_direct method visibility ABI (PR #76608)

2023-12-29 Thread Puyan Lotfi via cfe-commits
https://github.com/plotfi created https://github.com/llvm/llvm-project/pull/76608 _**Posting this PR for posterity a bit earlier than I had intended because he old Phabricator is crashing (https://discourse.llvm.org/t/cant-access-https-reviews-llvm-org/75905):**_ This patch adds the ability

[clang] [WIP][ObjC] objc_direct method visibility ABI (PR #76608)

2023-12-29 Thread Puyan Lotfi via cfe-commits
https://github.com/plotfi edited https://github.com/llvm/llvm-project/pull/76608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][ObjC] objc_direct method visibility ABI (PR #76608)

2023-12-29 Thread Puyan Lotfi via cfe-commits
https://github.com/plotfi edited https://github.com/llvm/llvm-project/pull/76608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][ObjC] objc_direct method visibility ABI (PR #76608)

2023-12-29 Thread Puyan Lotfi via cfe-commits
https://github.com/plotfi edited https://github.com/llvm/llvm-project/pull/76608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][ObjC] objc_direct method visibility ABI (PR #76608)

2023-12-29 Thread Puyan Lotfi via cfe-commits
https://github.com/plotfi updated https://github.com/llvm/llvm-project/pull/76608 >From 8c13976e842fcbe3446dff43aaf95a4ae6334ae9 Mon Sep 17 00:00:00 2001 From: Puyan Lotfi Date: Fri, 29 Dec 2023 23:13:02 -0800 Subject: [PATCH] [WIP][ObjC] objc_direct method visibility ABI This patch adds the

[clang-tools-extra] [llvm] [clang] [LLVM] Add IRNormalizer Pass (PR #68176)

2023-11-28 Thread Puyan Lotfi via cfe-commits
plotfi wrote: > Pinging @nikic for another round of review. @nikic is there more feedback or can this PR be merged? https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org