Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

On 13 August 2015 at 07:15, Yaron Keren via cfe-commits cfe-commits@lists.llvm.org wrote: CHECK-EIGHT is failing bots, see http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c That check only works if compiler-rt

[libcxxabi] r245449 - [AArch64] Quick fix for cxa demangler

Author: rengolin Date: Wed Aug 19 10:24:03 2015 New Revision: 245449 URL: http://llvm.org/viewvc/llvm-project?rev=245449view=rev Log: [AArch64] Quick fix for cxa demangler This makes all libcxxabi tests pass on AArch64. Further changes and new tests to come. Patch by Keith Walker. Modified:

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

rengolin added a comment. I'm surprised you decided to rearrange the output of the macros. It makes reviewing a lot harder. Is there some special reason to have that in any specific order? Comment at: lib/Basic/Targets.cpp:4621 @@ -4586,1 +4620,3 @@ +

Re: Buildbot e-mail notification has been changed

On 28 October 2015 at 16:33, Galina Kistanova via llvm-commits wrote: > E-mail notification has been changed in the buildmaster. Now it should not > count interrupted builds to figure out if notification should be send. Thanks Galina, that'll reduce the noise

Re: [PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

rengolin accepted this revision. rengolin added a comment. I wish there was a way to get the info if a target is thumb-only, but this is ok as an intermediate solution. :) LGTM too, thanks! http://reviews.llvm.org/D14121 ___ cfe-commits mailing

Re: [PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

rengolin added inline comments. Comment at: test/Driver/arm-ias-Wa.s:67 @@ +66,3 @@ +// == Triple +// RUN: %clang -target armv7a-arm-none-eabi -c %s -### 2>&1 \ +// RUN: | FileCheck -check-prefix=CHECK-A-PROFILE %s

Re: [PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

On 27 October 2015 at 18:15, Tim Northover via cfe-commits wrote: > It sets the underlying platform to a Darwin one so that -arch armv7 flag > works as expected. Still looks weird. I don't think this should work at all, as in, the driver should emit an error like "no

Re: [PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

rengolin added inline comments. Comment at: lib/Driver/ToolChain.cpp:485 @@ +484,3 @@ +if ((ARM::parseArchProfile(Suffix) == ARM::PK_M) || +(InputType != types::TY_PP_Asm && + Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb, ThumbDefault)))

Re: [PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

rengolin added inline comments. Comment at: lib/Driver/ToolChain.cpp:472 @@ -471,2 +471,3 @@ +bool ThumbDefault = (ARM::parseArchProfile(Suffix) == ARM::PK_M) || (Suffix.startswith("v7") && getTriple().isOSBinFormatMachO()); // FIXME: this is invalid for WindowsCE

Re: [PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

rengolin added inline comments. Comment at: lib/Driver/ToolChain.cpp:485 @@ +484,3 @@ +if ((ARM::parseArchProfile(Suffix) == ARM::PK_M) || +(InputType != types::TY_PP_Asm && + Args.hasFlag(options::OPT_mthumb, options::OPT_mno_thumb, ThumbDefault)))

Re: [PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

rengolin added a comment. In http://reviews.llvm.org/D14121#276389, @t.p.northover wrote: > If you're on Linux or something you need "clang -target x86_64-apple-darwin > -arch armv7 -c tmp.s". x86_64 + ARMv7? This doesn't make sense... What is this trying to achieve? > I suspect the reason

Re: [PATCH] D14121: Thumb state not being passed through to LLVM triple when using clang -cc1as

rengolin added a comment. LGTM, thanks! http://reviews.llvm.org/D14121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

rengolin closed this revision. rengolin added a comment. r252463 Repository: rL LLVM http://reviews.llvm.org/D14184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r252463 - [EABI] Add Clang support for -meabi flag

Author: rengolin Date: Mon Nov 9 06:40:41 2015 New Revision: 252463 URL: http://llvm.org/viewvc/llvm-project?rev=252463=rev Log: [EABI] Add Clang support for -meabi flag The -meabi flag to control LLVM EABI version. Without '-meabi' or with '-meabi default' imply LLVM triple default. With

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. Hi Akira, I'm uncomfortable with this change, since it introduces a dependency between the two calls, and that's fragile. Also, the nullptr fiddling is not a good design overall. If there is a dependency, I suggest you encode it directly into

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. In http://reviews.llvm.org/D14471#285492, @ahatanak wrote: > Which two calls? Do you mean getAArch64TargetCPU and > getAArch64ArchFeaturesFromMcpu? No, the two getAArch64TargetCPU calls, but they don't even get called twice, and the value is write-only. Ignore that.

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. In http://reviews.llvm.org/D14471#288621, @ahatanak wrote: > In getAArch64TargetCPU, if it finds out the cpu name passed via -mtune or > -mcpu is "native", > > 1. Call llvm::sys::getHostCPUName to get the host CPU name. > 2. Check the host CPU name to see if it is a

Re: [PATCH] D14609: [ARM, AArch64] Fix __rev16l and __rev16ll intrinsics

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. LGTM. The 64-bit rev pattern can be added later. Thanks! Repository: rL LLVM http://reviews.llvm.org/D14609

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. In http://reviews.llvm.org/D14471#286380, @ahatanak wrote: > I think I can use macro __aarch64__ to have getAArch64TargetCPU return > "native" when the compiler is not run on an AArch64 platform, but it doesn't > sound like that was what you had in mind? Not at all.

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM http://reviews.llvm.org/D14184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

rengolin added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:458 @@ +457,3 @@ +StringRef Value = A->getValue(); +bool Valid = llvm::StringSwitch(Value) + .Case("default", true) tinti wrote: > tinti wrote: > > compnerd wrote: > > >

r251696 - Revert "Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots."

Author: rengolin Date: Fri Oct 30 06:12:36 2015 New Revision: 251696 URL: http://llvm.org/viewvc/llvm-project?rev=251696=rev Log: Revert "Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots." This reverts commit r251695. Debug is meant to be done off tree, not use the

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

rengolin added reviewers: jroelofs, t.p.northover. rengolin added subscribers: jroelofs, t.p.northover. rengolin added a comment. You forgot to add the context. It makes a big difference in the driver code. :) But overall, looks good to me. @jroelofs @compnerd @t.p.northover, can you see

Re: r251695 - Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots.

On 30 October 2015 at 10:35, Vasileios Kalintiris via cfe-commits wrote: > Author: vkalintiris > Date: Fri Oct 30 05:35:38 2015 > New Revision: 251695 > > URL: http://llvm.org/viewvc/llvm-project?rev=251695=rev > Log: > Try to run and investigate the mips-mti-linux.c

Re: r251695 - Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots.

On 30 October 2015 at 11:42, Vasileios Kalintiris wrote: > I'm sorry for any inconvenience I might have caused. I was waiting to commit > this early in the morning, near the end of the week, when the commit activity > is low. This shouldn't be done even during

Re: [PATCH] D14384: [ARM] Clang gives unintended warning message for 'mthumb' + M-profiles

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D14384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rengolin added a comment. Hi Asiri, Can I propose a different approach? We now have a silent buildbot, which will never email people about breakages, but can be publicly monitored by you, me and others. I'm assuming you have access to at least one x86 and one ARM machines, so that you could

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

rengolin added a comment. In http://reviews.llvm.org/D14293#281176, @jroelofs wrote: > I think this ^ is a reasonable solution. I'm fine with that, as long as everyone's happy. 160 XFAILs are ok (as long as you're fixing them), disabling the tests makes no sense. :) cheers, --renato

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

rengolin added inline comments. Comment at: lib/Driver/Tools.cpp:3415 @@ -3414,1 +3414,3 @@ + CmdArgs.push_back("-meabi"); + if (Arg *A = Args.getLastArg(options::OPT_meabi)) Shouldn't we only add the option if it was used in the command line?

r249699 - Simplify DefaultCPU in ARMTargetInfo

Author: rengolin Date: Thu Oct 8 11:43:26 2015 New Revision: 249699 URL: http://llvm.org/viewvc/llvm-project?rev=249699=rev Log: Simplify DefaultCPU in ARMTargetInfo Simplifying the convoluted CPU handling in ARMTargetInfo. The default base CPU on ARM is ARM7TDMI, arch ARMv4T, and

Re: [PATCH] D13930: Fix __ARM_FP value for sp-only FPUs with Half-precision

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D13930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r250283 - Support every kind of initialization.

On 14 October 2015 at 10:22, Angel Garcia Gomez via cfe-commits wrote: > Author: angelgarcia > Date: Wed Oct 14 04:22:32 2015 > New Revision: 250283 > > URL: http://llvm.org/viewvc/llvm-project?rev=250283=rev > Log: > Support every kind of initialization. Hi, this

Re: [PATCH] D13498: Silence spurious warning from lit about missing clang-interpreter

rengolin added a subscriber: rengolin. rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. Thanks! http://reviews.llvm.org/D13498 ___

Re: [PATCH] D14773: [ARM] Support +feature targeting in -mcpu/-march

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks! Repository: rL LLVM http://reviews.llvm.org/D14773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r246359 - [AST] Don't crash when comparing incomplete object

On 29 August 2015 at 09:32, David Majnemer via cfe-commits cfe-commits@lists.llvm.org wrote: Author: majnemer Date: Sat Aug 29 03:32:55 2015 New Revision: 246359 URL: http://llvm.org/viewvc/llvm-project?rev=246359view=rev Log: [AST] Don't crash when comparing incomplete object We cannot

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On 1 September 2015 at 18:15, Aaron Ballman wrote: > It seems unlikely as this shouldn't effect codegen. None of the other > bots seem to be red because it either. FWIW, my tests were 32-bit x86 > on Windows 10 with MSVC 2015. Ok, I cleared the stage2 build directory,

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On 1 September 2015 at 19:23, Aaron Ballman wrote: > On Tue, Sep 1, 2015 at 2:10 PM, Renato Golin wrote: >> On 1 September 2015 at 18:17, Renato Golin wrote: >>> Ok, I cleared the stage2 build directory, let's see how

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On 1 September 2015 at 18:17, Renato Golin wrote: > Ok, I cleared the stage2 build directory, let's see how this build goes... > > http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost-neon/builds/3248 Nah, there is something definitely wrong with that. I'll

Re: r246548 - Add a new frontend warning for referencing members from the handler of a constructor or destructor function-try-block, which is UB in C++.

On 1 September 2015 at 20:09, Aaron Ballman wrote: > Like a parameter/local misalignment? Yes, I think due to placement new for inherited classes, ignoring the padding between the base class and the inherited extra. Anyway, it's not your commit, as I just got a failure

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

rengolin added a comment. Hi Alexandros, Sorry, I was on holidays. Apart from my comment, everything else looks good. cheers, --renato Comment at: lib/Basic/Targets.cpp:4790 @@ +4789,3 @@ + Builder.defineMacro("__ARM_FEATURE_SAT", "1"); +

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

rengolin added a comment. Also, the target parser code has changed, please make sure it still works with the new version. http://reviews.llvm.org/D12244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r246755 - [ARM] Allow passing/returning of __fp16 arguments

On 3 September 2015 at 10:34, Oliver Stannard via cfe-commits wrote: > Author: olista01 > Date: Thu Sep 3 04:34:53 2015 > New Revision: 246755 > > URL: http://llvm.org/viewvc/llvm-project?rev=246755=rev > Log: > [ARM] Allow passing/returning of __fp16 arguments > >

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4790 @@ +4789,3 @@ + Builder.defineMacro("__ARM_FEATURE_SAT", "1"); + Builder.defineMacro("__ARM_FEATURE_QBIT", "1"); +} labrinea wrote: > rengolin wrote: > > Isn't there a

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

rengolin added a comment. I don't like the idea of making it language-specific, but I don't have a better idea. I don't know if there are support flags in Clang's languages like we have for back-ends. Anyway, this should fix the current problem. Maybe adding a comment to that effect on the

Re: [PATCH] D12722: cortex-r5f and cortex-m4f are unknown names for clang

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. As required by http://reviews.llvm.org/D12692. LGTM, thanks! http://reviews.llvm.org/D12722 ___ cfe-commits mailing list

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4785 @@ +4784,3 @@ +if (Opts.C99 && !Opts.Freestanding) { + Builder.defineMacro("__ARM_FP_FENV_ROUNDING", "1"); + Builder.defineMacro("__STDC_IEC_559__", "1"); I'm not convinced by

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin added reviewers: rsmith, t.p.northover. rengolin added a comment. Adding Richard Smith, as he was the one choosing C99/!freestanding for runtime rounding. Comment at: lib/Basic/Targets.cpp:4790 @@ -4779,1 +4789,3 @@ +if (!Opts.C11) +

Re: [PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

rengolin added a subscriber: rengolin. rengolin added a comment. Hi John, Can you expand a bit more on why you need this, what's the use case, and hopefully attach a test for them? cheers, --renato Repository: rL LLVM http://reviews.llvm.org/D12903

Re: [PATCH] D12903: Allow the -load option in the driver and pass it through to -cc1

rengolin added a comment. Hi John, Looks all right to me, but I don't want to approve without someone more familiar with the -load option to agree that this is not an exclusively internal option. Other than that, I'm happy with it. cheers, --renato Repository: rL LLVM

Re: r248984 - Test fix

Right, I reverted both commits on r249005. Please, let me know if you need help testing on ARM before the next commit. This looks like it could be tested on any 32-bit platform, though, so you should be able to get it passing on ARM if you test and make it pass on x86. On 1 October 2015 at 09:44,

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4456 @@ -4455,3 +4455,1 @@ -if (ArchVersion < 6 || - (ArchVersion == 6 && ArchProfile == llvm::ARM::PK_M)) labrinea wrote: > rengolin wrote: > > Why is this not necessary any more? >

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Absolutely agree. If we miss some other target, we should add it there, too, not cover later. LGTM. Thanks! http://reviews.llvm.org/D13217

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Sorry, I've been redirected elsewhere for a few days. I agree that this is the best option, since that's the meaning of the flag, anyway. LGTM. --renato http://reviews.llvm.org/D12633

Re: [PATCH] D13217: [ARM] The Driver does not set the +strict-align flag when targeting armv6m + netbsd

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4456 @@ -4455,3 +4455,1 @@ -if (ArchVersion < 6 || - (ArchVersion == 6 && ArchProfile == llvm::ARM::PK_M)) Why is this not necessary any more? http://reviews.llvm.org/D13217

Re: [PATCH] D12903: Add -fplugin=name.so option to the driver

rengolin added a comment. In http://reviews.llvm.org/D12903#249406, @thakis wrote: > Also also, this approach fundamentally doesn't work on Windows. I don't think it's supposed to, anyway. :) Repository: rL LLVM http://reviews.llvm.org/D12903

Re: [PATCH] D13013: [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Apart from the style nitpick, LGTM. Thanks! Comment at: lib/Driver/Tools.cpp:6139 @@ +6138,3 @@ + ArchKind = llvm::ARM::parseCPUArch(Triple.getARMCPUForArch(Arch));

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin added a comment. In http://reviews.llvm.org/D12633#250612, @labrinea wrote: > __ARM_FP_FAST is defined to 1 if floating-point optimizations may occur such > that the computed results are different from those prescribed by the order of > operations according to the C standard. Examples

Re: [PATCH] D13013: [ARM] Fix crash "-target arm -mcpu=generic", without "-march="

rengolin added a comment. Hi Vladmir, Can you explain what the crash was? cheers, --renato Repository: rL LLVM http://reviews.llvm.org/D13013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12633: Implement ACLE 2.0 macros of chapters 6.6 and 6.7 for [ARM] and [Aarch64] targets

rengolin added a comment. Richard, The original patch was following a lot from the AArch64, so I suspect we should first fix the AArch64 side, so that we can follow in a similar way. I don't want to have two different behaviour for ARM and AArch64 regarding macros and ACLE support. But I also

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

rengolin added a comment. IIUC, HF builds still produce soft float attributes, and that's the problem. http://reviews.llvm.org/D12996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r246223 - [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

Thanks! On 28 Aug 2015 9:33 pm, Simon Pilgrim llvm-...@redking.me.uk wrote: Thanks for the heads up Renato. I've a candidate fix (it was missing REQUIRES: x86-registered-target) and will commit it later and keep an extra eye on the non-x86 buildbots. On 28/08/2015 20:41, Renato Golin wrote:

r246323 - Revert [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

Author: rengolin Date: Fri Aug 28 14:39:29 2015 New Revision: 246323 URL: http://llvm.org/viewvc/llvm-project?rev=246323view=rev Log: Revert [X86][3DNow] Added debug codegen test for 3DNow! intrinsics This reverts commit r246223, as it broke all ARM/AArch64 bots. Modified:

Re: r246206 - [X86][FMA4] Added debug codegen test for FMA4 intrinsics

Hi Simon, This one too, reverted in r246320. cheers, --renato On 27 August 2015 at 21:41, Simon Pilgrim via cfe-commits cfe-commits@lists.llvm.org wrote: Author: rksimon Date: Thu Aug 27 15:41:45 2015 New Revision: 246206 URL: http://llvm.org/viewvc/llvm-project?rev=246206view=rev Log:

r246320 - Revert [X86][FMA4] Added debug codegen test for FMA4 intrinsics

Author: rengolin Date: Fri Aug 28 14:36:27 2015 New Revision: 246320 URL: http://llvm.org/viewvc/llvm-project?rev=246320view=rev Log: Revert [X86][FMA4] Added debug codegen test for FMA4 intrinsics This reverts commit r246206, as it broke all ARM/AArch64 bots. Modified:

r246321 - Revert [X86][XOP] Added debug codegen test for XOP intrinsics

Author: rengolin Date: Fri Aug 28 14:38:05 2015 New Revision: 246321 URL: http://llvm.org/viewvc/llvm-project?rev=246321view=rev Log: Revert [X86][XOP] Added debug codegen test for XOP intrinsics This reverts commit r246211, as it broke all ARM/AArch64 bots. Modified:

Re: r246211 - [X86][XOP] Added debug codegen test for XOP intrinsics

And this one, too, in r246321. --renato On 27 August 2015 at 22:32, Simon Pilgrim via cfe-commits cfe-commits@lists.llvm.org wrote: Author: rksimon Date: Thu Aug 27 16:32:03 2015 New Revision: 246211 URL: http://llvm.org/viewvc/llvm-project?rev=246211view=rev Log: [X86][XOP] Added debug

Re: r246223 - [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

And finally this one in r246323. Please, move all those tests to an X86 specific area and check the AArch64 bots after commit to make sure it passes. You probably didn't get the email because the bot was broken when you committed, then all your other commits were breaking a broken bot. :)

Re: [PATCH] D15142: Teaches clang about Cortex-A35.

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. Isn't it time we move AArch64 to the target parser, too? Anyway, as it is, LGTM, for the time being. Thanks! Repository: rL LLVM

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

On 1 December 2015 at 17:23, James Molloy via cfe-commits wrote: > This isn't just a NEON intrinsics thing, and this isn't just an ARM/AArch64 > thing. There needs to be some way to test the compiler from start to finish. > Not being able to do so leaves serious

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

On 1 December 2015 at 18:29, David Blaikie wrote: > Are they things the test-suite couldn't (either technically or > philosophically) cover, or only that it doesn't cover it at the moment, but > could do so? IMO, it's a philosophical issue. The test-suite is a whole-program

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

On 1 December 2015 at 19:09, David Blaikie wrote: > Not sure I follow - I'm not suggesting adding objdump/instruction checking > to existing large programs in the test-suite, but adding other tests to the > test-suite that do this and have appropriate input for it to be a >

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

On 1 December 2015 at 19:53, James Molloy wrote: > I think I'd be OK with demoting these tests to the test-suite, and dealing > with the slightly lower amount of testing that comes with it if it means we > can keep the clang tests in a nice shape. If the tests are

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

rengolin added a comment. Well, I only saw later that these are propositions from another patch... I don't see why this can't be part of the original patch, but I'm ok with no tests if they're used (and tested) on the final patch. I'll defer to Logan to decide. :)

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

rengolin added a comment. Tests? http://reviews.llvm.org/D15883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r253859 - Fix calculation of shifted cursor/code positions. Specifically support

On 23 November 2015 at 10:41, Daniel Jasper wrote: > Seen and fixed, I think.. Still looks broken... :) http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/7684 http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/2616

Re: r254251 - ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply

On 1 December 2015 at 11:44, James Molloy via cfe-commits wrote: > In summary, I agree with you that we need tests for both Clang and LLVM > separately. However I also think the full-trip tests add significant value > and wouldn't like to see them removed, and there's

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM, too. Thanks! Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r253859 - Fix calculation of shifted cursor/code positions. Specifically support

On 23 November 2015 at 08:33, Daniel Jasper via cfe-commits wrote: > Author: djasper > Date: Mon Nov 23 02:33:48 2015 > New Revision: 253859 > > URL: http://llvm.org/viewvc/llvm-project?rev=253859=rev > Log: > Fix calculation of shifted cursor/code positions.

Re: r253859 - Fix calculation of shifted cursor/code positions. Specifically support

On 23 November 2015 at 22:31, Daniel Jasper wrote: > Fixed in r253929. Thanks! ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20908: Add a few missing Clang regression tests

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D20908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

rengolin added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3817 @@ +3816,3 @@ + +Value *Arg0 = EmitScalarExpr(E->getArg(0)); /* coproc */ +Value *Arg1 = EmitScalarExpr(E->getArg(1)); /* opc1 */ Would be better to use the comments as names and

Re: [PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Thanks Ranjeet, looks much better now! LGTM, Thanks! http://reviews.llvm.org/D21179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:5709 @@ -5716,3 +5708,3 @@ void getTargetDefines(const LangOptions , MacroBuilder ) const override { We'll have to re-work these parts anyway. When I was looking to do

Re: [PATCH] D20709: Support ARM subtarget feature +long64

rengolin added a comment. In http://reviews.llvm.org/D20709#443950, @srhines wrote: > Correct. This is only used by RenderScript, and unfortunately can't be done > any differently. We had hoped to just predicate this with our own LangOpt > (the patch that adds the RenderScript LangOpt is

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

rengolin added a comment. In http://reviews.llvm.org/D18035#440107, @rsmith wrote: > Please try to appropriately apportion the responsibility here; if your > distribution opted into a non-standard ABI for their C++ standard library, > you should point out to them that they made a mistake. I

Re: [libcxx] r273078 - Fix 3 bugs in filesystem tests and implementation.

On 18 June 2016 at 05:10, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Fri Jun 17 23:10:23 2016 > New Revision: 273078 > > URL: http://llvm.org/viewvc/llvm-project?rev=273078=rev > Log: > Fix 3 bugs in filesystem tests and implementation. Hi Eric,

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

rengolin added a comment. In http://reviews.llvm.org/D21277#459703, @jojo wrote: > Do you mean updating the diff to let it include the change of > http://reviews.llvm.org/D21276,or commiting these two reviews as one commit? Committing them as one, after they're both approved. Repository:

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

rengolin added a comment. Hi Jojo, This looks good to me, and I recommend you squash this patch with http://reviews.llvm.org/D21276 before commit. But I'll let @echristo and @compnerd have the final say. cheers, --renato Repository: rL LLVM http://reviews.llvm.org/D21277

Re: [clang-tools-extra] r273660 - Remove ignoringImplicit from clang-tidy.

On 24 June 2016 at 10:39, Cong Liu via cfe-commits wrote: > Author: congliu > Date: Fri Jun 24 04:39:28 2016 > New Revision: 273660 > > URL: http://llvm.org/viewvc/llvm-project?rev=273660=rev > Log: > Remove ignoringImplicit from clang-tidy. Hi Cong, Isn't this

Re: r257754 - PR25910: clang allows two var definitions with the same mangled name

On 14 January 2016 at 10:41, Andrey Bokhanko via cfe-commits wrote: > Author: asbokhan > Date: Thu Jan 14 04:41:16 2016 > New Revision: 257754 > > URL: http://llvm.org/viewvc/llvm-project?rev=257754=rev > Log: > PR25910: clang allows two var definitions with the same

Re: r257934 - [CMake] Support generation of linker order files using dtrace

On 15 January 2016 at 21:21, Chris Bieneman via cfe-commits wrote: > Author: cbieneman > Date: Fri Jan 15 15:21:12 2016 > New Revision: 257934 > > URL: http://llvm.org/viewvc/llvm-project?rev=257934=rev > Log: > [CMake] Support generation of linker order files using

Re: r257934 - [CMake] Support generation of linker order files using dtrace

It did, thanks! On 15 January 2016 at 23:28, Chris Bieneman wrote: > That should be fixed with r257948. > > -Chris > >> On Jan 15, 2016, at 3:19 PM, Renato Golin wrote: >> >> On 15 January 2016 at 21:21, Chris Bieneman via cfe-commits >>

Re: r259622 - Fix miscompile and rejects-valids when disambiguating after an ambiguous

On 3 February 2016 at 18:53, Richard Smith wrote: > Fixed in r259677, sorry about that! No worries, thanks! --renato ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

On 6 February 2016 at 06:52, Samuel Antao via cfe-commits wrote: > Author: sfantao > Date: Sat Feb 6 00:52:48 2016 > New Revision: 259985 > > URL: http://llvm.org/viewvc/llvm-project?rev=259985=rev > Log: > Re-apply r259977 - [OpenMP] Reorganize code to allow

r260036 - Revert "Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices."

Author: rengolin Date: Sun Feb 7 09:43:09 2016 New Revision: 260036 URL: http://llvm.org/viewvc/llvm-project?rev=260036=rev Log: Revert "Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices." This reverts commit r259985, as it still fails one

Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

On 7 February 2016 at 17:29, Samuel F Antao wrote: > Hi Renato, > > This is not related with my patch, I'm afraid your buildbot won't go green > with the revert. This looks to be related with r259976. My patch > triggered the problem because it touched a CmakeList.txt. The

Re: r260077 - [OPENMP 4.5] Ccapture/codegen of private non-static data members.

Hi Alexey, It's still broken on ARM: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/10409 cheers, --renato On 8 February 2016 at 14:25, Alexey Bataev via cfe-commits wrote: > Ok, thanks a lot! Hope it will fix win-based buildbots completely. >

[libunwind] r260595 - [AArch64] Fix libunwind build when using GNU assembler

Author: rengolin Date: Thu Feb 11 15:22:57 2016 New Revision: 260595 URL: http://llvm.org/viewvc/llvm-project?rev=260595=rev Log: [AArch64] Fix libunwind build when using GNU assembler Use x29 and x30 for fp and lr respectively. This does not change the code generation with integrated asm but

Re: [PATCH] D17124: Add driver support for Qualcomm Kryo cpu.

rengolin added a comment. In http://reviews.llvm.org/D17124#350229, @mcrosier wrote: > Committed r260555. It would have been better to commit the LLVM parts first. Now, there will be a range where kyro will be accepted by Clang but broken when it gets to setup the target. --renato

  1   2   3   4   >