[PATCH] D30238: [Driver] Enable SafeStack for Fuchsia targets

mcgrathr created this revision. The runtime support is provided directly by the Fuchsia system C library. Repository: rL LLVM https://reviews.llvm.org/D30238 Files: lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h Index: lib/Driver/ToolChains.h

[PATCH] D30238: [Driver] Enable SafeStack for Fuchsia targets

mcgrathr added a comment. This assumes https://reviews.llvm.org/D30237 Repository: rL LLVM https://reviews.llvm.org/D30238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30238: [Driver] Enable SafeStack for Fuchsia targets

mcgrathr updated this revision to Diff 89393. mcgrathr added a comment. Added test case. Repository: rL LLVM https://reviews.llvm.org/D30238 Files: lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h test/Driver/fuchsia.c Index: test/Driver/fuchsia.c

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

mcgrathr updated this revision to Diff 88064. https://reviews.llvm.org/D29843 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/ItaniumCXXABI.cpp Index: lib/CodeGen/ItaniumCXXABI.cpp === ---

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

mcgrathr updated this revision to Diff 88068. mcgrathr added a comment. This now passes check-clang. https://reviews.llvm.org/D29843 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/global-init.cpp

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

mcgrathr added a comment. This was just the first crack, my first attempt at any change in LLVMland. I don't know how to run the tests yet. https://reviews.llvm.org/D29843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29843: [CodeGen] Treat auto-generated __dso_handle symbol as HiddenVisibility

mcgrathr updated this revision to Diff 88067. https://reviews.llvm.org/D29843 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/global-init.cpp test/OpenMP/threadprivate_codegen.cpp Index:

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D32231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr updated this revision to Diff 109428. mcgrathr added a comment. Added tests. https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index: test/Driver/fuchsia.c

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

mcgrathr created this revision. The .gnu_hash format is superior, and all versions of the Fuchsia dynamic linker support it. Repository: rL LLVM https://reviews.llvm.org/D36254 Files: lib/Driver/ToolChains/Fuchsia.cpp Index: lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D36202: [Driver] Disable static C++ library support on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM. The nit below is orthogonal to this change. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:112 ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); -if

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() phosek wrote: > I

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

mcgrathr updated this revision to Diff 109603. mcgrathr added a comment. Added test. https://reviews.llvm.org/D36254 Files: lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index: test/Driver/fuchsia.c === ---

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr updated this revision to Diff 109605. mcgrathr added a comment. Check -dynamic-linker in test. https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index:

[PATCH] D36779: [Driver] SafeStack does not need a runtime library on Fuchsia

mcgrathr created this revision. mcgrathr added a project: Sanitizers. Repository: rL LLVM https://reviews.llvm.org/D36779 Files: include/clang/Driver/SanitizerArgs.h lib/Driver/SanitizerArgs.cpp test/Driver/fuchsia.c Index: test/Driver/fuchsia.c

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

mcgrathr requested changes to this revision. mcgrathr added a comment. This revision now requires changes to proceed. Looks almost right. Might be overkill to add a test case that -z rodynamic is omitted with -fuse-ld=gold or something. Comment at:

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35603: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=...

mcgrathr created this revision. The driver ignores -fsanitize-coverage=... flags when also given -fsanitize=... flags for sanitizer flavors that don't support the coverage runtime. This logic failed to account for subsequent -fno-sanitize=... flags that disable the sanitizer flavors that

[PATCH] D35705: [CMake] Use ABI version 2 for C++ library

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35747: [Driver] Fuchsia defaults to -fno-math-errno

mcgrathr created this revision. Repository: rL LLVM https://reviews.llvm.org/D35747 Files: lib/Driver/ToolChains/Fuchsia.h Index: lib/Driver/ToolChains/Fuchsia.h === --- lib/Driver/ToolChains/Fuchsia.h +++

[PATCH] D35747: [Driver] Fuchsia defaults to -fno-math-errno

mcgrathr updated this revision to Diff 107752. mcgrathr added a comment. test case https://reviews.llvm.org/D35747 Files: lib/Driver/ToolChains/Fuchsia.h test/Driver/fast-math.c Index: test/Driver/fast-math.c === ---

[PATCH] D35747: [Driver] Fuchsia defaults to -fno-math-errno

mcgrathr added a comment. Please land it for me when approved. https://reviews.llvm.org/D35747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM. Perhaps there should be a test. Repository: rL LLVM https://reviews.llvm.org/D35820 ___ cfe-commits mailing list

[PATCH] D35930: [CMake] Include sancov tool in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr created this revision. mcgrathr added a project: Sanitizers. Herald added subscribers: mgorny, srhines. Repository: rL LLVM https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp Index:

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

mcgrathr added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:56 +foreach(target x86_64;aarch64) + set(RUNTIMES_${target}-fuchsia-asan_CMAKE_BUILD_WITH_INSTALL_RPATH ON CACHE BOOL "") Can you do this without duplicating all the identical

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D32613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32613: [Driver] Update Fuchsia driver path handling

mcgrathr added a comment. Perhaps use llvm::sys::path::parent_path instead of explicit "..". Perhaps put the getDriver.Dir() + .. + getTriple().str() logic into a shared subroutine. Use default rather that CST_Libstdcxx in the switches on GetCXXStdlibType. Repository: rL LLVM

[PATCH] D37723: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables

mcgrathr created this revision. Herald added subscribers: kristof.beyls, aemerson. This regressed for x86-64 in r307856 because it's no longer inherited from Generic_GCC. We'd never noticed that it was missing other targets (i.e. aarch64), but Fuchsia is uniform across all machines.

[PATCH] D37785: [Fuchsia] Set ENABLE_X86_RELAX_RELOCATIONS for Fuchsia builds

mcgrathr created this revision. Herald added a subscriber: mgorny. This is a "Does your linker support it?" option, and all ours do. Repository: rL LLVM https://reviews.llvm.org/D37785 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Since we use lld, -Wl,-O2 also helps make the binaries smaller. Repository: rL LLVM https://reviews.llvm.org/D39017 ___ cfe-commits

[PATCH] D39176: [Driver] Use ld.lld directly for Fuchsia rather than passing flavor

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. This seems like how it always should have been, since -fuse-ld=lld sets it to ld.lld, not lld. Looks to me like the existing MipsLinux and WebAssembly implementations are wrong too and

[PATCH] D40329: [CMake][Fuchsia] Disable terminfo database in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D40329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM with comment added but if a different approach will be required for multiple Linux targets (which we all treat as "hostish") then it's worth at least thinking about that now.

[PATCH] D39831: [Driver] Make the use of relax relocations a per target option

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D39831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39831: [Driver] Make the use of relax relocations a per target option

mcgrathr added a comment. test case? Repository: rL LLVM https://reviews.llvm.org/D39831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40319: [libcxx] Support getentropy as a source of randomness for std::random_device

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D40319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

mcgrathr added a comment. In principle this should be OK since we're unconditionally building the runtimes for `default`. However, this means that any dynamically-linked host builds will assume our toolchain-provided shared libraries are available on the runtime host in standard library

[PATCH] D39270: [CMake] Include clang-refactor in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D39270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39273: [CMake] Build host builtins in Fuchsia toolchain even on Darwin

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D39273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48208: [Fuchsia] Enable static libc++, libc++abi, libunwind

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D48208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47668: [Driver][Fuchsia] Pass LTO flags to linker

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D47668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47758: [Fuchsia] Include install-distribution-stripped in bootstrap targets

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D47758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48564: [CMake] Support passing FUCHSIA_SDK as the only variable

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D48564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48563: [CMake] Use explicit targets for building Linux runtimes

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D48563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46361: [CMake][Cache] Stop pretending that Fuchsia is UNIX

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. fnu lgtm Repository: rC Clang https://reviews.llvm.org/D46361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

mcgrathr added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152 + llvm::sys::path::append(P, normalizeTriple(Triple)); + return P.str(); +} The GCC behavior (if --with-sysroot is given to configure) is tooldir/sys-root, not tooldir itself.

[PATCH] D41471: [CMake][Fuchsia] Enable assertions

mcgrathr created this revision. mcgrathr added a reviewer: phosek. Herald added a subscriber: mgorny. Enable assertions in both stages. Release+Asserts is fast enough. No need to let insanity through. Repository: rC Clang https://reviews.llvm.org/D41471 Files:

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

mcgrathr added a comment. I think this wants to be a hard error rather than a warning. Though since we use -Werror anyway if others feel strongly contrary I won't object. Repository: rC Clang https://reviews.llvm.org/D49511 ___ cfe-commits

[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

mcgrathr added a comment. Is this still live? Should it be different after all the multiarch stuff? Repository: rC Clang https://reviews.llvm.org/D42019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51573: [Driver] Search LibraryPaths when handling -print-file-name

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. The log message could give concrete examples. Comment at: clang/lib/Driver/Driver.cpp:4169 std::string Driver::GetFilePath(StringRef Name, const ToolChain ) const { -

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

mcgrathr added inline comments. Comment at: lib/Parse/ParseDecl.cpp:244-252 +// If this was declared in a macro, attatch the macro IdentifierInfo to the +// parsed attribute. +for (const auto : PP.getAttributeMacros()) { + if

[PATCH] D44947: [Driver] Add fuzzer-no-link into the list of supported Fuchsia sanitizers

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D44947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

mcgrathr added a comment. We aren't actually using DWARF 5 yet AFAICT. Our builds don't pass -gdwarf-5. So I'm not sure we have yet verified that all the DWARF-consuming tools people are using with Fuchsia binaries can handle all of DWARF 5 (which has several major format changes). I'd

[PATCH] D44724: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. Lgtm with some more comments Repository: rC Clang https://reviews.llvm.org/D44724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44724: [Fuchsia] Avoid using static ABI library with libc++ on Darwin

mcgrathr added a comment. When targetting Darwin we should really not be even compiling libc++/libc++abi and certainly should not have anything else compiling against their headers since at runtime the system libraries will be used and so things better compile against the system headers that

[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D43992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53487: [Driver] Support sanitized libraries on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:566 + for (const auto : TC.getLibraryPaths()) { +if(LibPath.length() > 0) { + SmallString<128>

[PATCH] D53787: [Sema] Use proper visibility for global new and delete declarations

mcgrathr added a comment. In https://reviews.llvm.org/D53787#1282975, @rsmith wrote: > These symbols really are special. Other symbols are introduced explicitly by > a declaration, whereas these are declared implicitly by the compiler. The implicit declaration is the only difference that

[PATCH] D53787: [Sema] Use proper visibility for global new and delete declarations

mcgrathr added a comment. In https://reviews.llvm.org/D53787#1279899, @rsmith wrote: > Replacing the global new and delete is supposed to be a whole-program > operation (you only get one global allocator). Otherwise you couldn't > allocate memory in one DSO and deallocate it in another. (And

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

mcgrathr added a comment. In https://reviews.llvm.org/D53787#1283051, @rsmith wrote: > In https://reviews.llvm.org/D53787#1282995, @mcgrathr wrote: > > > In https://reviews.llvm.org/D53787#1282975, @rsmith wrote: > > > > > Other symbols must have exactly one definition (modulo the permission for

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

mcgrathr accepted this revision. mcgrathr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:125 !Args.hasArg(options::OPT_static); +

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

mcgrathr reopened this revision. mcgrathr added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128 if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bstatic"); +

[PATCH] D54064: [Driver] Always match resource dir in Fuchsia driver tests

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D54064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

mcgrathr added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128 if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bstatic"); + CmdArgs.push_back("-static"); ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); MaskRay

[PATCH] D54082: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D54082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53970: [CMake][Fuchsia] Don't restrict Linux runtimes to UNIX

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D53970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54169: [clang-tidy] Zircon ->

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D54169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54463: [CMake] Support cross-compiling with Fuchsia toolchain build

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D54463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54112: [Driver] Delete redundant -Bdynamic for libc++ on Fuchsia

mcgrathr requested changes to this revision. mcgrathr added a comment. This revision now requires changes to proceed. This breaks the semantics we want. The `-Bdynamic` is there to apply to `-lm`, which is also what `--as-needed` is there for in this case (it appears earlier because of the

[PATCH] D54026: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. So the default is not per-target? It should be. Repository: rC Clang https://reviews.llvm.org/D54026 ___ cfe-commits mailing list

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

mcgrathr added a comment. The motivating use case always pairs `noderef` with an `address_space` attribute, and it's already invalid to convert between pointer types in different address spaces without a cast. So I don't think we have a strong opinion one way or the other. In the abstract,

[PATCH] D52402: [CMake][Fuchsia] Use internal_linkage rather than always_inline for libc++

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm as long as we revert when the underlying bugs are resovled Repository: rC Clang https://reviews.llvm.org/D52402 ___ cfe-commits

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D52660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56349: [CMake][Fuchsia] Enable x86 relaxation by default

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm. Wouldn't hurt to comment that this depends on a linker new enough to support the new reloc types (only reason it's conditional at all) and since we default to lld we don't worry

[PATCH] D56348: [CMake][Fuchsia] Enable --build-id linker flag by default

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56348/new/ https://reviews.llvm.org/D56348 ___

[PATCH] D56350: [CMake][Fuchsia] Enable experimental new pass manager by default

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56350/new/ https://reviews.llvm.org/D56350 ___

[PATCH] D56359: [CMake][Fuchsia] Enable build ID, relaxations for first stage

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56359/new/ https://reviews.llvm.org/D56359 ___

[PATCH] D56972: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56972/new/ https://reviews.llvm.org/D56972 ___

[PATCH] D56652: [CMake][Fuchsia] Synchronize first and second stage builds

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56652/new/ https://reviews.llvm.org/D56652 ___

[PATCH] D55405: [CMake] Use hidden visibility for static libc++ in Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55405/new/ https://reviews.llvm.org/D55405 ___

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. IMHO the library code should use `#if !__has_feature(...)` to avoid the definitions entirely when built with a sanitizer whose runtime provides them. But this is a fine way to achieve that

[PATCH] D58325: [Driver][Fuchsia] Support -nolibc flag

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. This is only on GCC trunk (i.e. 9), not in 8.2 or even the current gcc-8 branch. So clarify the log entry. We don't know if 8.x,x>2 will add it or only gcc 9. Repository: rC Clang

[PATCH] D58010: [CodeGen] Set construction vtable visibility after creating initializer

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm with a comment (and perhaps an assertion). Comment at: clang/lib/CodeGen/CGVTables.cpp:777 + CGM.setGVProperties(VTable, RD); + Give it a

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm contingent on verifying intended behavior changes and adding comments. The factoring suggestion for the triple,triple searching is preferred but at your discretion, though I'd

[PATCH] D62469: [Driver] Change layout of per-target runtimes to resemble multiarch

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62469/new/ https://reviews.llvm.org/D62469

[PATCH] D62558: [Driver] Search the toolchain dir with -print-file-name

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62558/new/ https://reviews.llvm.org/D62558 ___

[PATCH] D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62712/new/ https://reviews.llvm.org/D62712 ___

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. Lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64605/new/ https://reviews.llvm.org/D64605 ___

[PATCH] D64140: [CMake][Fuchsia] Define asan+noexcept multilib

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64140/new/ https://reviews.llvm.org/D64140 ___

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1507 +Multilib::flags_list ) { + if (Enabled) +

[PATCH] D60990: [Driver] Support priority for multilibs

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Multilib.h:81 + /// Returns the multilib priority. + int priority() const { return Priority; } Say

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

mcgrathr added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:179 + .flag("+fno-exceptions"); + Multilib ASan = Multilib("/asan", "", "", 2).flag("+fsanitize=address"); + Multilibs.push_back(Default); Add a

[PATCH] D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

mcgrathr created this revision. mcgrathr added reviewers: phosek, MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. These "sanitizers" are hardened ABIs that are wholly orthogonal to the SanitizerCoverage instrumentation. Repository: rG LLVM Github Monorepo

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

mcgrathr created this revision. Herald added subscribers: cfe-commits, cryptoad, kristof.beyls, javed.absar. Herald added a project: clang. On AArch64, Fuchsia fully supports both SafeStack and ShadowCallStack ABIs. The latter is now preferred and will be the default. It's possible to enable

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

mcgrathr added reviewers: phosek, leonardchan, jakehehrlich. mcgrathr added a comment. This should land only after we've done our first stages of downstream roll-out and burn-in testing. But setting it up now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64603: [Target] Use IEEE quad format for long double on Fuchsia x86_64

mcgrathr added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:858 + : FuchsiaTargetInfo(Triple, Opts) { +LongDoubleFormat = ::APFloat::IEEEquad(); + } Can we just do this in FuchsiaTargetInfo generically? I think we'd like to make our core

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

mcgrathr updated this revision to Diff 225273. mcgrathr added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66712/new/ https://reviews.llvm.org/D66712 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

mcgrathr added a comment. It's time to land this now. Can one of you commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66712/new/ https://reviews.llvm.org/D66712 ___ cfe-commits mailing

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

mcgrathr updated this revision to Diff 241561. mcgrathr added a comment. style nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73734/new/ https://reviews.llvm.org/D73734 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index:

  1   2   >