Author: lebedevri
Date: Fri Aug 10 08:05:46 2018
New Revision: 339437
URL: http://llvm.org/viewvc/llvm-project?rev=339437&view=rev
Log:
[clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix
Summary:
Currently, there is two configured prefixes: `CHECK-FIXES` and `CHECK-MESSAGES`
`CHECK-MESS
No test?
On Tue, Aug 14, 2018 at 8:06 PM, Kevin P. Neal via cfe-commits
wrote:
> Author: kpn
> Date: Tue Aug 14 10:06:56 2018
> New Revision: 339693
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339693&view=rev
> Log:
>
> We have in place support for parsing #pragma FENV_ACCESS, but that
> inf
Author: lebedevri
Date: Fri Aug 17 00:33:25 2018
New Revision: 339995
URL: http://llvm.org/viewvc/llvm-project?rev=339995&view=rev
Log:
[NFC] Some small test updates for Implicit Conversion sanitizer.
Split off from D50250.
Added:
cfe/trunk/test/CodeGen/catch-implicit-integer-conversions-bas
Author: lebedevri
Date: Tue May 8 16:15:58 2018
New Revision: 331822
URL: http://llvm.org/viewvc/llvm-project?rev=331822&view=rev
Log:
Partially revert r331456: [clang-tidy] Remove AnalyzeTemporaryDtors option.
That broke every single .clang-tidy config out there
which happened to specify Analyz
On Fri, May 18, 2018 at 8:47 PM, tzik via cfe-commits
wrote:
> Ah, sorry. It's still work in progress for now.
> I'll resend this soon after adding tests and updating comments there.
See Herald rules for exact syntax, but i think adding "[private]" into
the subject
would have prevented it from goi
On Fri, Oct 6, 2017 at 3:15 PM, Erik Viktorsson via cfe-commits
wrote:
Hi.
> Committing a patch to Bugzilla 31373
>
> A novice programmer so hopefully it complies with the coding policy.
I think it may be better to put it to Phabricator, see
https://llvm.org/docs/Phabricator.html#id3
Please do n
Author: lebedevri
Date: Thu Oct 12 13:16:51 2017
New Revision: 315614
URL: http://llvm.org/viewvc/llvm-project?rev=315614&view=rev
Log:
[Sema] Diagnose tautological comparison with type's min/max values
Summary:
Currently, clang only diagnoses completely out-of-range comparisons (e.g.
`char` and
Author: lebedevri
Date: Thu Oct 12 13:27:41 2017
New Revision: 315615
URL: http://llvm.org/viewvc/llvm-project?rev=315615&view=rev
Log:
[Analysis] Silence -Wtautological-constant-compare in two tests
Yes, did not check that. Need to do better :(
I do not believe it makes sense to do expect that w
Author: lebedevri
Date: Thu Oct 12 14:15:26 2017
New Revision: 315622
URL: http://llvm.org/viewvc/llvm-project?rev=315622&view=rev
Log:
[Analysis] Un-silence -Wtautological-unsigned-zero-compare in null-deref-ps.c
Stage-2 builds failed:
error: 'warning' diagnostics expected but not seen:
File
||
> static_cast(region.size) >
> std::numeric_limits::max()) {
> DLOG(ERROR) << "Region bounds are not valid for mmap";
> return false;
> }
>
> This code works in 64-bit and 32-bit. off_t has different sizes on both, s
Author: lebedevri
Date: Thu Oct 12 15:03:20 2017
New Revision: 315631
URL: http://llvm.org/viewvc/llvm-project?rev=315631&view=rev
Log:
Revert "[Sema] Diagnose tautological comparison with type's min/max values"
This reverts r315614,r315615,r315621,r315622
Breaks http://bb9.pgr.jp/#/builders/20/b
On Fri, Oct 13, 2017 at 1:22 AM, Richard Smith wrote:
> On 12 October 2017 at 15:11, Roman Lebedev via Phabricator via cfe-commits
> wrote:
>>
>> lebedev.ri reopened this revision.
>> lebedev.ri added a comment.
>> This revision is now accepted and ready to land.
>>
>> Reverted due to http://bb9.
Author: lebedevri
Date: Sun Oct 15 13:13:17 2017
New Revision: 315875
URL: http://llvm.org/viewvc/llvm-project?rev=315875&view=rev
Log:
[Sema] Re-land: Diagnose tautological comparison with type's min/max values
The first attempt, rL315614 was reverted because one libcxx
test broke, and i did not
Author: lebedevri
Date: Sun Oct 15 13:12:42 2017
New Revision: 315874
URL: http://llvm.org/viewvc/llvm-project?rev=315874&view=rev
Log:
Silence clang's -Wtautological-constant-compare in last_write_time.pass.cpp
Previously this broke the builders, when D38101 was committed.
Silence the warning so
Author: lebedevri
Date: Sun Oct 15 13:46:12 2017
New Revision: 315876
URL: http://llvm.org/viewvc/llvm-project?rev=315876&view=rev
Log:
Really do make sure that last_write_time.pass.cpp still works with old clang
I *did* try to check that such kind of an issue was not introduced
by the rL315874,
Author: lebedevri
Date: Sun Oct 15 14:52:53 2017
New Revision: 315882
URL: http://llvm.org/viewvc/llvm-project?rev=315882&view=rev
Log:
Fix last_write_time.pass.cpp to work with clang-3.9 and earlier
At least with clang-3.9 and earlier, -Wunknown-pragmas is also needed.
Modified:
libcxx/tru
ng std::numeric_limits<>.
Right now, sadly, i do not see any simple false-positive here.
Roman.
> On Sun, Oct 15, 2017 at 1:12 PM Roman Lebedev via cfe-commits
> wrote:
>>
>> Author: lebedevri
>> Date: Sun Oct 15 13:12:42 2017
>> New Revision: 315874
>>
>&g
On Fri, Oct 20, 2017 at 11:44 AM, Mikhail Artemyev via cfe-commits
wrote:
> Hi All,
>
> The attached patch adds a new option '-fno-var-tracking-assignments' in the
> same group (clang_ignored_f_Group) where the existing '-fno-var-tracking'
> resides.
It might be best to upload it to https://llvm.o
Author: lebedevri
Date: Sat Oct 21 09:44:03 2017
New Revision: 316268
URL: http://llvm.org/viewvc/llvm-project?rev=316268&view=rev
Log:
[Sema] Fixes for enum handling for tautological comparison diagnostics
Summary:
As Mattias Eriksson has reported in PR35009, in C, for enums, the underlying
typ
ompare diagnostic (and i suspect there may be
more repercussions) was not really intentional.
However as you have said, and i think i agree, the diagnostic valid.
So perhaps i simply should add a test and release notes entry?
Roman.
> On Sat, Oct 21, 2017 at 6:44 PM, Roman Lebedev via cfe-commits
>
Author: lebedevri
Date: Tue Oct 24 14:05:43 2017
New Revision: 316500
URL: http://llvm.org/viewvc/llvm-project?rev=316500&view=rev
Log:
[Sema] Document+test the -Wsign-compare change for enums in C code [NFC]
rL316268 / D39122 has fixed PR35009, and now when in C,
these three(?) diagnostics prope
reasonable. It turns out we only got this single extra
> -Wsign-compare warning, so it didn't turn out to be a big problem for
> us.
Ok, committed in https://reviews.llvm.org/rL316500
Roman.
>>
>> Roman.
>>
>>> On Sat, Oct 21, 2017 at 6:44 PM, Roman Lebede
On Tue, Aug 28, 2018 at 10:48 AM, Haojian Wu via cfe-commits
wrote:
> Author: hokein
> Date: Tue Aug 28 00:48:28 2018
> New Revision: 340800
>
> URL: http://llvm.org/viewvc/llvm-project?rev=340800&view=rev
> Log:
> [clang-tidy] Abseil: no namepsace check
>
> This check ensures that users of Abseil
I don't think this was reviewed. The differential is not in 'accepted' state.
Roman.
On Fri, Aug 31, 2018 at 2:10 AM, Stephen Kelly via cfe-commits
wrote:
> Author: steveire
> Date: Thu Aug 30 16:10:52 2018
> New Revision: 341140
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341140&view=rev
>
I don't think this was reviewed. The differential is not in 'accepted' state.
Roman.
On Fri, Aug 31, 2018 at 2:11 AM, Stephen Kelly via cfe-commits
wrote:
> Author: steveire
> Date: Thu Aug 30 16:11:01 2018
> New Revision: 341141
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341141&view=rev
>
I don't think this was reviewed. The differential is not in 'accepted' state.
Roman.
On Fri, Aug 31, 2018 at 2:25 AM, Stephen Kelly via cfe-commits
wrote:
> Author: steveire
> Date: Thu Aug 30 16:25:38 2018
> New Revision: 341144
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341144&view=rev
>
anks for any post-commit review!
>
> Stephen.
Roman.
> On 31/08/18 07:06, Roman Lebedev via cfe-commits wrote:
>>
>> I don't think this was reviewed. The differential is not in 'accepted'
>> state.
>>
>> Roman.
>>
>> On Fri, Aug 31,
Author: lebedevri
Date: Mon Sep 10 12:59:18 2018
New Revision: 341854
URL: http://llvm.org/viewvc/llvm-project?rev=341854&view=rev
Log:
[clang-tidy] ExprMutationAnalyzer: construct from references. Fixes PR3
Summary:
I have hit this the rough way, while trying to use this in D51870.
There is
On Fri, Sep 14, 2018 at 3:21 PM, Kirill Bobyrev via cfe-commits
wrote:
> Author: omtcyfz
> Date: Fri Sep 14 05:21:09 2018
> New Revision: 342227
>
> URL: http://llvm.org/viewvc/llvm-project?rev=342227&view=rev
> Log:
> [clangd] NFC: Fix IndexBenchmark CLI arguments handling
>
> Modified:
> cla
Test?
On Mon, Jul 23, 2018 at 11:49 PM, Aaron Smith via Phabricator via
llvm-commits wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rC337736: [CodeGen] Record if a C++ record is a trivial type
> (authored by asmith, committed by ).
>
> Repos
Author: lebedevri
Date: Tue Jul 24 01:16:50 2018
New Revision: 337815
URL: http://llvm.org/viewvc/llvm-project?rev=337815&view=rev
Log:
[Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)
Summary:
As discussed in [[ https://bugs.llvm.org/show_bug.cgi?id=38166 | PR38166
Author: lebedevri
Date: Fri Jul 27 00:27:14 2018
New Revision: 338108
URL: http://llvm.org/viewvc/llvm-project?rev=338108&view=rev
Log:
[AST] Sink 'part of explicit cast' down into ImplicitCastExpr
Summary:
As discussed in IRC with @rsmith, it is slightly not good to keep that in the
`CastExpr`
Author: lebedevri
Date: Mon Jul 30 11:58:30 2018
New Revision: 338288
URL: http://llvm.org/viewvc/llvm-project?rev=338288&view=rev
Log:
[clang][ubsan] Implicit Conversion Sanitizer - integer truncation - clang part
Summary:
C and C++ are interesting languages. They are statically typed, but weak
Author: lebedevri
Date: Mon Jul 30 14:11:32 2018
New Revision: 338306
URL: http://llvm.org/viewvc/llvm-project?rev=338306&view=rev
Log:
[docs] UndefinedBehaviorSanitizer.rst: {,un}signed-integer-overflow: tune docs
Yes, i erroneously assumed that the "after" was meant,
but i was wrong:
> I really
Author: lebedevri
Date: Tue Jul 31 23:06:16 2018
New Revision: 338489
URL: http://llvm.org/viewvc/llvm-project?rev=338489&view=rev
Log:
[AST] CastExpr: BasePathSize is not large enough.
Summary:
rC337815 / D49508 had to cannibalize one bit of
`CastExprBitfields::BasePathSize` in order to squeeze
On Wed, Aug 1, 2018 at 8:36 PM, Richard Smith wrote:
> On Tue, 31 Jul 2018, 23:06 Roman Lebedev via cfe-commits,
> wrote:
>>
>> Author: lebedevri
>> Date: Tue Jul 31 23:06:16 2018
>> New Revision: 338489
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev
Author: lebedevri
Date: Wed Aug 1 14:20:58 2018
New Revision: 338640
URL: http://llvm.org/viewvc/llvm-project?rev=338640&view=rev
Log:
[NFC][CodeGenCXX] Use -emit-llvm-only instead of -emit-llvm and ignoring it.
As pointed out by Richard Smith in post-review of r338489.
Modified:
cfe/trunk/
r338640
On Wed, Aug 1, 2018 at 8:38 PM, Roman Lebedev wrote:
> On Wed, Aug 1, 2018 at 8:36 PM, Richard Smith wrote:
>> On Tue, 31 Jul 2018, 23:06 Roman Lebedev via cfe-commits,
>> wrote:
>>>
>>> Author: lebedevri
>>> Date: Tue Jul 31 23:06:16 2018
On Thu, Feb 15, 2018 at 3:48 PM, Aaron Ballman via cfe-commits
wrote:
> On Thu, Feb 15, 2018 at 4:11 AM, Phabricator via Phabricator
> wrote:
>> This revision was automatically updated to reflect the committed changes.
>> Closed by commit rL325222: [clang-tidy] New checker for exceptions that are
On Tue, Jun 6, 2017 at 8:52 PM, David Blaikie wrote:
>
>
> On Tue, Jun 6, 2017 at 3:59 AM Roman Lebedev via Phabricator
> wrote:
>>
>> lebedev.ri added a comment.
>>
>> In https://reviews.llvm.org/D33102#773296, @dblaikie wrote:
>>
>> > I still feel like that's more testing than would be ideal (d
Author: lebedevri
Date: Fri Jun 9 07:00:04 2017
New Revision: 305067
URL: http://llvm.org/viewvc/llvm-project?rev=305067&view=rev
Log:
[clang-tools-extra] ReleaseNotes.rst: test commit: whitespace fix
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/
Author: lebedevri
Date: Fri Jun 9 09:22:10 2017
New Revision: 305082
URL: http://llvm.org/viewvc/llvm-project?rev=305082&view=rev
Log:
[clang-tidy] readability-function-size: add NestingThreshold param.
Summary:
Finds compound statements which create next nesting level after
`NestingThreshold`
On Fri, Jun 9, 2017 at 11:28 PM, David Blaikie wrote:
> Looks all good
OK, thank you.
> please commit whenever you're ready - if you don't have
> commit access, I (or anyone else with commit access) can commit this for
> you.
Will re-test and commit in +~12 hours.
> On Tue, Jun 6, 2017 at 1:57 P
On Sat, Jun 10, 2017 at 7:05 PM, David Blaikie wrote:
>
>
> On Sat, Jun 10, 2017 at 3:33 AM Roman Lebedev via Phabricator
> wrote:
>>
>> lebedev.ri planned changes to this revision.
>> lebedev.ri added a comment.
>>
>> In https://reviews.llvm.org/D33102#773296, @dblaikie wrote:
>>
>> > But sure.
Author: lebedevri
Date: Sat Jun 10 12:19:19 2017
New Revision: 305147
URL: http://llvm.org/viewvc/llvm-project?rev=305147&view=rev
Log:
[clang] Implement -Wcast-qual for C++
Summary:
This way, the behavior of that warning flag
more closely resembles that of GCC.
Do note that there is at least on
Author: lebedevri
Date: Sat Jun 10 12:49:23 2017
New Revision: 305148
URL: http://llvm.org/viewvc/llvm-project?rev=305148&view=rev
Log:
Revert "[clang] Implement -Wcast-qual for C++"
Breaks -Werror builders.
Removed:
cfe/trunk/test/SemaCXX/warn-cast-qual.cpp
Modified:
cfe/trunk/docs/Rele
On Mon, Jun 12, 2017 at 8:16 PM, David Blaikie wrote:
>
>
> On Mon, Jun 12, 2017 at 10:10 AM Roman Lebedev via Phabricator
> wrote:
>>
>> lebedev.ri added a comment.
>>
>> So i'm trying to analyze that stage2 warning.
>
>
> Could you link to the buildbot failure to see the original LLVM project c
Author: lebedevri
Date: Fri Jun 16 08:07:47 2017
New Revision: 305554
URL: http://llvm.org/viewvc/llvm-project?rev=305554&view=rev
Log:
[clang-tidy] readability-function-size: fix nesting level calculation
Summary:
A followup for D32942.
Malcolm Parsons has provided a valid testcase that the ini
On Tue, Dec 19, 2017 at 8:26 PM, Artem Dergachev via Phabricator via
cfe-commits wrote:
> NoQ updated this revision to Diff 127548.
> NoQ added a comment.
>
> - Fix comments as suggested by Devin.
> - Point out that arithmetic on void pointers is a GNU extension.
>
>
> https://reviews.llvm.org/D40
Author: lebedevri
Date: Wed Jan 3 00:45:19 2018
New Revision: 321691
URL: http://llvm.org/viewvc/llvm-project?rev=321691&view=rev
Log:
[Sema] -Wtautological-constant-compare is too good. Cripple it.
Summary:
The diagnostic was mostly introduced in D38101 by me, as a reaction to wasting
a lot of
It seems the test is missing?
On Sun, Jan 7, 2018 at 8:39 PM, Marshall Clow via cfe-commits
wrote:
> Author: marshall
> Date: Sun Jan 7 09:39:57 2018
> New Revision: 321966
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321966&view=rev
> Log:
> Mark the transparent version set::count() as cons
Author: lebedevri
Date: Tue Feb 27 07:19:28 2018
New Revision: 326202
URL: http://llvm.org/viewvc/llvm-project?rev=326202&view=rev
Log:
[Tooling] [1/1] Refactor FrontendActionFactory::create() to return
std::unique_ptr<>
Summary:
I'm not sure whether there are any principal reasons why it return
Author: lebedevri
Date: Tue Feb 27 07:19:20 2018
New Revision: 326201
URL: http://llvm.org/viewvc/llvm-project?rev=326201&view=rev
Log:
[Tooling] [0/1] Refactor FrontendActionFactory::create() to return
std::unique_ptr<>
Summary:
Noticed during review of D41102.
I'm not sure whether there are a
Author: lebedevri
Date: Tue Feb 27 07:54:41 2018
New Revision: 326203
URL: http://llvm.org/viewvc/llvm-project?rev=326203&view=rev
Log:
Revert "[Tooling] [1/1] Refactor FrontendActionFactory::create() to return
std::unique_ptr<>"
This reverts commit rL326202
This broke gcc4.8 builds, compiler j
Author: lebedevri
Date: Tue Feb 27 07:54:55 2018
New Revision: 326204
URL: http://llvm.org/viewvc/llvm-project?rev=326204&view=rev
Log:
Revert "[Tooling] [0/1] Refactor FrontendActionFactory::create() to return
std::unique_ptr<>"
This reverts commit rL326201
This broke gcc4.8 builds, compiler j
Author: lebedevri
Date: Wed Mar 14 12:31:34 2018
New Revision: 327558
URL: http://llvm.org/viewvc/llvm-project?rev=327558&view=rev
Log:
[Parser] (C++) Make -Wextra-semi slightly more useful
Summary:
Let's suppose the `-Weverything` is passed.
Given code like
```
void F() {}
;
```
If the code is
Author: lebedevri
Date: Fri Mar 16 11:01:07 2018
New Revision: 327725
URL: http://llvm.org/viewvc/llvm-project?rev=327725&view=rev
Log:
[docs] ReleaseNotes: document -Wextra-semi changes.
I should have done it in rL327558 / D43162, but forgot..
I'm not 100% sure about the text, but i don't think
Author: lebedevri
Date: Mon Jun 4 05:04:51 2018
New Revision: 333891
URL: http://llvm.org/viewvc/llvm-project?rev=333891&view=rev
Log:
[clang][tooling] Don't forget to link to clangToolingInclusions.
Fixes build with shared libs, broken by rL333874.
Some buildbot converage is sorely missing.
Mo
Author: lebedevri
Date: Mon Jun 4 05:04:41 2018
New Revision: 333890
URL: http://llvm.org/viewvc/llvm-project?rev=333890&view=rev
Log:
[clang][tooling] Don't forget to link to clangToolingInclusions.
Fixes build with shared libs, broken by rL333874.
Some buildbot converage is sorely missing.
Mo
That was supposed to be "[clangd][tests] Don't forget to link to
clangToolingInclusions.".
On Mon, Jun 4, 2018 at 3:04 PM, Roman Lebedev via cfe-commits
wrote:
> Author: lebedevri
> Date: Mon Jun 4 05:04:51 2018
> New Revision: 333891
>
> URL: http://llvm.org/viewv
This broke building as shared libraries.
I've committed the fix, but the bot coverage is clearly severely missing,
given that such breakages are very often.
Roman.
On Mon, Jun 4, 2018 at 12:04 PM, Eric Liu via cfe-commits
wrote:
> Author: ioeric
> Date: Mon Jun 4 02:04:12 2018
> New Revision:
lly setting BUILD_SHARED_LIBS
>> to TRUE if asserts are enabled? That’d automatically “force” active
>> developers to test the scenario on their local machines, but not change the
>> way release builds work.
>>
>>
>> > On Jun 4, 2018, at 8:11 AM, Roman Le
Did you use `arc patch` to get the commit description?
Please make sure that the first line of the commit is reasonable.
In this case it is not reasonable.
On Mon, Jun 4, 2018 at 7:07 PM, Leonard Chan via cfe-commits
wrote:
> Author: leonardchan
> Date: Mon Jun 4 09:07:52 2018
> New Revision: 33
This is strange.
First, i'm pretty sure the test worked for me before.
Second, this commit actually *breaks* those two tests for me:
$ ninja check-clang-tools
[0/1] Running the Clang extra tools' regression tests
FAIL: Clang Tools ::
clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp (123 of 8
Ah, hm, yes, that was a further local problem in https://reviews.llvm.org/D46602
And i didn't double-check on master initially, because that causes all
the checks to be rebuilt :/
So thanks for the fix!
Roman.
On Tue, Jun 5, 2018 at 1:40 PM, Sam McCall wrote:
> Hi Roman,
>
> Definitely somethi
Author: lebedevri
Date: Wed Jun 6 08:07:51 2018
New Revision: 334101
URL: http://llvm.org/viewvc/llvm-project?rev=334101&view=rev
Log:
[clang-tidy] Store checks profiling info as JSON files
Summary:
Continuation of D46504.
Example output:
```
$ clang-tidy -enable-check-profile -store-check-pr
Author: lebedevri
Date: Thu Oct 11 02:09:50 2018
New Revision: 344230
URL: http://llvm.org/viewvc/llvm-project?rev=344230&view=rev
Log:
[clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and
signed checks
Summary:
As per IRC disscussion, it seems we really want to have more
Author: lebedevri
Date: Thu Oct 18 13:06:40 2018
New Revision: 344755
URL: http://llvm.org/viewvc/llvm-project?rev=344755&view=rev
Log:
[clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT
DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)
Summary:
Detects when the integral l
Author: lebedevri
Date: Thu Oct 18 13:16:44 2018
New Revision: 344757
URL: http://llvm.org/viewvc/llvm-project?rev=344757&view=rev
Log:
[clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines,
HICPP)
Summary:
Finds classes that not only contain the data (non-static member
Author: lebedevri
Date: Thu Oct 18 13:27:10 2018
New Revision: 344758
URL: http://llvm.org/viewvc/llvm-project?rev=344758&view=rev
Log:
[clang-tidy] readability-uppercase-literal-suffix: specify target for fp tests
__float128 isn't universally avaliable.
Modified:
clang-tools-extra/trunk/te
Author: lebedevri
Date: Thu Oct 18 13:59:03 2018
New Revision: 344760
URL: http://llvm.org/viewvc/llvm-project?rev=344760&view=rev
Log:
[clang-tidy] readability-uppercase-literal-suffix: specify target for opencl
test
I'm not sure if it will actually help or not.
ppc64be-clang-lnt-test bot is fa
Author: lebedevri
Date: Thu Oct 18 23:04:07 2018
New Revision: 344772
URL: http://llvm.org/viewvc/llvm-project?rev=344772&view=rev
Log:
[clang-tidy] readability-uppercase-literal-suffix: specify target for ms test
too
Apparently the bots were still failing with this.
Sadly, i did not see *this*
Author: lebedevri
Date: Thu Oct 25 12:44:51 2018
New Revision: 345305
URL: http://llvm.org/viewvc/llvm-project?rev=345305&view=rev
Log:
[clang-tidy] Revert my readability-uppercase-literal-suffix check.
There are some lurking issues with the handling of the SourceManager.
Somehow sometimes we end
Author: lebedevri
Date: Fri Oct 26 06:09:27 2018
New Revision: 345381
URL: http://llvm.org/viewvc/llvm-project?rev=345381&view=rev
Log:
[clang-tidy] Re-commit: Add new 'readability-uppercase-literal-suffix' check
(CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)
Summary:
Detects when the
Author: lebedevri
Date: Tue Oct 30 05:37:16 2018
New Revision: 345594
URL: http://llvm.org/viewvc/llvm-project?rev=345594&view=rev
Log:
[clang] Move two utility functions into SourceManager
Summary: So we can keep that not-so-great logic in one place.
Reviewers: rsmith, aaron.ballman
Reviewed B
Author: lebedevri
Date: Tue Oct 30 08:52:36 2018
New Revision: 345610
URL: http://llvm.org/viewvc/llvm-project?rev=345610&view=rev
Log:
[clang-tidy] cppcoreguidelines-macro-usage: print macro names
Summary:
The macro may not have location (or more generally, the location may not exist),
e.g. if i
Author: lebedevri
Date: Tue Oct 30 14:58:56 2018
New Revision: 345660
URL: http://llvm.org/viewvc/llvm-project?rev=345660&view=rev
Log:
[clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part
This is the second half of Implicit Integer Conversion Sanitizer.
It completes th
Author: lebedevri
Date: Mon Jan 14 11:09:27 2019
New Revision: 351105
URL: http://llvm.org/viewvc/llvm-project?rev=351105&view=rev
Log:
[clang][UBSan] Sanitization for alignment assumptions.
Summary:
UB isn't nice. It's cool and powerful, but not nice.
Having a way to detect it is nice though.
[[
Thank you for the revert.
On Tue, Jan 15, 2019 at 6:41 AM Vlad Tsyrklevich via cfe-commits
wrote:
>
> Author: vlad.tsyrklevich
> Date: Mon Jan 14 19:38:02 2019
> New Revision: 351159
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351159&view=rev
> Log:
> Revert alignment assumptions changes
>
>
Author: lebedevri
Date: Tue Jan 15 01:44:25 2019
New Revision: 351177
URL: http://llvm.org/viewvc/llvm-project?rev=351177&view=rev
Log:
[clang][UBSan] Sanitization for alignment assumptions.
Summary:
UB isn't nice. It's cool and powerful, but not nice.
Having a way to detect it is nice though.
[[
Author: lebedevri
Date: Tue Jan 15 03:20:02 2019
New Revision: 351188
URL: http://llvm.org/viewvc/llvm-project?rev=351188&view=rev
Log:
[OpenCL] opencl-c.h: read_image*(): sampler-less, and image{1,2}d_array_t
variants are OpenCL-1.2+, mark them as such
Summary:
Refer to [[
https://www.khronos.
Please also note that "safe" functions are C11 Annex K, and it is Optional.
I believe glibc does not implement it, and has no intention of implementing it.
By memory, i'm not sure any library other than Microsoft's does provide it.
On Thu, Jan 17, 2019 at 9:17 PM Kristóf Umann via Phabricator
wro
Author: lebedevri
Date: Thu Jan 24 11:32:49 2019
New Revision: 352090
URL: http://llvm.org/viewvc/llvm-project?rev=352090&view=rev
Log:
[NFC][clang] Test updates for CreateAlignmentAssumption() changes in D54653
Differential Revision: https://reviews.llvm.org/D57175
Modified:
cfe/trunk/test/
Author: lebedevri
Date: Fri Jan 25 10:05:43 2019
New Revision: 352224
URL: http://llvm.org/viewvc/llvm-project?rev=352224&view=rev
Log:
Temporairly disable readability-uppercase-literal-suffix tests that depend on
_Float16, to get bots back to green
Modified:
clang-tools-extra/trunk/test/cl
This review is invalid, since the lists weren't subscribed.
On Fri, Jan 25, 2019 at 8:01 PM Erich Keane via cfe-commits
wrote:
>
> Author: erichkeane
> Date: Fri Jan 25 09:01:42 2019
> New Revision: 352219
>
> URL: http://llvm.org/viewvc/llvm-project?rev=352219&view=rev
> Log:
> Allow 'static' st
Author: lebedevri
Date: Mon Jan 28 09:04:11 2019
New Revision: 352390
URL: http://llvm.org/viewvc/llvm-project?rev=352390&view=rev
Log:
[clang][OpenMP] OMPFlushClause is synthetic, no such clause exists
Summary:
As discussed in https://reviews.llvm.org/D57112#inline-506781,
'flush' clause does no
Author: lebedevri
Date: Wed Jan 30 07:41:20 2019
New Revision: 352631
URL: http://llvm.org/viewvc/llvm-project?rev=352631&view=rev
Log:
[ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit
Summary:
Was trying to understand how complicated it would be to write
a clang-tidy `openmp-exception-escape
On Wed, Jan 30, 2019 at 6:46 PM Aaron Ballman wrote:
>
> On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits
> wrote:
> >
> > Author: lebedevri
> > Date: Wed Jan 30 07:41:20 2019
> > New Revision: 352631
> >
> > URL: http://llvm.org/vi
And another review that omitted lists.
On Fri, Feb 1, 2019 at 12:02 AM Thomas Lively via cfe-commits
wrote:
>
> Author: tlively
> Date: Thu Jan 31 13:02:19 2019
> New Revision: 352793
>
> URL: http://llvm.org/viewvc/llvm-project?rev=352793&view=rev
> Log:
> [WebAssembly] Add bulk memory target f
On Thu, Nov 1, 2018 at 3:03 AM Friedman, Eli wrote:
>
> On 10/30/2018 2:58 PM, Roman Lebedev via cfe-commits wrote:
> > Author: lebedevri
> > Date: Tue Oct 30 14:58:56 2018
> > New Revision: 345660
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=345660
Author: lebedevri
Date: Thu Nov 1 01:56:51 2018
New Revision: 345816
URL: http://llvm.org/viewvc/llvm-project?rev=345816&view=rev
Log:
[clang][CodeGen] ImplicitIntegerSignChangeSanitizer: actually ignore NOP casts.
I fully expected for that to be handled by the canonical type check,
but it clear
On Thu, Nov 1, 2018 at 9:39 AM Roman Lebedev wrote:
>
> On Thu, Nov 1, 2018 at 3:03 AM Friedman, Eli wrote:
> >
> > On 10/30/2018 2:58 PM, Roman Lebedev via cfe-commits wrote:
> > > Author: lebedevri
> > > Date: Tue Oct 30 14:58:56 2018
> > > New Revi
Test?
On Fri, Nov 9, 2018 at 4:34 AM Bill Wendling via cfe-commits
wrote:
>
> Author: void
> Date: Thu Nov 8 17:32:30 2018
> New Revision: 346461
>
> URL: http://llvm.org/viewvc/llvm-project?rev=346461&view=rev
> Log:
> Ignore implicit things like ConstantExpr.
>
> Modified:
>
> clang-tools
The codegen change can't be tested?
On Fri, Nov 9, 2018 at 10:44 PM Dylan McKay via cfe-commits
wrote:
>
> Author: dylanmckay
> Date: Fri Nov 9 11:42:05 2018
> New Revision: 346548
>
> URL: http://llvm.org/viewvc/llvm-project?rev=346548&view=rev
> Log:
> Use the correct address space when bitcast
Author: lebedevri
Date: Wed Nov 14 01:01:08 2018
New Revision: 346835
URL: http://llvm.org/viewvc/llvm-project?rev=346835&view=rev
Log:
[clang-tidy] Avoid C arrays check
Summary:
[[ https://bugs.llvm.org/show_bug.cgi?id=39224 | PR39224 ]]
As discussed, we can't always do the transform automatical
Author: lebedevri
Date: Tue Nov 20 10:59:05 2018
New Revision: 347339
URL: http://llvm.org/viewvc/llvm-project?rev=347339&view=rev
Log:
[clang][Parse] Diagnose useless null statements / empty init-statements
Summary:
clang has `-Wextra-semi` (D43162), which is not dictated by the currently
selec
""Re: [PATCH] D53812: [Analyzer] Iterator Checker - Forbid increments
past the begin() and decrements past the end() of containers"
Is it be or that reads backwards?
Why can't you increment past the begin()? Can you decrement past the
begin() instead?
And the opposite for the end().
On Sat, Dec 1,
On Wed, Dec 5, 2018 at 12:21 AM Eugene Zelenko via cfe-commits
wrote:
>
> Author: eugenezelenko
> Date: Tue Dec 4 13:19:08 2018
> New Revision: 348302
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348302&view=rev
> Log:
> [Documentation] Make options section in Clang-tidy
> readability-upperc
ld be worth it, as I haven’t seen bugs
> > arising from extra semicolons and empty statements,
> > but it would take care of my use case.
> >
>
> Or rather when the *previous* semicolon is coming from a macro.
I don't like this. clang is already wa-a-ay too forgiving ab
Can you please write better commit messages, especially the first subject line?
E.g. this should have been "[AST][NFC] Add dump test for ObjC generics"
On Thu, Dec 6, 2018 at 12:26 PM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Thu Dec 6 01:23:59 2018
> New Revision: 348471
1 - 100 of 321 matches
Mail list logo
