[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-02 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 193421. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added minor style changes and removed unnecessary inline comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-03-27 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 192541. Dosi-Dough marked 4 inline comments as done. Dosi-Dough added a comment. fixed bracketed return and added updated license CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] created wrap-unique check

2019-01-29 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough created this revision. Dosi-Dough added reviewers: EricWF, JonasToth. Dosi-Dough added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. based on abseil tip of the week 126 https://abseil.io/tips/126 Created a check which looks for instances of a factory

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-01-30 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 184431. Dosi-Dough marked 11 inline comments as done. Dosi-Dough added a comment. fixed white space/ formatting issues. removed .DS_Store. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-01-30 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 184437. Dosi-Dough added a comment. based on feedback: fixed whitespacing / formatting. Removed .DS_Store Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-10 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 194621. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added whitespace to check doc Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-10 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 194622. Dosi-Dough added a comment. added white space to check doc. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-10 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 194608. Dosi-Dough added a comment. fixed docs and white spacing Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-10 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 194618. Dosi-Dough marked 3 inline comments as done. Dosi-Dough added a comment. removed parens from turnary, added whitespace. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-10 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 194607. Dosi-Dough marked an inline comment as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-17 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough added a comment. Hi I was wondering if there were any other changes anyone recomends should be made to this revision? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-03-13 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough updated this revision to Diff 190552. Dosi-Dough marked 11 inline comments as done. Dosi-Dough added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. added style and performance refactoring based on code reviews Repository: rCTE Clang Tools Extra

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-30 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough added a comment. Gentle ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-24 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough added a comment. gentle ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-23 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough added a comment. @EricWF @JonasToth I was wondering what other changes I should make to submit my check upstream? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435