r293611 - Revert r293585 "Add better ODR checking for modules."

2017-01-31 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Jan 31 02:24:40 2017 New Revision: 293611 URL: http://llvm.org/viewvc/llvm-project?rev=293611=rev Log: Revert r293585 "Add better ODR checking for modules." We're seeing what we believe are false positives. (It's hard to tell with the available diagnostics, and I'm

r293473 - Revert r293455, which breaks v8 with a spurious error. Testcase added.

2017-01-30 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Jan 30 04:44:11 2017 New Revision: 293473 URL: http://llvm.org/viewvc/llvm-project?rev=293473=rev Log: Revert r293455, which breaks v8 with a spurious error. Testcase added. Summary: Revert r293455, which breaks v8 with a spurious error. Testcase added. Reviewers:

r293604 - In VirtualCallChecker, handle indirect calls

2017-01-30 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Jan 30 23:23:20 2017 New Revision: 293604 URL: http://llvm.org/viewvc/llvm-project?rev=293604=rev Log: In VirtualCallChecker, handle indirect calls Summary: In VirtualCallChecker, handle indirect calls. getDirectCallee() can be nullptr, and dyn_cast(nullptr) is UB

Re: [PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

2017-02-23 Thread Sam McCall via cfe-commits
On Feb 23, 2017 8:48 PM, "Haojian Wu via Phabricator" < revi...@reviews.llvm.org> wrote: hokein added inline comments. Comment at: unittests/include-fixer/find-all-symbols/ FindAllSymbolsTests.cpp:40 + void reportSymbols(llvm::StringRef FileName, +

Re: [PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

2017-02-24 Thread Sam McCall via cfe-commits
That's two votes for "this is too surprising" - changed. https://imgflip.com/i/1k93rm https://68.media.tumblr.com/8db2fe0a6f84ff128157a2b615f519bf/tumblr_inline_nenq4hMoQA1sb080b.gif On Fri, Feb 24, 2017 at 9:54 AM, Manuel Klimek wrote: > On Thu, Feb 23, 2017 at 10:40 PM Sam

Re: [PATCH] D29303: In VirtualCallChecker, handle indirect calls

2017-02-24 Thread Sam McCall via cfe-commits
Thanks Anna, I'm new to the release process here. Hans: this is a simple fix for a null-dereference in the static analyzer. Does it make sense to cherrypick? On Sat, Feb 18, 2017 at 2:46 AM, Anna Zaks via Phabricator < revi...@reviews.llvm.org> wrote: > zaks.anna added a comment. > > Has this

[clang-tools-extra] r296446 - [include-fixer] Add usage count to find-all-symbols.

2017-02-28 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Feb 28 02:13:15 2017 New Revision: 296446 URL: http://llvm.org/viewvc/llvm-project?rev=296446=rev Log: [include-fixer] Add usage count to find-all-symbols. Summary: Add usage count to find-all-symbols. FindAllSymbols now finds (most!) main-file usages of the

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

2016-10-06 Thread Sam McCall via cfe-commits
sammccall added a reviewer: rsmith. sammccall added a comment. (First patch, so please spell out mistakes!) I think the big question is whether it's okay to depend on Format. https://reviews.llvm.org/D25311 ___ cfe-commits mailing list

[PATCH] D26024: [Xray] Don't generate output for xray tests

2016-10-27 Thread Sam McCall via cfe-commits
sammccall created this revision. sammccall added a reviewer: dberris. sammccall added a subscriber: cfe-commits. Don't generate output for xray tests https://reviews.llvm.org/D26024 Files: test/Driver/XRay/xray-instrument-cpu.c test/Driver/XRay/xray-instrument-os.c Index:

[PATCH] D25936: Fix format string for err_os_log_argument_to_big (currently unused)

2016-10-25 Thread Sam McCall via cfe-commits
sammccall added a comment. In https://reviews.llvm.org/D25936#578341, @mehdi_amini wrote: > Good catch! How did you find this? We've got a library that parses diagnostics that consumes DiagnosticSemaKinds.inc, and it failed to parse this message format. > We need a test though. > (I can

[PATCH] D25936: Fix format string for err_os_log_argument_to_big (currently unused)

2016-10-25 Thread Sam McCall via cfe-commits
sammccall created this revision. sammccall added a reviewer: bkramer. sammccall added subscribers: cfe-commits, mehdi_amini. https://reviews.llvm.org/D25936 Files: include/clang/Basic/DiagnosticSemaKinds.td Index: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

2016-10-21 Thread Sam McCall via cfe-commits
sammccall added a comment. > I don't know the history behind the desired dependencies, I'll let others > comment whether this is OK, but my guess it that it depends on the tradeoff, > it's hard to justify 3 new deps for a change that is supposed to be simple. > How hard is to implement this

[PATCH] D26132: [clang-format] Skip over AnnotatedLines with >50 levels of nesting.

2016-10-30 Thread Sam McCall via cfe-commits
sammccall updated this revision to Diff 76348. sammccall added a comment. Fixing style. https://reviews.llvm.org/D26132 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D26132: [clang-format] Skip over AnnotatedLines with >50 levels of nesting.

2016-10-30 Thread Sam McCall via cfe-commits
sammccall created this revision. sammccall added a reviewer: djasper. sammccall added a subscriber: cfe-commits. Herald added a subscriber: klimek. Skip over AnnotatedLines with >50 levels of nesting; don't format them. Reasoning: - ExpressionParser uses a lot of stack for these, bad in some

[PATCH] D26067: [openmp] Remove test assumption that invoked binary name contains "clang"

2016-10-28 Thread Sam McCall via cfe-commits
sammccall updated this revision to Diff 76172. sammccall added a comment. Use -no-canonical-prefixes so that the invoked binary name will contain "clang" https://reviews.llvm.org/D26067 Files: test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D26067: [openmp] Remove test assumption that invoked binary name contains "clang"

2016-10-28 Thread Sam McCall via cfe-commits
sammccall created this revision. sammccall added a reviewer: bkramer. sammccall added a subscriber: cfe-commits. Remove test assumption that driver-invoked binary name contains "clang" https://reviews.llvm.org/D26067 Files: test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D26132: [clang-format] Skip over AnnotatedLines with >50 levels of nesting.

2016-10-31 Thread Sam McCall via cfe-commits
sammccall added a comment. Thanks Daniel. I don't have commit access, could you land this? https://reviews.llvm.org/D26132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25983: Fix use-after-free in ASTContext.

2016-10-26 Thread Sam McCall via cfe-commits
sammccall created this revision. sammccall added a reviewer: bkramer. sammccall added subscribers: cfe-commits, rsmith. Extend lifetime of ExceptionTypeStorage, as it is referenced by CanonicalEPI and used outside the block (ExceptionSpec.Exceptions is an ArrayRef)

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

2016-10-17 Thread Sam McCall via cfe-commits
sammccall added a comment. Ping - let me know if there's a more appropriate reviewer! https://reviews.llvm.org/D25311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r288892 - Compilation database test: don't try to output to CWD

2016-12-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Dec 7 03:19:07 2016 New Revision: 288892 URL: http://llvm.org/viewvc/llvm-project?rev=288892=rev Log: Compilation database test: don't try to output to CWD Summary: Write output from compilation database test to %T rather than the working dir. Sometimes CWD isn't

[clang-tools-extra] r297371 - [include-fixer] Remove line number from Symbol identity

2017-03-09 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Mar 9 04:47:44 2017 New Revision: 297371 URL: http://llvm.org/viewvc/llvm-project?rev=297371=rev Log: [include-fixer] Remove line number from Symbol identity Summary: Remove line number from Symbol identity. For our purposes (include-fixer and clangd autocomplete),

[clang-tools-extra] r297630 - [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

2017-03-13 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Mar 13 10:55:59 2017 New Revision: 297630 URL: http://llvm.org/viewvc/llvm-project?rev=297630=rev Log: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly. Summary: Add fuzzy SymbolIndex, where identifier needn't match exactly. The purpose

Re: [PATCH] D38464: [clangd] less boilerplate in RPC dispatch

2017-10-12 Thread Sam McCall via cfe-commits
Interesting - this is pretty primitive, and still fairly tightly coupled to JSON-RPC. I can't easily tell from the code how the ORC RPC functionality - would it be easy to use with JSON-RPC, does it make sense to use serialization only, does it have opinions about threading models? And really,

[clang-tools-extra] r315577 - [clangd] less boilerplate in RPC dispatch

2017-10-12 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Oct 12 06:29:58 2017 New Revision: 315577 URL: http://llvm.org/viewvc/llvm-project?rev=315577=rev Log: [clangd] less boilerplate in RPC dispatch Summary: Make the ProtocolHandlers glue between JSONRPCDispatcher and ClangdLSPServer generic. Eliminate small differences

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

2017-09-08 Thread Sam McCall via cfe-commits
Nice fix! It catches a lot of new cases on our codebase, all technically correct so far. A couple of issues though: A) Rollout - until we've completely cleaned up, we need to disable -Wtautological-compare entirely, which is a valuable check. I imagine anyone else using -Werror is in the same

[clang-tools-extra] r314587 - [clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC

2017-09-30 Thread Sam McCall via cfe-commits
Author: sammccall Date: Sat Sep 30 03:08:52 2017 New Revision: 314587 URL: http://llvm.org/viewvc/llvm-project?rev=314587=rev Log: [clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC Summary: There doesn't seem to be any real separation between the current three

[clang-tools-extra] r314532 - Small clangd cleanups, NFC

2017-09-29 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Sep 29 09:41:23 2017 New Revision: 314532 URL: http://llvm.org/viewvc/llvm-project?rev=314532=rev Log: Small clangd cleanups, NFC - remove old ASTUnit includes - fix typo (regiterCallbackHandlers) Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[clang-tools-extra] r318327 - [clangd] Try to unbreak tests on PS4 by targeting PC explicitly

2017-11-15 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 15 11:38:09 2017 New Revision: 318327 URL: http://llvm.org/viewvc/llvm-project?rev=318327=rev Log: [clangd] Try to unbreak tests on PS4 by targeting PC explicitly Modified: clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp Modified:

Re: [clang-tools-extra] r318327 - [clangd] Try to unbreak tests on PS4 by targeting PC explicitly

2017-11-15 Thread Sam McCall via cfe-commits
test that we have the right default behavior, which would be updated when the default changes. I can do some work on this, but I could use some advice from people more familiar with lit testing patterns. (Mostly this all seems like an argument for unit-testing instead, to me :-) On 15 November 2017 at 11:

Re: [clang-tools-extra] r318287 - [clangd] Support returning a limited number of completion results.

2017-11-15 Thread Sam McCall via cfe-commits
e this interfere > with our CI process. > > Thanks, > --paulr > PS4 code owner > > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > Sam McCall via cfe-commits > > Sent: Wednesday, No

[clang-tools-extra] r318329 - [clangd] Fix flag name from r318327

2017-11-15 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 15 12:10:14 2017 New Revision: 318329 URL: http://llvm.org/viewvc/llvm-project?rev=318329=rev Log: [clangd] Fix flag name from r318327 Modified: clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp Modified:

[clang-tools-extra] r318316 - [clangd] Fix time units in clangd performance trace

2017-11-15 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 15 09:53:46 2017 New Revision: 318316 URL: http://llvm.org/viewvc/llvm-project?rev=318316=rev Log: [clangd] Fix time units in clangd performance trace Modified: clang-tools-extra/trunk/clangd/Trace.cpp Modified: clang-tools-extra/trunk/clangd/Trace.cpp URL:

[clang-tools-extra] r318339 - [clangd] Loosen more brittle tests

2017-11-15 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 15 13:50:53 2017 New Revision: 318339 URL: http://llvm.org/viewvc/llvm-project?rev=318339=rev Log: [clangd] Loosen more brittle tests Modified: clang-tools-extra/trunk/test/clangd/completion-snippet.test clang-tools-extra/trunk/test/clangd/completion.test

[clang-tools-extra] r318337 - [clangd] Revert broken r318329 and disable tests on PS4

2017-11-15 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 15 13:33:56 2017 New Revision: 318337 URL: http://llvm.org/viewvc/llvm-project?rev=318337=rev Log: [clangd] Revert broken r318329 and disable tests on PS4 (Clearly this is not a permanent solution) Added: clang-tools-extra/trunk/test/clangd/lit.local.cfg

[clang-tools-extra] r318287 - [clangd] Support returning a limited number of completion results.

2017-11-15 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 15 01:16:29 2017 New Revision: 318287 URL: http://llvm.org/viewvc/llvm-project?rev=318287=rev Log: [clangd] Support returning a limited number of completion results. Summary: All results are scored, we only process CodeCompletionStrings for the winners. We now

r318286 - [clang] Expose orderedString from CodeCompletionResult. NFC

2017-11-15 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 15 01:15:06 2017 New Revision: 318286 URL: http://llvm.org/viewvc/llvm-project?rev=318286=rev Log: [clang] Expose orderedString from CodeCompletionResult. NFC Modified: cfe/trunk/include/clang/Sema/CodeCompleteConsumer.h

[clang-tools-extra] r319159 - [clangd] Switch from YAMLParser to JSONExpr

2017-11-28 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 28 01:37:43 2017 New Revision: 319159 URL: http://llvm.org/viewvc/llvm-project?rev=319159=rev Log: [clangd] Switch from YAMLParser to JSONExpr Summary: - Converted Protocol.h parse() functions to take JSON::Expr. These no longer detect and log unknown fields,

r318943 - [Tooling] Acknowledge that many CompilationDatabases don't support enumeration.

2017-11-24 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Nov 24 04:13:55 2017 New Revision: 318943 URL: http://llvm.org/viewvc/llvm-project?rev=318943=rev Log: [Tooling] Acknowledge that many CompilationDatabases don't support enumeration. Summary: Provide default implementations so that only getCompileCommands() is

[clang-tools-extra] r318928 - [clangd] Tracing improvements

2017-11-23 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 23 09:12:04 2017 New Revision: 318928 URL: http://llvm.org/viewvc/llvm-project?rev=318928=rev Log: [clangd] Tracing improvements Summary: [clangd] Tracing improvements Compose JSON using JSONExpr Allow attaching metadata to spans (and avoid it if tracing is off)

[clang-tools-extra] r318925 - [clangd] Drop impossible completions (unavailable or inaccessible)

2017-11-23 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 23 08:58:22 2017 New Revision: 318925 URL: http://llvm.org/viewvc/llvm-project?rev=318925=rev Log: [clangd] Drop impossible completions (unavailable or inaccessible) Summary: (There must be some reason why D38077 didn't just do this, but I don't get it!)

[clang-tools-extra] r318927 - [clangd] Make completion scores use 0-1 floats internally.

2017-11-23 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 23 09:09:04 2017 New Revision: 318927 URL: http://llvm.org/viewvc/llvm-project?rev=318927=rev Log: [clangd] Make completion scores use 0-1 floats internally. Summary: This scale is much easier to mix with other signals, such as fuzzy match strength. Mostly NFC,

[clang-tools-extra] r319309 - [clangd] Simplify common JSON-parsing patterns in Protocol.

2017-11-29 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 29 03:36:46 2017 New Revision: 319309 URL: http://llvm.org/viewvc/llvm-project?rev=319309=rev Log: [clangd] Simplify common JSON-parsing patterns in Protocol. Summary: This makes the parse() functions about as short as they can be given the current signature, and

[clang-tools-extra] r319478 - [clangd] New conventions for JSON-marshalling functions, centralize machinery

2017-11-30 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 30 13:32:29 2017 New Revision: 319478 URL: http://llvm.org/viewvc/llvm-project?rev=319478=rev Log: [clangd] New conventions for JSON-marshalling functions, centralize machinery Summary: - JSON<->Obj interface is now ADL functions, so they play nicely with enums

[clang-tools-extra] r319497 - [clangd] Logger implicitly adds newline

2017-11-30 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 30 15:21:34 2017 New Revision: 319497 URL: http://llvm.org/viewvc/llvm-project?rev=319497=rev Log: [clangd] Logger implicitly adds newline Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp

[clang-tools-extra] r319496 - [clangd] Log file compile commands

2017-11-30 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 30 15:16:23 2017 New Revision: 319496 URL: http://llvm.org/viewvc/llvm-project?rev=319496=rev Log: [clangd] Log file compile commands Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp URL:

[clang-tools-extra] r319157 - [clangd] Add missing (but documented!) JSONExpr typed accessors

2017-11-28 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 28 01:25:09 2017 New Revision: 319157 URL: http://llvm.org/viewvc/llvm-project?rev=319157=rev Log: [clangd] Add missing (but documented!) JSONExpr typed accessors Summary: Noticed this when I tried to port the Protocol.h parsers. And tests for the inspect API,

Re: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

2017-12-01 Thread Sam McCall via cfe-commits
ildslave/buildslave1a/clang-x86_64-linux-abi-test/ > llvm/tools/clang/tools/extra/clangd/FuzzyMatch.cpp:65:25: error: > declaration of ‘constexpr const int clang::clangd::FuzzyMatcher::MaxWord’ > outside of class is not definition [-fpermissive] > const int FuzzyMatcher::MaxWord; >

Re: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

2017-12-01 Thread Sam McCall via cfe-commits
ps4-windows10pro-fast/builds/13869 > > Can you take a look? > > Douglas Yung > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Sam > > McCall via cfe-commits > > Sent: Friday, December 01, 2017 9:08 &g

[clang-tools-extra] r319608 - [clangd] Avoid enum in bitfields, can't satisfy old GCC and new MSVC

2017-12-01 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Dec 1 20:15:55 2017 New Revision: 319608 URL: http://llvm.org/viewvc/llvm-project?rev=319608=rev Log: [clangd] Avoid enum in bitfields, can't satisfy old GCC and new MSVC Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.h Modified:

[clang-tools-extra] r319604 - [clangd] Try to appease gcc constexpr bug (58541)

2017-12-01 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Dec 1 18:28:29 2017 New Revision: 319604 URL: http://llvm.org/viewvc/llvm-project?rev=319604=rev Log: [clangd] Try to appease gcc constexpr bug (58541) Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp Modified:

[clang-tools-extra] r319606 - [clangd] Fix FuzzyMatch tests on windows, NFC

2017-12-01 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Dec 1 19:35:19 2017 New Revision: 319606 URL: http://llvm.org/viewvc/llvm-project?rev=319606=rev Log: [clangd] Fix FuzzyMatch tests on windows, NFC Without specifying the signedness of the underlying type for Action, packing it in a 1-bit field may restrict its range

Re: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

2017-12-01 Thread Sam McCall via cfe-commits
ers/llvm-clang-lld-x86_ > 64-scei-ps4-windows10pro-fast/builds/13869 > > Can you take a look? > > Douglas Yung > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Sam > > McCall via cfe-commits >

[clang-tools-extra] r319741 - [clangd] Split code-completion tests out of ClangdTests. NFC.

2017-12-04 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Dec 4 23:20:26 2017 New Revision: 319741 URL: http://llvm.org/viewvc/llvm-project?rev=319741=rev Log: [clangd] Split code-completion tests out of ClangdTests. NFC. Summary: Common parts are mostly FS related, so pulled out TestFS.h for the common stuff. Deliberately

[clang-tools-extra] r319742 - [clangd] Remove unused test param. NFC

2017-12-04 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Dec 4 23:34:35 2017 New Revision: 319742 URL: http://llvm.org/viewvc/llvm-project?rev=319742=rev Log: [clangd] Remove unused test param. NFC Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp

[clang-tools-extra] r319579 - [clangd] Define constants in the right namespace. NFC

2017-12-01 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Dec 1 12:03:19 2017 New Revision: 319579 URL: http://llvm.org/viewvc/llvm-project?rev=319579=rev Log: [clangd] Define constants in the right namespace. NFC Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp Modified:

[clang-tools-extra] r320554 - [clangd] Overload hash_value for SymbolID, fix struct/class warning

2017-12-13 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Dec 13 00:34:48 2017 New Revision: 320554 URL: http://llvm.org/viewvc/llvm-project?rev=320554=rev Log: [clangd] Overload hash_value for SymbolID, fix struct/class warning Modified: clang-tools-extra/trunk/clangd/index/Index.h Modified:

[clang-tools-extra] r320555 - [clangd] Emit ranges for clangd diagnostics, and fix off-by-one positions

2017-12-13 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Dec 13 00:48:42 2017 New Revision: 320555 URL: http://llvm.org/viewvc/llvm-project?rev=320555=rev Log: [clangd] Emit ranges for clangd diagnostics, and fix off-by-one positions Summary: - when the diagnostic has an explicit range, we prefer that - if the diagnostic

[clang-tools-extra] r320972 - [clangd] in VSCode client, filter extensions properly and only accept file: URIs

2017-12-18 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Dec 18 03:29:45 2017 New Revision: 320972 URL: http://llvm.org/viewvc/llvm-project?rev=320972=rev Log: [clangd] in VSCode client, filter extensions properly and only accept file: URIs Summary: The filtering wasn't previously working as intended - the string list is

[clang-tools-extra] r321073 - [clangd] Expose offset <-> LSP position functions, and fix bugs

2017-12-19 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Dec 19 04:23:48 2017 New Revision: 321073 URL: http://llvm.org/viewvc/llvm-project?rev=321073=rev Log: [clangd] Expose offset <-> LSP position functions, and fix bugs Summary: - Moved these functions to SourceCode.h - added unit tests - fix off by one in

[clang-tools-extra] r321086 - [clangd] Fix warnings/compiler pickiness after r321083

2017-12-19 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Dec 19 09:05:00 2017 New Revision: 321086 URL: http://llvm.org/viewvc/llvm-project?rev=321086=rev Log: [clangd] Fix warnings/compiler pickiness after r321083 Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp

[clang-tools-extra] r321087 - [clangd] Split findDefs/highlights into XRefs, from ClangdUnit. NFC

2017-12-19 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Dec 19 09:06:07 2017 New Revision: 321087 URL: http://llvm.org/viewvc/llvm-project?rev=321087=rev Log: [clangd] Split findDefs/highlights into XRefs, from ClangdUnit. NFC Going to add unit tests in the next patch. (Haha!) But seriously there's some work to do first -

[clang-tools-extra] r321161 - [clangd] Add debug printers for basic protocol types. NFC

2017-12-20 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Dec 20 02:26:53 2017 New Revision: 321161 URL: http://llvm.org/viewvc/llvm-project?rev=321161=rev Log: [clangd] Add debug printers for basic protocol types. NFC Modified: clang-tools-extra/trunk/clangd/Protocol.cpp clang-tools-extra/trunk/clangd/Protocol.h

[clang-tools-extra] r321065 - [clangd] Add unit tests for signature help. SigHelp/CodeComplete lit tests are smoke only.

2017-12-19 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Dec 19 02:29:27 2017 New Revision: 321065 URL: http://llvm.org/viewvc/llvm-project?rev=321065=rev Log: [clangd] Add unit tests for signature help. SigHelp/CodeComplete lit tests are smoke only. Modified: clang-tools-extra/trunk/test/clangd/completion.test

r318154 - [tooling] Make compile_flags.txt negative test more hermetic

2017-11-14 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 14 07:22:34 2017 New Revision: 318154 URL: http://llvm.org/viewvc/llvm-project?rev=318154=rev Log: [tooling] Make compile_flags.txt negative test more hermetic Modified: cfe/trunk/test/Tooling/fixed-database.cpp Modified:

[clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 21 08:00:53 2017 New Revision: 318774 URL: http://llvm.org/viewvc/llvm-project?rev=318774=rev Log: [clangd] Add parsing and value inspection to JSONExpr. Summary: This will replace the places where we're using YAMLParser to parse JSON now: - the new marshalling

[clang-tools-extra] r318778 - [clangd] Fix dumb && || bug from r318774

2017-11-21 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 21 08:44:16 2017 New Revision: 318778 URL: http://llvm.org/viewvc/llvm-project?rev=318778=rev Log: [clangd] Fix dumb && || bug from r318774 Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp URL:

[clang-tools-extra] r318780 - [clangd] Satisfy GCC: 'changes meaning of Error'

2017-11-21 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 21 09:02:24 2017 New Revision: 318780 URL: http://llvm.org/viewvc/llvm-project?rev=318780=rev Log: [clangd] Satisfy GCC: 'changes meaning of Error' Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp

[clang-tools-extra] r318782 - [clangd] Include the right header for std::isxdigit

2017-11-21 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 21 09:18:30 2017 New Revision: 318782 URL: http://llvm.org/viewvc/llvm-project?rev=318782=rev Log: [clangd] Include the right header for std::isxdigit Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp

[clang-tools-extra] r318791 - [clangd] Add JSON tests with invalid unicode

2017-11-21 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 21 10:40:43 2017 New Revision: 318791 URL: http://llvm.org/viewvc/llvm-project?rev=318791=rev Log: [clangd] Add JSON tests with invalid unicode Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified:

Re: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Sam McCall via cfe-commits
64-scei-ps4- > windows10pro-fast\llvm.src\tools\clang\tools\extra\unittests\clangd\JSONExprTests.cpp(134): > error C2124: divide or mod by zero > > Can you fix this so that we can get the bot green again? Thanks! > > Douglas Yung > > > -Original Message- > >

Re: [clang-tools-extra] r318774 - [clangd] Add parsing and value inspection to JSONExpr.

2017-11-21 Thread Sam McCall via cfe-commits
e page (1252) > C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4- > windows10pro-fast\llvm.src\tools\clang\tools\extra\unittests\clangd\JSONExprTests.cpp(134): > error C2124: divide or mod by zero > > Can you fix this so that we can get the bot green again? Thanks! > > Douglas Yu

[clang-tools-extra] r318798 - [clangd] avoid divide by literal zero to satisfy msvc

2017-11-21 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 21 11:37:35 2017 New Revision: 318798 URL: http://llvm.org/viewvc/llvm-project?rev=318798=rev Log: [clangd] avoid divide by literal zero to satisfy msvc Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified:

[clang-tools-extra] r318793 - [clangd] use u8 strings in tests to avoid problems on windows

2017-11-21 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 21 11:10:22 2017 New Revision: 318793 URL: http://llvm.org/viewvc/llvm-project?rev=318793=rev Log: [clangd] use u8 strings in tests to avoid problems on windows Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified:

[clang-tools-extra] r317193 - Performance tracing facility for clangd.

2017-11-02 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 2 02:21:51 2017 New Revision: 317193 URL: http://llvm.org/viewvc/llvm-project?rev=317193=rev Log: Performance tracing facility for clangd. Summary: This lets you visualize clangd's activity on different threads over time, and understand critical paths of requests

[clang-tools-extra] r317194 - Fix clangd test on platforms where get_thread_name does nothing.

2017-11-02 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 2 02:48:55 2017 New Revision: 317194 URL: http://llvm.org/viewvc/llvm-project?rev=317194=rev Log: Fix clangd test on platforms where get_thread_name does nothing. Modified: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp Modified:

[clang-tools-extra] r317553 - [clangd] fix MSVC build errors

2017-11-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 7 00:57:54 2017 New Revision: 317553 URL: http://llvm.org/viewvc/llvm-project?rev=317553=rev Log: [clangd] fix MSVC build errors Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp clang-tools-extra/trunk/clangd/JSONExpr.h Modified:

[clang-tools-extra] r317575 - [clangd] another try at fixing MSVC

2017-11-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 7 06:14:58 2017 New Revision: 317575 URL: http://llvm.org/viewvc/llvm-project?rev=317575=rev Log: [clangd] another try at fixing MSVC Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified:

[clang-tools-extra] r317580 - [clangd] don't crash on invalid JSON-RPC ID

2017-11-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 7 06:45:31 2017 New Revision: 317580 URL: http://llvm.org/viewvc/llvm-project?rev=317580=rev Log: [clangd] don't crash on invalid JSON-RPC ID Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp Modified:

[clang-tools-extra] r317670 - [clangd] Sort completion results.

2017-11-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 7 23:44:12 2017 New Revision: 317670 URL: http://llvm.org/viewvc/llvm-project?rev=317670=rev Log: [clangd] Sort completion results. Summary: This is (probably) not required by LSP, but at least one buggy client wants it. It also simplifies some tests - changed a

r317777 - [Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found.

2017-11-09 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 9 02:37:39 2017 New Revision: 31 URL: http://llvm.org/viewvc/llvm-project?rev=31=rev Log: [Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found. Summary: This is an alternative to JSONCompilationDatabase for simple projects that don't

[clang-tools-extra] r317838 - [clangd] Fix compilation database detection

2017-11-09 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Nov 9 13:45:27 2017 New Revision: 317838 URL: http://llvm.org/viewvc/llvm-project?rev=317838=rev Log: [clangd] Fix compilation database detection Modified: clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp Modified:

[clang-tools-extra] r317686 - [clangd] tolerate windows filepaths in tests

2017-11-08 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 8 04:25:00 2017 New Revision: 317686 URL: http://llvm.org/viewvc/llvm-project?rev=317686=rev Log: [clangd] tolerate windows filepaths in tests Modified: clang-tools-extra/trunk/test/clangd/diagnostics-preamble.test Modified:

[clang-tools-extra] r317692 - Relax definitions.test to accept windows file paths.

2017-11-08 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 8 05:52:21 2017 New Revision: 317692 URL: http://llvm.org/viewvc/llvm-project?rev=317692=rev Log: Relax definitions.test to accept windows file paths. Reviewers: ilya-biryukov Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D39797

[clang-tools-extra] r317673 - [clangd] loosen tests for flag-dependence revealed by r317670

2017-11-08 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Nov 8 01:15:01 2017 New Revision: 317673 URL: http://llvm.org/viewvc/llvm-project?rev=317673=rev Log: [clangd] loosen tests for flag-dependence revealed by r317670 Modified: clang-tools-extra/trunk/test/clangd/completion-snippet.test

[clang-tools-extra] r317581 - [clangd] MSVC - third time's the charm

2017-11-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 7 06:59:21 2017 New Revision: 317581 URL: http://llvm.org/viewvc/llvm-project?rev=317581=rev Log: [clangd] MSVC - third time's the charm Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified:

[clang-tools-extra] r317584 - [clangd] Fix initialize capabilities response

2017-11-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 7 07:49:35 2017 New Revision: 317584 URL: http://llvm.org/viewvc/llvm-project?rev=317584=rev Log: [clangd] Fix initialize capabilities response Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[clang-tools-extra] r317487 - [clangd] Squash namespace warning

2017-11-06 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Nov 6 07:50:35 2017 New Revision: 317487 URL: http://llvm.org/viewvc/llvm-project?rev=317487=rev Log: [clangd] Squash namespace warning Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp Modified: clang-tools-extra/trunk/clangd/JSONExpr.cpp URL:

[clang-tools-extra] r319820 - [clangd] Clean up code complete unit tests. NFC

2017-12-05 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Dec 5 12:11:29 2017 New Revision: 319820 URL: http://llvm.org/viewvc/llvm-project?rev=319820=rev Log: [clangd] Clean up code complete unit tests. NFC Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified:

[clang-tools-extra] r320148 - [clangd] Convert lit code completion tests to unit-tests. NFC

2017-12-08 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Dec 8 07:00:59 2017 New Revision: 320148 URL: http://llvm.org/viewvc/llvm-project?rev=320148=rev Log: [clangd] Convert lit code completion tests to unit-tests. NFC Summary: This improves readability of tests and error messages. Reviewers: ioeric Subscribers:

[clang-tools-extra] r319647 - [clangd] GlobalCompilationDatabase interface changes

2017-12-04 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Dec 4 02:08:45 2017 New Revision: 319647 URL: http://llvm.org/viewvc/llvm-project?rev=319647=rev Log: [clangd] GlobalCompilationDatabase interface changes Summary: - GlobalCompilationDatabase now returns a single command (that's all we use) - fallback flags are now

[clang-tools-extra] r319546 - [clangd] Remove no-op -fsyntax-only from fallback command. NFC

2017-12-01 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Dec 1 06:35:17 2017 New Revision: 319546 URL: http://llvm.org/viewvc/llvm-project?rev=319546=rev Log: [clangd] Remove no-op -fsyntax-only from fallback command. NFC This has no effect because we explicitly choose our actions. (If it had an effect, we'd want to add it

[clang-tools-extra] r319655 - [clangd] Split CodeComplete into a separate file. NFC

2017-12-04 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Dec 4 05:49:59 2017 New Revision: 319655 URL: http://llvm.org/viewvc/llvm-project?rev=319655=rev Log: [clangd] Split CodeComplete into a separate file. NFC Summary: Shared details of ClangdUnit and CodeComplete moved to a new Compiler file. Reviewers: ilya-biryukov

[clang-tools-extra] r319552 - [clangd] Filter completion results by fuzzy-matching identifiers.

2017-12-01 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Dec 1 08:35:50 2017 New Revision: 319552 URL: http://llvm.org/viewvc/llvm-project?rev=319552=rev Log: [clangd] Filter completion results by fuzzy-matching identifiers. Summary: This allows us to limit the number of results we return and still allow them to be

[clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

2017-12-01 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Dec 1 09:08:02 2017 New Revision: 319557 URL: http://llvm.org/viewvc/llvm-project?rev=319557=rev Log: [clangd] Fuzzy match scorer Summary: This will be used for rescoring code completion results based on partial identifiers. Short-term use: - we want to limit the

[clang-tools-extra] r321184 - [clangd] Switch xrefs and documenthighlight to annotated-code unit tests. NFC

2017-12-20 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Dec 20 08:06:05 2017 New Revision: 321184 URL: http://llvm.org/viewvc/llvm-project?rev=321184=rev Log: [clangd] Switch xrefs and documenthighlight to annotated-code unit tests. NFC Summary: The goal here is again to make it easier to read and write the tests. I've

[clang-tools-extra] r331029 - [clangd] Fix unicode handling, using UTF-16 where LSP requires it.

2018-04-27 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Apr 27 04:59:28 2018 New Revision: 331029 URL: http://llvm.org/viewvc/llvm-project?rev=331029=rev Log: [clangd] Fix unicode handling, using UTF-16 where LSP requires it. Summary: The Language Server Protocol unfortunately mandates that locations in files be

[clang-tools-extra] r332378 - [clangd] Extract scoring/ranking logic, and shave yaks.

2018-05-15 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue May 15 10:43:27 2018 New Revision: 332378 URL: http://llvm.org/viewvc/llvm-project?rev=332378=rev Log: [clangd] Extract scoring/ranking logic, and shave yaks. Summary: Code completion scoring was embedded in CodeComplete.cpp, which is bad: - awkward to test. The

[clang-tools-extra] r334089 - [clangd] Boost fuzzy match score by 2x (so a maximum of 2) when the query is the full identifier name.

2018-06-06 Thread Sam McCall via cfe-commits
Author: sammccall Date: Wed Jun 6 05:38:37 2018 New Revision: 334089 URL: http://llvm.org/viewvc/llvm-project?rev=334089=rev Log: [clangd] Boost fuzzy match score by 2x (so a maximum of 2) when the query is the full identifier name. Summary: Fix a couple of bugs in tests an in Quality to keep

[clang-tools-extra] r334192 - [clangd] Code completion: drop explicit injected names/operators, ignore Sema priority

2018-06-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Thu Jun 7 05:49:17 2018 New Revision: 334192 URL: http://llvm.org/viewvc/llvm-project?rev=334192=rev Log: [clangd] Code completion: drop explicit injected names/operators, ignore Sema priority Summary: Now we have most of Sema's code completion signals incorporated in

[clang-tools-extra] r334287 - [clangd] Require case-insensitive prefix match for macro completions.

2018-06-08 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Jun 8 06:32:25 2018 New Revision: 334287 URL: http://llvm.org/viewvc/llvm-project?rev=334287=rev Log: [clangd] Require case-insensitive prefix match for macro completions. Summary: Macros are terribly spammy at the moment and this offers some relief. Reviewers:

  1   2   3   4   >