[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij commandeered this revision. stuij edited reviewers, added: LukeGeeson; removed: stuij. stuij added a comment. commandeering as I've got some changes to push CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077

[PATCH] D78194: [ARM] Add __bf16 as new Bfloat16 C Type

stuij created this revision. Herald added subscribers: cfe-commits, danielkiss, arphaman, kristof.beyls. Herald added a project: clang. This patch upstreams support for a new storage only bfloat16 C type. This type is used to implement primitive support for bfloat16 data, in line with the

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added a comment. changes in the last patch: depend on bfloat IR type, and resolve some conflicts that crept in CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 ___ cfe-commits mailing list

[PATCH] D78194: [ARM] Add __bf16 as new Bfloat16 C Type

stuij abandoned this revision. stuij added a comment. This should not have been it's own revision. I wrongly trusted arc to update https://reviews.llvm.org/D76077. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78194/new/

[PATCH] D78194: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 258017. stuij added a comment. changes: depend on bfloat IR type, and resolve some conflicts that crept in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78194/new/ https://reviews.llvm.org/D78194 Files:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 258018. stuij added a comment. changes: depend on bfloat IR type, and resolve some conflicts that crept in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files:

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 258036. stuij marked 2 inline comments as done. stuij added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added a comment. @craig.topper : Yes, I thought to keep this patch confined to IR. Codegen and intrinsics patches are still to come. Comment at: llvm/docs/LangRef.rst:2896 + * - ``bfloat`` + - 16-bit brain floating-point

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 258185. stuij marked 4 inline comments as done. stuij added a comment. added some type constraints to the various getFP containter methods, adjusted getFP documentation, and simplified test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/IR/Constants.h:790 + static Constant *getFP(Type *ElementType, ArrayRef Elts); /// Return a ConstantVector with the specified constant in each element.

[PATCH] D78190: Add Bfloat IR type

stuij marked 2 inline comments as done. stuij added a comment. Marked all comments as having been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij commandeered this revision. stuij added a reviewer: LukeGeeson. stuij added a comment. Commandeered because Luke is on vacation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

This revision was automatically updated to reflect the committed changes. Closed by commit rG71ae267d1f41: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 260326. stuij added a comment. addressed comments: throughout the patch changed the string `Bfloat` to `BFloat`, expanded description of bfloat in the documentation, addressed misc comments. also added `Type *getBFloatTy()` to IRBuilder.h thanks for the

[PATCH] D78190: Add Bfloat IR type

stuij marked 8 inline comments as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBfloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/docs/LangRef.rst:2896 + * - ``bfloat`` + - 16-bit brain floating-point value (8-bit mantissa) + scanon wrote: > rjmccall wrote: > > rjmccall wrote: > > > scanon wrote: >

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 260373. stuij marked an inline comment as done. stuij added a comment. updated bfloat documentation as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 261851. stuij added a comment. I've amended this patch to conform to the general Bfloat -> BFloat convention changes requested in the dependent BFloat IR patch (D78190 ). I also folded in two other downstream patches, which

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. Hi all. Are you OK for me to commit this change? It was about a week ago since we resolved the last outstanding issues, and in general it looks like our noses have been pointing in the same direction on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 4 inline comments as done. stuij added a comment. @LukeGeeson: you're already mentioned :) See the commits tab on this review. But Simon Tatham needs a mention as well. I shall add him. Comment at: clang/docs/LanguageExtensions.rst:518 +Clang supports three

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 264560. stuij added a comment. addressing review comments and adding Simon Tatham to contributers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 264562. stuij added a comment. redo: addressing review comments and adding Simon Tatham to contributers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files:

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 264587. stuij added a comment. adhere to patch attribution conventions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td

[PATCH] D79711: [ARM][BFloat] Add poly64_t on AArch32.

stuij updated this revision to Diff 264586. stuij added a comment. adhere to attribution conventions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711 Files: clang/include/clang/Basic/TargetBuiltins.h

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij updated this revision to Diff 264588. stuij added a comment. adhere to patch attribution conventions: change author to Ties, add all the contributors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. So are we happy with the patch as it is? Anybody else wants to LGTM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 ___ cfe-commits

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. In D78190#2020701 , @stuij wrote: > In D78190#2018685 , @fpetrogalli > wrote: > > > 3. Do you need those changes in the Hexagon and x86 backend? Could they be > > submitted separately, with

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. In D78190#2018685 , @fpetrogalli wrote: > 1. Shouldn't we test also that the parser is happy with the following > expressions? Added. Thanks. > 2. Would it make sense to to split this patch into 2 separate patches? One > that

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 262122. stuij added a comment. added vector tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 Files: clang/lib/Sema/SemaOpenMP.cpp llvm/docs/BitCodeFormat.rst

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. Hi there, a gentle ping: does this look good to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 ___ cfe-commits mailing list

[PATCH] D79708: [clangd][BFloat] add NEON emitter for bfloat

stuij created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, kristof.beyls, mgorny. Herald added a project: clang. stuij added a parent revision: D76077: [ARM] Add __bf16 as new Bfloat16 C Type. stuij edited parent revisions,

[PATCH] D79710: [clangd][BFloat] add create/set/get/dup intrinsics

stuij created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, kristof.beyls. Herald added a project: clang. This patch is part of a series that adds support for the Bfloat16 extension of the Armv8.6-a architecture, as detailed

[PATCH] D79711: [ARM][BFloat] Add poly64_t on AArch32.

stuij created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. stuij added a parent revision: D76077: [ARM] Add __bf16 as new Bfloat16 C Type. stuij added a child revision: D79708: [clangd][BFloat] add NEON emitter for bfloat. The

[PATCH] D78190: Add Bfloat IR type

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8c24f33158d8: [IR][BFloat] Add BFloat IR type (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79869: [clang][BFloat] Add reinterpret cast intrinsics

stuij updated this revision to Diff 264590. stuij added a comment. adhere to attribution conventions: change author to Ties, add all the contributors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79869/new/ https://reviews.llvm.org/D79869 Files:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/docs/LanguageExtensions.rst:518 +Clang supports three half-precision (16-bit) floating point types: ``__fp16``, +``_Float16`` and ``__bf16``. These types are supported in all language modes.

[PATCH] D79869: [clangd][BFloat] Add reinterpret cast intrinsics

stuij created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, kristof.beyls. Herald added a project: clang. This patch is part of a series implementing the Bfloat16 extension of the Armv8.6-a architecture, as detailed here:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 263719. stuij added a comment. changes: - addressed asmith's comments - Bfloat doesn't depend on half cmdline options and correct code is generation for AArch32 hard and softfp CC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 2 inline comments as done. stuij added a comment. @asmith: Thanks for reviewing :) Fixed your suggestions in the coming revision. Comment at: clang/include/clang/AST/ASTContext.h:965 CanQualType HalfTy; // [OpenCL 6.1.1.1], ARM NEON + CanQualType BFloat16Ty;

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added a comment. Thanks for the feedback. We'll work on implementing a bfloat IR type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:184 + // Also include the Armv8.5 defines + // FIXME: Armv8.6 makes some extensions mandatory. Handle them here. + getTargetDefinesARMV85A(Opts, Builder);

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 251336. stuij marked 3 inline comments as done. stuij added a comment. addressing Sjoerd's comments on mandatory defines and rewording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added a comment. The failing test is not related to this ticket. It is caused by https://reviews.llvm.org/D70720/new/#1925184, Oliver Stannard is looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 251916. stuij marked 9 inline comments as done. stuij added a comment. reindenting a few lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 Files:

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added inline comments. Comment at: clang/test/Driver/aarch64-cpus.c:622 + +// The BFloat16 extension is a mandatory component of the Armv8.6-A extensions, but is permitted as an +// optional feature for any implementation of Armv8.2-A to Armv8.5-A (inclusive)

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 250630. stuij edited the summary of this revision. stuij added a comment. Updating D76062 : [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support follow changes in patch: [TableGen] Support combining AssemblerPredicates

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 252443. stuij added a comment. adding sve and bf16+sve driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added a comment. after back-and-forth with Sjoerd, added sve and bf16+sve driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 ___ cfe-commits

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1845 + +// V8.2-A BFloat intrinsics +let ArchGuard = "defined(__ARM_FEATURE_BF16_VECTOR_ARITHMETIC)" in { labrinea wrote: > v8.6-A ? Yes

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:2416 +" *\n" +" * Permission is hereby granted, free of charge, to any person " +"obtaining a copy\n" stuij wrote: >

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 265524. stuij added a comment. addressed review comments, most of all changed license header on the generated bfloat file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij marked 6 inline comments as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_bf16.td:1 +//===--- arm_fp16.td - ARM FP16 compiler interface ===// +// SjoerdMeijer wrote: > typo: fp16 - > bf16? > Here, and

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. Thanks, this one crept in during mass-renaming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87463/new/ https://reviews.llvm.org/D87463

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

stuij added a comment. I'm not sure what the procedure is to get patches into LLVM 11, but I think there's still time. Could you try to get this in there as well @c-rhodes ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87463/new/

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij marked 6 inline comments as done. stuij added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:396 +/// according to the field declaring type width. +CODEGENOPT(ForceNoAAPCSBitfieldWidth, 1, 0) + ostannard wrote: > dnsampaio wrote:

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij commandeered this revision. stuij added a reviewer: dnsampaio. stuij added a comment. Commandeering as I've made some changes to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij reopened this revision. stuij added a comment. This revision is now accepted and ready to land. Reopening as this commit made clang/test/CodeGen/volatile.c fail on Arm/AArch64 buildbot hosts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij added a comment. Hi @MaskRay. Yes, so we're seeing a warning specific to our Armcompiler toolchain, so I'm guessing that isn't relevant to OSS LLVM: `armclang: warning: '--target=x86_64-unknown-linux' is not supported.` As David Green pointed out, we have a perfectly fine workaround. But

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij added inline comments. Comment at: clang/test/Driver/fuse-ld.c:15 // RUN: FileCheck %s --check-prefix=CHECK-NO-WARN -// CHECK-NO-WARN-NOT: warning: +// CHECK-NO-WARN-NOT: warning: 'fuse-ld' MaskRay wrote: > How does this line trigger unrelated

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88566/new/ https://reviews.llvm.org/D88566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

stuij added a comment. @ostannard: pinging on behalf of @dnsampaio. The changes still apply cleanly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stuij requested review of this revision. This test broke for our toolchain as this test triggered unrelated warnings. Being more specific about not expecting fuse-ld warnings won't invalidate the

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij updated this revision to Diff 295262. stuij added a comment. slight change in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88566/new/ https://reviews.llvm.org/D88566 Files: clang/test/Driver/fuse-ld.c Index:

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 266085. stuij added a comment. add bfloat header test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 265985. stuij marked 14 inline comments as done. stuij added a comment. addressed review comments and some related general changes: - renamed IsSoftFloatABI -> IsFloatABISoftFP - split bfloat tests out of arm-mangle-16bit-float.cpp - bfloat shouldn't be

[PATCH] D79711: [ARM][BFloat] Add poly64_t on AArch32.

stuij updated this revision to Diff 265987. stuij added a comment. added testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711 Files: clang/include/clang/Basic/TargetBuiltins.h

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8111 "pointer cannot be cast to type %0">; +def err_cast_to_bfloat : Error<"cannot type-cast to __bf16">; +def err_cast_from_bfloat : Error<"cannot type-cast from __bf16">;

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 265988. stuij added a comment. replanted arg passing test from other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij requested changes to this revision. stuij added a comment. This revision now requires changes to proceed. We need testing for the backend code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 9 inline comments as done. stuij added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:74 + BFloat16Width = BFloat16Align = 16; + BFloat16Format = ::APFloat::BFloat(); + SjoerdMeijer wrote: > stuij wrote: > > SjoerdMeijer wrote: >

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added a comment. In D76077#2066520 , @SjoerdMeijer wrote: > > At the moment when going through the GCC compatibility driver (standard > > interface), we get __bf16 is not supported on this target. > > If this is the current behaviour, and

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked an inline comment as done. stuij added a comment. In D76077#2066323 , @SjoerdMeijer wrote: > Can you summarise where we are? I.e., > > - float-abi=soft doesn't work. But what is the problem? Are we not simply > passing i16s, is that not

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:80 DoubleAlign = LongLongAlign = LongDoubleAlign = SuitableAlign = 32; + BFloat16Width = BFloat16Align = 16; + BFloat16Format = ::APFloat::BFloat();

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 265753. stuij marked an inline comment as done. stuij added a comment. no explicit float-abi cmdline arg should default to softfp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij updated this revision to Diff 265764. stuij added a comment. moving 'CartesianProductWith' to more apt patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 Files:

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij added a comment. In D79710#2041418 , @LukeGeeson wrote: > Can you update the commit message in this differential as well please? Same > for the other commits :) done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1854 + def VDUP_LANE_BF : WOpInst<"vdup_lane", ".qI", "bQb", OP_DUP_LN>; + def VDUP_LANEQ_BF: WOpInst<"vdup_laneq", ".QI", "bQb", OP_DUP_LN> { +let

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij abandoned this revision. stuij added a comment. Abandoned because lack of reaction for such an unimportant issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88566/new/ https://reviews.llvm.org/D88566

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

stuij added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rG035795659b60: [ARM][bfloat] Do not coerce bfloat arguments and returns to integers (authored by stuij). Changed prior to commit: https://reviews.llvm.org/D81837?vs=271130=271775#toc Repository: rG

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82206/new/ https://reviews.llvm.org/D82206

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80928/new/ https://reviews.llvm.org/D80928 ___ cfe-commits mailing list

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

stuij added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

stuij updated this revision to Diff 271130. stuij added a comment. We only remove clang-side lowering for non-vector bfloat types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81837/new/ https://reviews.llvm.org/D81837 Files:

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

stuij added a comment. In D81451#2092997 , @pratlucas wrote: > Hi @stuij, > > The changes to the backend only handle the half (f16) type itself, not > vectors that have it as their base type. > > From what I've checked on the AAPCS, the rules for

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

stuij created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. stuij added a child revision: D81373: [WIP] Basic bfloat support on Arm. As part of moving the argument lowering handling for bfloat arguments and returns to the backend,

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

stuij updated this revision to Diff 270721. stuij added a comment. adjust arm bfloat mangle tests for these changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81837/new/ https://reviews.llvm.org/D81837 Files: clang/lib/CodeGen/ABIInfo.h

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

stuij added a comment. I would have expected changes for neon as well. Can't we now also get rid of the HasLegalHalfType argument to GetNeonType in CGBuiltin.(h|cpp). And also similar code in TargetInfo.cpp (ARMABIInfo::classifyReturnType, ARMABIInfo::isIllegalVectorType)? Repository: rG

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

stuij accepted this revision. stuij added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/ https://reviews.llvm.org/D81304 ___ cfe-commits mailing list

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij added a comment. In D80716#2073251 , @LukeGeeson wrote: > Besides from rebasing to get @pratlucas changes upstream. > > @stuij please could you confirm if you are happy with this, so I can merge Hi Luke, For the backend tests it would be good if

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

stuij added a comment. For the backend tests, I suggest using `-asm-verbose=0` with llc to only print instructions and get rid of `// kill: ..` and friends. Use `update_cc_test_checks.py` again to regenerate the testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 268614. stuij marked an inline comment as done. stuij added a comment. Resolved merge conflicts with head. Fixed minor oversight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 268616. stuij marked 7 inline comments as done. stuij added a comment. addressed remaining nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6989 + false, + getTarget().hasBFloat16Type()); llvm::Type *Ty = VTy;

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

This revision was automatically updated to reflect the committed changes. Closed by commit rGecd682bbf5e6: [ARM] Add __bf16 as new Bfloat16 C Type (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/

[PATCH] D79711: [ARM] Add poly64_t on AArch32.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e447318339a: [ARM] Add poly64_t on AArch32. (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6fcf5ca033a: [clang][BFloat] add NEON emitter for bfloat (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b137a430636: [clang][BFloat] Add create/set/get/dup intrinsics (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/

  1   2   3   >