r251633 - [mips] Add support for the new mips-mti-linux toolchain.

Author: vkalintiris Date: Thu Oct 29 10:33:53 2015 New Revision: 251633 URL: http://llvm.org/viewvc/llvm-project?rev=251633=rev Log: [mips] Add support for the new mips-mti-linux toolchain. The original commit in r249137 added the mips-mti-linux toolchain. However, the newly added tests of that

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added a comment. In http://reviews.llvm.org/D13673#271518, @EricWF wrote: > Thanks for the update, I think this should be good to go. I'll give it a > final once over tonight. Ping. http://reviews.llvm.org/D13673 ___ cfe-commits

RE: r253011 - clang/test/Driver/mips-mti-linux.c: Tweak to match DOSish paths.

Thank you for making this run on win buildbots! - Vasileios From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of NAKAMURA Takumi via cfe-commits [cfe-commits@lists.llvm.org] Sent: 13 November 2015 04:44 To: cfe-commits@lists.llvm.org

r252901 - Re-recommit: Add support for the new mips-mti-linux toolchain.

Author: vkalintiris Date: Thu Nov 12 09:26:54 2015 New Revision: 252901 URL: http://llvm.org/viewvc/llvm-project?rev=252901=rev Log: Re-recommit: Add support for the new mips-mti-linux toolchain. Last time, this caused two Windows buildbots and a single ARM buildbot to fail. I XFAIL'd the

[libcxx] r252457 - Add initial support for the MUSL C library.

Author: vkalintiris Date: Mon Nov 9 04:21:04 2015 New Revision: 252457 URL: http://llvm.org/viewvc/llvm-project?rev=252457=rev Log: Add initial support for the MUSL C library. Summary: This patch adds the LIBCXX_LIBC_IS_MUSL cmake option to allow the building of libcxx with the Musl C library.

Re: [PATCH] D13673: Add initial support for the MUSL C library.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252457: Add initial support for the MUSL C library. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D13673?vs=38788=39673#toc Repository: rL LLVM

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added a comment. Thanks for the review! Everything seems fine from the buildbots except for a single test that failed: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-debian/builds/730 The next build (731) of that buildbot was green. Is

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 38788. vkalintiris added a comment. s/__NetBSD_\)/__NetBSD__\)/ http://reviews.llvm.org/D13673 Files: CMakeLists.txt include/__config include/__config_site.in include/__locale include/support/musl/xlocale.h src/locale.cpp Index:

r251695 - Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots.

Author: vkalintiris Date: Fri Oct 30 05:35:38 2015 New Revision: 251695 URL: http://llvm.org/viewvc/llvm-project?rev=251695=rev Log: Try to run and investigate the mips-mti-linux.c test failure on ARM buildbots. This should be a NFC for every toolchain other than mips-mti-linux (where we print

r251698 - Revert "[mips] Add support for the new mips-mti-linux toolchain."

Author: vkalintiris Date: Fri Oct 30 06:28:39 2015 New Revision: 251698 URL: http://llvm.org/viewvc/llvm-project?rev=251698=rev Log: Revert "[mips] Add support for the new mips-mti-linux toolchain." This reverts commits r251633. I'll investigate the test failure off trunk in order to keep the

RE: [PATCH] D14239: mips-mti-linux TC + debug log

Hi Renato, Thanks for testing this. The /tmp/mips-mti-linux.log file contains log messages from the driver. It wasn't my intention to match anything meaningful from the mips-mti-linux.c test. I'll try to investigate what's going wrong tomorrow. Thanks, Vasileios

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 37335. vkalintiris added a comment. Address reviewers' comments. http://reviews.llvm.org/D13673 Files: CMakeLists.txt include/__config include/__config_site.in include/__locale include/support/musl/xlocale.h src/locale.cpp Index:

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added inline comments. Comment at: CMakeLists.txt:309 @@ -307,1 +308,3 @@ +config_define_if(LIBCXX_LIBC_IS_MUSL _LIBCXX_LIBC_IS_MUSL) + EricWF wrote: > Please name the macro "_LIBCPP_HAS_MUSL_LIBC" for consistency. Should I rename the corresponding

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

vkalintiris added a subscriber: vkalintiris. Comment at: include/CMakeLists.txt:9 @@ -7,2 +8,3 @@ PATTERN ".svn" EXCLUDE + PATTERN "__config_site.in" EXCLUDE ${LIBCXX_SUPPORT_HEADER_PATTERN} Kind of silly but I believe that the files used for

[PATCH] D13557: Make locale code compile on Linux without GLIBC.

vkalintiris created this revision. vkalintiris added a reviewer: mclow.lists. vkalintiris added a subscriber: cfe-commits. Most of the #ifdefs in the locale code would check for the existence of GLIBC or for operating systems other than Linux. This patch considers the case where GLIBC isn't

Re: [PATCH] D13557: Make locale code compile on Linux without GLIBC.

vkalintiris abandoned this revision. vkalintiris added a comment. In http://reviews.llvm.org/D13557#262801, @jroelofs wrote: > Unfortunately, Musl intentionally doesn't provide that sort of macro [1], so > to provide support for Musl in libc++, we need to make note of it at > configure-time

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

vkalintiris added a subscriber: vkalintiris. Comment at: cmake/Modules/HandleOutOfTreeLLVM.cmake:123-133 @@ +122,13 @@ + else(WIN32) +if(UNIX) + set(LLVM_ON_WIN32 0) + set(LLVM_ON_UNIX 1) + if(APPLE) +set(LLVM_HAVE_LINK_VERSION_SCRIPT 0) +

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris updated this revision to Diff 37850. vkalintiris marked 6 inline comments as done. vkalintiris added a comment. Sorry for the delay. Addressed reviewer comments and modifed CMake to check that LIBCXX_INSTALL_SUPPORT_HEADERS is not turned off when LIBCXX_LIBC_IS_MUSL is ON.

Re: [PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris added inline comments. Comment at: src/locale.cpp:958 @@ -957,3 +961,3 @@ return static_cast(__classic_lower_table()[static_cast(c)]); -#elif defined(__GLIBC__) || defined(__EMSCRIPTEN__) || defined(__NetBSD__) return isascii(c) ? EricWF

[PATCH] D13673: Add initial support for the MUSL C library.

vkalintiris created this revision. vkalintiris added reviewers: mclow.lists, jroelofs, EricWF. vkalintiris added a subscriber: cfe-commits. vkalintiris added a dependency: D13407: [libcxx] Capture configuration information when installing the libc++ headers. Herald added subscribers: srhines,

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

vkalintiris added a subscriber: vkalintiris. vkalintiris added a comment. In http://reviews.llvm.org/D11815#235394, @ahatanak wrote: > The cc1 option "-mstackrealign" now means "force stack realignment" rather > than "allow stack realignment" and causes function attribute "stackrealign" > to

[PATCH] D13339: Allow a ToolChain to compute the path of a compiler-rt's component.

vkalintiris created this revision. vkalintiris added reviewers: atanasyan, rsmith. vkalintiris added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. This patch moves getCompilerRT() from the clang::driver::tools namespace to the ToolChain class. This is

[PATCH] D13340: Add support for the new mips-mti-linux toolchain.

vkalintiris created this revision. vkalintiris added reviewers: atanasyan, dsanders, rsmith. vkalintiris added a subscriber: cfe-commits. Herald added subscribers: dschuff, srhines, danalbert, tberghammer, jfb. This new toolchain uses primarily LLVM-based tools, eg. compiler-rt, lld, libcxx, etc.

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

vkalintiris added inline comments. Comment at: include/clang/Driver/ToolChain.h:147 @@ -145,1 +146,3 @@ + const Multilib () const { return SelectedMultilib; } + atanasyan wrote: > Do you need public access to this member function? I discarded this member

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

vkalintiris updated this revision to Diff 36257. vkalintiris marked 8 inline comments as done. vkalintiris added a comment. Thanks. The review comments are addressed in this update. http://reviews.llvm.org/D13340 Files: lib/Driver/Driver.cpp lib/Driver/ToolChain.cpp

r249030 - Allow a ToolChain to compute the path of a compiler-rt's component.

Author: vkalintiris Date: Thu Oct 1 11:54:58 2015 New Revision: 249030 URL: http://llvm.org/viewvc/llvm-project?rev=249030=rev Log: Allow a ToolChain to compute the path of a compiler-rt's component. Summary: This patch moves getCompilerRT() from the clang::driver::tools namespace to the

r249137 - Add support for the new mips-mti-linux toolchain.

Author: vkalintiris Date: Fri Oct 2 09:38:23 2015 New Revision: 249137 URL: http://llvm.org/viewvc/llvm-project?rev=249137=rev Log: Add support for the new mips-mti-linux toolchain. Summary: This new toolchain uses primarily LLVM-based tools, eg. compiler-rt, lld, libcxx, etc. Because of this,

Re: [PATCH] D13340: Add support for the new mips-mti-linux toolchain.

This revision was automatically updated to reflect the committed changes. vkalintiris marked an inline comment as done. Closed by commit rL249137: Add support for the new mips-mti-linux toolchain. (authored by vkalintiris). Changed prior to commit:

r249141 - Revert "Add support for the new mips-mti-linux toolchain."

Author: vkalintiris Date: Fri Oct 2 10:00:55 2015 New Revision: 249141 URL: http://llvm.org/viewvc/llvm-project?rev=249141=rev Log: Revert "Add support for the new mips-mti-linux toolchain." This reverts commit r249137 because it broke the Windows buildbots and a Linux buildbot for LLD.

RE: r249141 - Revert "Add support for the new mips-mti-linux toolchain."

: r249141 - Revert "Add support for the new mips-mti-linux toolchain." The regular expression should match match clang.exe on Windows. 2015-10-02 18:00 GMT+03:00 Vasileios Kalintiris via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>: Author: vkalin

r249294 - Re-commit "Add support for the new mips-mti-linux toolchain."

Author: vkalintiris Date: Mon Oct 5 04:12:36 2015 New Revision: 249294 URL: http://llvm.org/viewvc/llvm-project?rev=249294=rev Log: Re-commit "Add support for the new mips-mti-linux toolchain." r249137 added support for the new mips-mti-linux toolchain. However, the new tests of that commit,

r249296 - Fix test failure on Windows buildbots for the mips-mti-linux toolchain.

Author: vkalintiris Date: Mon Oct 5 04:55:50 2015 New Revision: 249296 URL: http://llvm.org/viewvc/llvm-project?rev=249296=rev Log: Fix test failure on Windows buildbots for the mips-mti-linux toolchain. Try to make the Windows buildbots happy by fixing the regexes that match the paths to CRT

r249298 - Remove support for the mips-mti-linux toolchain.

Author: vkalintiris Date: Mon Oct 5 05:34:46 2015 New Revision: 249298 URL: http://llvm.org/viewvc/llvm-project?rev=249298=rev Log: Remove support for the mips-mti-linux toolchain. There are two remaining buildbot failures that we'll have to investigate before submitting this again. Removed:

[PATCH] D15145: Add expressions to ignore vim swap files in .gitinore.

vkalintiris created this revision. vkalintiris added a subscriber: cfe-commits. http://reviews.llvm.org/D15145 Files: .gitignore Index: .gitignore === --- .gitignore +++ .gitignore @@ -52,3 +52,7 @@ # PyBuilder target/ + +#

Re: [PATCH] D15130: Fix the clang driver when "-nostdlib" is present

vkalintiris accepted this revision. vkalintiris added a comment. This revision is now accepted and ready to land. LGTM. Thank you for working on this. http://reviews.llvm.org/D15130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D14926: Use libcxx's default rune table with the Musl C library.

vkalintiris created this revision. vkalintiris added reviewers: mclow.lists, jroelofs, EricWF, dalias. vkalintiris added a subscriber: cfe-commits. Herald added subscribers: srhines, danalbert, tberghammer. Also, there are no exported character type tables from Musl so we have to Fallback to the

Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

vkalintiris added a comment. @dalias: Can you take a correctness-look at this patch? Comment at: include/__locale:411-415 @@ -410,7 +410,3 @@ #else -#if defined(_LIBCPP_HAS_MUSL_LIBC) -typedef unsigned short mask; -#else typedef unsigned long mask; -#endif static

[libcxx] r253972 - Use libcxx's default rune table with the Musl C library.

Author: vkalintiris Date: Tue Nov 24 04:24:54 2015 New Revision: 253972 URL: http://llvm.org/viewvc/llvm-project?rev=253972=rev Log: Use libcxx's default rune table with the Musl C library. Summary: Also, there are no exported character type tables from Musl so we have to Fallback to the

Re: [PATCH] D14926: Use libcxx's default rune table with the Musl C library.

This revision was automatically updated to reflect the committed changes. Closed by commit rL253972: Use libcxx's default rune table with the Musl C library. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D14926?vs=40926=41016#toc Repository: rL LLVM

RE: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

...@lists.llvm.org] on behalf of Vasileios Kalintiris via cfe-commits [cfe-commits@lists.llvm.org] Sent: 09 February 2016 17:00 To: cfe-commits@lists.llvm.org Subject: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic. Author: vkalintiris Date: Tue Feb 9 11:00:38

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260235: Introduce a cmake module to figure out whether we need to link with libatomic. (authored by vkalintiris). Changed prior to commit: http://reviews.llvm.org/D16613?vs=46286=47329#toc Repository:

[libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

Author: vkalintiris Date: Tue Feb 9 11:00:38 2016 New Revision: 260235 URL: http://llvm.org/viewvc/llvm-project?rev=260235=rev Log: Introduce a cmake module to figure out whether we need to link with libatomic. Summary: This fixes the tests under std/atomics for 32-bit MIPS CPUs where the

RE: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

with this. Thanks, Vasileios From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Vasileios Kalintiris via cfe-commits [cfe-commits@lists.llvm.org] Sent: 11 February 2016 12:43 To: cfe-commits@lists.llvm.org Subject: [libcxx] r260515 - Re

[libcxx] r260323 - Revert "Introduce a cmake module to figure out whether we need to link with libatomic."

Author: vkalintiris Date: Tue Feb 9 17:38:28 2016 New Revision: 260323 URL: http://llvm.org/viewvc/llvm-project?rev=260323=rev Log: Revert "Introduce a cmake module to figure out whether we need to link with libatomic." This reverts commit r260235. It breaks LLVM's bootstrap when building with

RE: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Vasileios Kalintiris via cfe-commits [cfe-commits@lists.llvm.org] Sent: 09 February 2016 17:00 To: cfe-commits@lists.llvm.org Subject: [libcxx] r260235 - Introduce a cmake module to figure out whether we

[libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

Author: vkalintiris Date: Thu Feb 11 06:43:04 2016 New Revision: 260515 URL: http://llvm.org/viewvc/llvm-project?rev=260515=rev Log: Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic." This re-applies commit r260235. However, this time we add

RE: [libcxx] r260515 - Re-commit "Introduce a cmake module to figure out whether we need to link with libatomic."

hu, Feb 11, 2016 at 5:43 AM, Vasileios Kalintiris via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote: Author: vkalintiris Date: Thu Feb 11 06:43:04 2016 New Revision: 260515 URL: http://llvm.org/viewvc/llvm-project?rev=260515=rev Log: Re-commit &qu

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

vkalintiris added a comment. Sorry for the early pings. In case it's not clear from Daniel's comment, without this patch libc++ will be broken for 32-bit MIPS CPUs. The relevant bug report has been nominated as a release block but we'd like to have it committed before the next RC.

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

vkalintiris added a comment. Is this okay to commit with the updated changes? http://reviews.llvm.org/D16613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16613: Use LLVM's CheckAtomic cmake module to figure out whether we need to link with libatomic.

vkalintiris updated this revision to Diff 46272. vkalintiris added a comment. Don't use LLVM's CheckAtomic cmake module. Instead, use a libcxx-specific one that allows checking for 64-bit atomics too. http://reviews.llvm.org/D16613 Files: cmake/Modules/CheckLibcxxAtomic.cmake

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

vkalintiris updated this revision to Diff 46286. vkalintiris added a comment. Check for atomcis on uintmax_t/uintptr_t instead of long long int. http://reviews.llvm.org/D16613 Files: cmake/Modules/CheckLibcxxAtomic.cmake cmake/config-ix.cmake lib/CMakeLists.txt test/CMakeLists.txt

[PATCH] D16613: Use LLVM's CheckAtomic cmake module to figure out whether we need to link with libatomic.

vkalintiris created this revision. vkalintiris added reviewers: dsanders, mclow.lists, EricWF, jroelofs. vkalintiris added a subscriber: cfe-commits. This fixes the tests under std/atomics for 32-bit MIPS CPUs where the 8-byte atomic operations call into the libatomic library.

[libcxx] r260961 - Issue a warning instead of fatal errors when checks for libatomic fail.

Author: vkalintiris Date: Tue Feb 16 08:15:27 2016 New Revision: 260961 URL: http://llvm.org/viewvc/llvm-project?rev=260961=rev Log: Issue a warning instead of fatal errors when checks for libatomic fail. This should fix PR26631, PR26622 and has the nice property that the addition of the

RE: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

_ From: cfe-commits [cfe-commits-boun...@lists.llvm.org<mailto:cfe-commits-boun...@lists.llvm.org>] on behalf of Vasileios Kalintiris via cfe-commits [cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>] Sent: 09 February 2016 17:00 To: cfe-commits@lists

RE: [libcxx] r260235 - Introduce a cmake module to figure out whether we need to link with libatomic.

eaders directly for the check, while still using all the custom flags and tools that I pass on the command line, then I should be able to remove the explicit setting of "LIBCXX_HAVE_CXX_ATOMICS_WITHOUT_LIB" in the future. On 2/16/2016 2:09 PM, Vasileios Kalintiris via cfe-commits wrot

Re: [PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

vkalintiris accepted this revision. vkalintiris added a comment. This revision is now accepted and ready to land. LGTM. However, I'm curious to learn which case triggered this behaviour. Repository: rL LLVM http://reviews.llvm.org/D16139 ___

Re: [PATCH] D18761: [mips] Enable IAS by default for 32-bit MIPS targets (O32).

vkalintiris accepted this revision. vkalintiris added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D18761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r264035 - Fix warning about extra semicolon. NFC.

Author: vkalintiris Date: Tue Mar 22 05:41:20 2016 New Revision: 264035 URL: http://llvm.org/viewvc/llvm-project?rev=264035=rev Log: Fix warning about extra semicolon. NFC. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp URL:

r269651 - [mips] Add test for the dynamic linker when using the mips64el-fedora-linux triple.

Author: vkalintiris Date: Mon May 16 06:53:51 2016 New Revision: 269651 URL: http://llvm.org/viewvc/llvm-project?rev=269651=rev Log: [mips] Add test for the dynamic linker when using the mips64el-fedora-linux triple. We should use the musl linker only when there's no environment specified and

RE: r269411 - [mips] Consult triple's vendor field before using musl's interpreter.

. Hi, This change makes sense but it needs a test case. > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Vasileios Kalintiris via cfe-commits > Sent: 13 May 2016 13:13 > To: cfe-commits@lists.llvm.org > Subject: r26941

r269411 - [mips] Consult triple's vendor field before using musl's interpreter.

Author: vkalintiris Date: Fri May 13 07:13:13 2016 New Revision: 269411 URL: http://llvm.org/viewvc/llvm-project?rev=269411=rev Log: [mips] Consult triple's vendor field before using musl's interpreter. This should affect only the mips-mti-linux toolchain. Modified:

r269412 - Simplify getLinuxDynamicLinker() by using a common variable for the triple. NFC.

Author: vkalintiris Date: Fri May 13 07:34:14 2016 New Revision: 269412 URL: http://llvm.org/viewvc/llvm-project?rev=269412=rev Log: Simplify getLinuxDynamicLinker() by using a common variable for the triple. NFC. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified:

RE: r275095 - [NFC] Reorder fields of VersionTuple to reduce size

Hi Erik, would you mind reverting this temporarily? It broke our recursive builds buildbot because the re-ordering of VersionTuple's bitfields generates an i128 which our MIPS backend erroneously accepts for the o32 ABI. - V. Kalintiris From:

RE: r275095 - [NFC] Reorder fields of VersionTuple to reduce size

Kalintiris via cfe-commits [cfe-commits@lists.llvm.org] Sent: 06 September 2016 10:12 To: Erik Pilkington; cfe-commits@lists.llvm.org Subject: RE: r275095 - [NFC] Reorder fields of VersionTuple to reduce size Hi Erik, would you mind reverting this temporarily? It broke our recursive builds buildbot

Re: [PATCH] D24674: [mips] MSA intrinsics header file

vkalintiris requested changes to this revision. vkalintiris added a comment. This revision now requires changes to proceed. @sdardis: can you update the review request before committing this because I don't think that test/CodeGen/builtins-mips-msa.c has ever been properly reviewed before.

Re: [PATCH] D24674: [mips] MSA intrinsics header file

vkalintiris accepted this revision. vkalintiris added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D24674#547589, @vkalintiris wrote: > @sdardis: can you update the review request before committing this because I > don't think that

Re: [PATCH] D24448: [atomics] New warning -Watomic-libcall when atomic operation expands to a library call

vkalintiris added a subscriber: vkalintiris. vkalintiris added a comment. I removed myself from the reviewers because I'm not quite familiar with this area. @joerg I added you as reviewer because you've already commented, feel free to undo my change if you don't have time to review this.

Re: [PATCH] D24674: [mips] MSA intrinsics header file

vkalintiris accepted this revision. vkalintiris added a subscriber: mpf. vkalintiris added a comment. This revision is now accepted and ready to land. LGTM with one comment/question inline. Comment at: test/CodeGen/builtins-mips-msa.c:8 @@ -13,4 +7,3 @@ + typedef __fp16 v8f16

[PATCH] D25017: [mips][msa] Range check MSA intrinsics with immediates

vkalintiris accepted this revision. vkalintiris added a comment. This revision is now accepted and ready to land. LGTM. See inline comments for a few small changes. The only issue I've found with test/CodeGen/builtins-mips-msa-error.c is that GCC checks strictly the signedness of the arguments

[PATCH] D25017: [mips][msa] Range check MSA intrinsics with immediates

vkalintiris added inline comments. Comment at: lib/Sema/SemaChecking.cpp:1633-1637 + if (!m) +return SemaBuiltinConstantArgRange(TheCall, i, l, u); + +return SemaBuiltinConstantArgRange(TheCall, i, l, u) || + SemaBuiltinConstantArgMultiple(TheCall, i, m);