[PATCH] D29676: Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r294359. Repository: rL LLVM https://reviews.llvm.org/D29676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29676: Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules

v.g.vassilev created this revision. Enable the useful -dump-deserialized-decls and -error-on-deserialized-decl flags for modules builds, too. Repository: rL LLVM https://reviews.llvm.org/D29676 Files: lib/Frontend/FrontendAction.cpp Index: lib/Frontend/FrontendAction.cpp

[PATCH] D27604: [Driver] Add compiler option to generate a reproducer

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. My questions were answered. LGTM! https://reviews.llvm.org/D27604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25604: Add support for Mageia Linux

v.g.vassilev abandoned this revision. v.g.vassilev added a comment. Thanks for following this up. I will close it. https://reviews.llvm.org/D25604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev created this revision. Currently, we load all template specialization if we have more than one module attached and we touch anything around the template definition. This patch registers the template specializations as a lazily-loadable entities. This reduces the amount of

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev created this revision. Repository: rL LLVM https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp lib/Serialization/ASTReader.cpp test/SemaCXX/warn-unused-filescoped.cpp Index: test/SemaCXX/warn-unused-filescoped.cpp

[PATCH] D28832: Improve redefinition errors pointing to the same header.

v.g.vassilev added a comment. This looks good to me. https://reviews.llvm.org/D28832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27604: [Driver] Add compiler option to generate a reproducer

v.g.vassilev added a comment. Thanks for working on this, Bruno! This would be a useful feature to us, too. I am wondering if there is clearer name than `-gen-reproducer`. IIUC, the goal is to extract all environment (system) dependent pieces, copying them to a folder where the compiler can

[PATCH] D27180: Testbed and skeleton of a new expression parser

v.g.vassilev added a comment. Could you move the Build* functions in a utility class/namespace. I need something very similar for my ongoing work on the libInterpreter patch and I'd like to reuse that part of the patch. Repository: rL LLVM https://reviews.llvm.org/D27180

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r291753. https://reviews.llvm.org/D28399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev added a comment. @yaron.keren, it seems that http://llvm.org/pr30994 concerns friend function declarations. My current patch focuses on friend class templates. Perhaps we should open another review item for a fix of http://llvm.org/pr30994. https://reviews.llvm.org/D28399

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 83936. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Address comments. https://reviews.llvm.org/D28399 Files: include/clang/AST/DeclTemplate.h

[PATCH] D27180: Testbed and skeleton of a new expression parser

v.g.vassilev added a comment. Thanks for working on this Sean! Since long time we are planning to propose a patch moving some parts of cling (eg. libInterpreter) mainline. Now I should have a little more time to do this and it'd be great if we can share some code between cling and lldb. This

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev added a comment. @kimgr, here is the discussion about the change in r283207 https://reviews.llvm.org/D16989 Repository: rL LLVM https://reviews.llvm.org/D28399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28306: Remove fixme, use ASTContext::getCanonicalTemplateSpecializationType

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D28306 Files: lib/Sema/SemaTemplate.cpp Index:

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Fixes a crash in modules where the template class decl becomes the most recent decl in the redeclaration chain

[PATCH] D28306: Remove fixme, use ASTContext::getCanonicalTemplateSpecializationType

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r291552. Repository: rL LLVM https://reviews.llvm.org/D28306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:147 +// different algorithm). +// TODO: In very big clones even multiple variables can be unintended, +// so replacing this number with a percentage could better

[PATCH] D31190: Publish RAIIObjectsForParser.h for external usage

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r298606. Repository: rL LLVM https://reviews.llvm.org/D31190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I am very happy to see this converging! Thanks for the work and perseverance! LGTM. https://reviews.llvm.org/D23418 ___ cfe-commits

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev created this revision. Consider: ` struct MyClass { void f() {} } MyClass::f(){} // expected error redefinition of f. ` The routine fails to remove the lookup entry is registered in the semantic decl context and not in the primary decl context of the lexical decl context where

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev updated this revision to Diff 92481. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. U https://reviews.llvm.org/D31187 Files: lib/AST/DeclBase.cpp Index: lib/AST/DeclBase.cpp

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

v.g.vassilev created this revision. Herald added a subscriber: mgorny. This is very useful for projects which embed LLVM in their codebases. Repository: rL LLVM https://reviews.llvm.org/D31702 Files: cmake/modules/HandleLLVMOptions.cmake Index: cmake/modules/HandleLLVMOptions.cmake

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

v.g.vassilev added a comment. Could you also add the testcase where the friend declaration has some attributes? Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

v.g.vassilev updated this revision to Diff 94180. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Ah good point. Thanks! https://reviews.llvm.org/D31702 Files: cmake/modules/HandleLLVMOptions.cmake Index: cmake/modules/HandleLLVMOptions.cmake

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @arphaman, it seems they are marked as static and this seemed like a bug to @rsmith. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @chapuni, the LLVM warnings should be fixed in r299947. @mclow.lists, sorry for not giving heads up :( I am working on the false positive that you reported. https://reviews.llvm.org/D29877 ___ cfe-commits mailing

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @mclow.lists, hm... it seems that I cannot reproduce it. It'd really help if you could paste a standalone reproducer. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. Reverted in r299956, due to failures like: template static int __test(...); template auto v = __test<_Tp>(0); https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94352. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Improve comment. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index:

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94293. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Iterate over the specs. Diagnose unused variable templates. https://reviews.llvm.org/D29877 Files: include/clang/Sema/Sema.h lib/Sema/Sema.cpp

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94294. v.g.vassilev added a comment. Attach the right diff. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index: test/SemaCXX/warn-unused-filescoped.cpp

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:1496 return false; + // 'static operator' functions are defined in headers; don't warn. + if (FD->isOverloadedOperator() && rsmith wrote: > Why? Defining a static operator

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev closed this revision. v.g.vassilev marked 5 inline comments as done. v.g.vassilev added a comment. Landed in r299930. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

v.g.vassilev added a comment. How do we proceed with this. Shall we close it? https://reviews.llvm.org/D22638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. Thanks for pinging us. Yeah, I knew them but I was hesitant whether I should fix them or they should be fixed by the code owners. Shall I commit the fixes? https://reviews.llvm.org/D29877 ___ cfe-commits mailing list

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

v.g.vassilev added a comment. LGTM! https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28832: Improve redefinition errors pointing to the same header.

v.g.vassilev added a comment. Here is an example that we recently had where we would be very happy to see better diagnostics: MessageTypes.h: #ifndef ROOT_MessageTypes #define ROOT_MessageTypes enum EMessageTypes { kROOTD_OPEN = 2004, //filename follows +

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r300100. https://reviews.llvm.org/D31702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev added a comment. ping... https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev planned changes to this revision. v.g.vassilev added a comment. We agreed to implement a special switch for this, eg. `-Wunused-template` https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev added inline comments. Comment at: docs/doxygen.cfg.in:158 +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang-c We should be stripping `@abs_srcdir@/../include` because in reality the

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev added a comment. Landed in r300313. https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev added a comment. Landed in r300825. Maybe we should do something like that for LLVM documentation, too. https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28832: Improve redefinition errors pointing to the same header.

v.g.vassilev added a comment. @bruno, ok, sounds good. https://reviews.llvm.org/D28832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32119: Emit warning when umbrella directory does not exists

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. LGTM modulo the comments. Comment at: test/Driver/m_and_mm.c:7 +// RUN: not grep "warning" %t +#warning "This warning shouldn't shop up with -M and -MM" Typo. https://reviews.llvm.org/D32341

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. Could you add a test case? https://reviews.llvm.org/D32341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @rsmith ping... https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev added a comment. We were planning adding some extra unittests, too... https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 90360. v.g.vassilev added a comment. Rebase + ping. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index: test/SemaCXX/warn-unused-filescoped.cpp

[PATCH] D26030: Add shebang.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r296781. Repository: rL LLVM https://reviews.llvm.org/D26030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev added a comment. @yamaguchi, I'd support Akira's comment. Could you place the minimal test example in the suggested file? https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 94350. v.g.vassilev added a comment. Found out which is the right place to avoid the linkage computation issues. https://reviews.llvm.org/D29877 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/SemaCXX/warn-unused-filescoped.cpp Index:

[PATCH] D31190: Publish RAIIObjectsForParser.h for external usage

v.g.vassilev created this revision. In the context of cling, we need to recover the parser from errors. This patch is essential for us and we would like to move it from our fork to clang proper. Repository: rL LLVM https://reviews.llvm.org/D31190 Files:

[PATCH] D31187: Fix removal of out-of-line definitions.

v.g.vassilev added a comment. Not sure, this code is used by external tools. Maybe I could craft an example but it would be very complex, bringing half of the third party tool codebase... https://reviews.llvm.org/D31187 ___ cfe-commits mailing

[PATCH] D32119: Emit warning when umbrella directory does not exists

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r300594. https://reviews.llvm.org/D32119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev added inline comments. Comment at: lib/CodeGen/CGCXXABI.cpp:43 if (RD->hasNonTrivialDestructor()) return false; rjmccall wrote: > Does canPassInRegisters() not subsume all of these earlier checks? No, if I remove them here I get a lot of

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 105776. v.g.vassilev added a comment. Remove accidentally added change in SemaDecl.cpp https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/CodeGen/CGCXXABI.cpp

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 105775. v.g.vassilev added a comment. Compute only once if there is a non-deleted move or copy constructor and store them in the `DefinitionData` of the `CXXRecordDecl`. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h

[PATCH] D33275: Keep into account if files were virtual.

v.g.vassilev added a comment. @rsmith suggested to move this one interface layer down, that is `ContentCache::getBuffer`. Moving it there might fix more issues. I will try to improve it and land the new version if that's not urgent for you. https://reviews.llvm.org/D33275

[PATCH] D35527: [CMake] Move CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) into clang/Config/config.h.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D35527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. In https://reviews.llvm.org/D3#812418, @rjmccall wrote: > In https://reviews.llvm.org/D3#795175, @v.g.vassilev wrote: > > > @rjmccall, thanks for the prompt and thorough reply. > > > > In https://reviews.llvm.org/D3#793311, @rjmccall wrote: > > > > >

[PATCH] D35536: Don't set TUScope to null when generating a module in incremental processing mode.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I think we can rely on a post-commit review here. LGTM! https://reviews.llvm.org/D35536 ___ cfe-commits mailing list

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. In https://reviews.llvm.org/D3#818030, @rjmccall wrote: > In https://reviews.llvm.org/D3#812836, @v.g.vassilev wrote: > > > In https://reviews.llvm.org/D3#812418, @rjmccall wrote: > > > > > In https://reviews.llvm.org/D3#795175, @v.g.vassilev wrote:

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 108505. v.g.vassilev added a comment. Move the checks in Sema. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/CodeGen/CGCXXABI.cpp lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D34891: Replace assert(0) with llvm_unreachable.

v.g.vassilev created this revision. Repository: rL LLVM https://reviews.llvm.org/D34891 Files: include/clang/AST/Redeclarable.h lib/AST/ExprConstant.cpp lib/Basic/SourceManager.cpp lib/Lex/PreprocessingRecord.cpp lib/Sema/SemaType.cpp lib/Serialization/ASTReader.cpp

[PATCH] D34912: Handle cases where the value is too large to fit into the underlying type.

v.g.vassilev created this revision. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34912 Files: lib/AST/TemplateBase.cpp Index: lib/AST/TemplateBase.cpp === --- lib/AST/TemplateBase.cpp +++

[PATCH] D34891: Replace assert(0) with llvm_unreachable.

v.g.vassilev added a comment. Sure, I can do this, as long as this semantic change is ok. Repository: rL LLVM https://reviews.llvm.org/D34891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34912: Handle cases where the value is too large to fit into the underlying type.

v.g.vassilev planned changes to this revision. v.g.vassilev added a comment. Waiting for @karies for a test case. Repository: rL LLVM https://reviews.llvm.org/D34912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34891: Replace assert(0) with llvm_unreachable.

v.g.vassilev added a comment. Ok, thanks! I was hesitant for the changes in libclang, because of the return statements. Repository: rL LLVM https://reviews.llvm.org/D34891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34925: [Bash-completion] Fixed a bug that ~ doesn't expanded to $HOME

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. That fixes my issue. LGTM. https://reviews.llvm.org/D34925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34924: [Bash-autocompletion] Add support for older bash version.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. It looks like this works with bash 3.2. I've tested this on mac and it works well. https://reviews.llvm.org/D34924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34510: Teach clang how to merge typedef over anonymous structs in C mode.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r306964. Repository: rL LLVM https://reviews.llvm.org/D34510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev created this revision. Patch by Bernd Schmidt! Fixes PR19668 and PR23034. Repository: rL LLVM https://reviews.llvm.org/D35056 Files: lib/CodeGen/CGCXXABI.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/uncopyable-args.cpp Index: test/CodeGenCXX/uncopyable-args.cpp

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a subscriber: karies. v.g.vassilev added a comment. @rjmccall, thanks for the prompt and thorough reply. In https://reviews.llvm.org/D3#793311, @rjmccall wrote: > Okay. In that case, I see two problems, one major and one potentially major. This is a very accurate

[PATCH] D34510: Teach clang how to merge typedef over anonymous structs in C mode.

v.g.vassilev added a comment. @bruno ping... Repository: rL LLVM https://reviews.llvm.org/D34510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. ping... Repository: rL LLVM https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34984: Store token literal data in PCH. Avoids disk read on PreProc expansion.

v.g.vassilev created this revision. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34984 Files: include/clang/Serialization/ASTReader.h lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp

[PATCH] D34912: Handle cases where the value is too large to fit into the underlying type.

v.g.vassilev updated this revision to Diff 105172. v.g.vassilev added a comment. Add test case. https://reviews.llvm.org/D34912 Files: lib/AST/TemplateBase.cpp test/SemaTemplate/temp_arg_nontype.cpp Index: test/SemaTemplate/temp_arg_nontype.cpp

[PATCH] D34985: Do not read the file to determine its name.

v.g.vassilev created this revision. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34985 Files: lib/Basic/SourceManager.cpp Index: lib/Basic/SourceManager.cpp === --- lib/Basic/SourceManager.cpp +++

[PATCH] D34985: Do not read the file to determine its name.

v.g.vassilev added a comment. The test case could be shared from PR33688: echo 'void* func(char* p) __attribute__((annotate("blah"))); void* func(char* p){return p;}' > HEADER.h clang++ -std=c++14 -x c++-header -o HEADER.h.pch HEADER.h chmod a-r HEADER.h echo 'char i;

[PATCH] D34984: Store token literal data in PCH. Avoids disk read on PreProc expansion.

v.g.vassilev added a subscriber: karies. v.g.vassilev added a comment. What would be the best way to test this. Shall we put: echo '#define LITERAL 42' > HEADER.h clang++ -std=c++14 -x c++-header -o HEADER.h.pch HEADER.h chmod a-r HEADER.h echo 'void f(int); void g() { f(12); }'

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. We use them as separate translation units due to the fact that we need to survive multiple calls to `HandleEndOfTranslationUnit`. This 'finalizes' the module, and we cannot write to it anymore. Even though we could write to it (this was the case when we were using

[PATCH] D34761: [Bash-autocompletion] Invoke clang where user called

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34927: [Bash-autocompletion] Fix a bug that -foo=bar doesn't handled properly

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

v.g.vassilev added a comment. Yaron, I can take care of this. Thanks for asking. Raphael and I are working together. https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. I think you will see the issue if you add a negative test case, too. I.e. as Raphael said in `-MD` and `-MMD` mode we should be able to see warnings. https://reviews.llvm.org/D32341 ___ cfe-commits mailing list

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r301563. https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r301569. https://reviews.llvm.org/D32342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25113: [Sema] Don't display an invalid redefinition error when dealing with a redefinition of a function whose previous definition was typo-corrected

v.g.vassilev added a comment. LGTM! Repository: rL LLVM https://reviews.llvm.org/D25113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev updated this revision to Diff 97098. v.g.vassilev added a comment. This revision is now accepted and ready to land. Implement a special diagnostic switch for the warning. https://reviews.llvm.org/D29877 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev added a comment. @rsmith, @mclow.lists, @arphaman, I am planning to reland that soon. Let me know if you have any objections. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

v.g.vassilev added a comment. In general, I think we should support such use-cases. It seems cleaner to me if we provide some sort of callbacks where the users can specify their custom false positive filters. I've discussed this in brief with Raphael and we were planning to write this up.

[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

v.g.vassilev added a comment. LGTM, modulo the comment. Comment at: lib/Sema/SemaInit.cpp:892 + SpellingLoc = SemaRef.getSourceManager().getSpellingLoc(SpellingLoc); + if (!(SpellingLoc.isValid() && +

[PATCH] D31495: Fix a bug that -isysroot is completely ignored on Unix

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D31495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

v.g.vassilev added a comment. @teemperor, is this ok with you? https://reviews.llvm.org/D32341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   7   >