[PATCH] D56112: [clang-offload-bundler] Added install component

vzakhari added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56112/new/ https://reviews.llvm.org/D56112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56112: [clang-offload-bundler] Added install component

vzakhari created this revision. vzakhari added a reviewer: chandlerc. Herald added subscribers: cfe-commits, mgorny. Allow selective install of clang-offload-bundler Repository: rC Clang https://reviews.llvm.org/D56112 Files: CMakeLists.txt Index: CMakeLists.txt

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

vzakhari added inline comments. Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ - DESTINATION

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

vzakhari added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:176 install( - DIRECTORY ${output_dir} + FILES ${install_files} DESTINATION ${header_install_dir} vzakhari wrote: > This is going to flatten the headers' install directory

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

vzakhari added a comment. OK, this should work while clang_generate_header() is used for plain files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ https://reviews.llvm.org/D61220 ___

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

vzakhari added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:173 set(header_install_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}) Please add "/include" at the end. Comment at: clang/lib/Headers/CMakeLists.txt:176

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365666: [clang] Preserve names of addrspacecasted values. (authored by vzakhari, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari updated this revision to Diff 208564. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenCUDA/builtins-amdgcn.cu clang/test/CodeGenOpenCL/address-spaces-conversions.cl

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. I changed the tests to use FileCheck variables whenever possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari created this revision. vzakhari added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jfb, jvesely. Herald added a project: clang. Attach ".ascast" suffix to a value name when generating addrspacecast for it. This improves IR readability, e.g. for alloca variables, since

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. In D63846#1574302 , @rjmccall wrote: > I don't know what I think about widespread use of `-fno-discard-value-names` > for now; please continue to use FileCheck variables, and we can make a > holistic decision about that flag

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari marked an inline comment as done. vzakhari added a comment. In D63846#1574102 , @rjmccall wrote: > Please don't check IR names in test output. That actually includes anonymous > names like `%2`; these should always be tested with FileCheck

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

vzakhari added inline comments. Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ - DESTINATION

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

vzakhari added a comment. In D58537#1476570 , @tstellar wrote: > Can you test D61054 ? I will do it ASAP, but I am currently having problems with my build system. I guess it is OK to proceed with this change. I will

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added reviewers: erichkeane, rsmith. vzakhari added a comment. Adding more reviewers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63846/new/ https://reviews.llvm.org/D63846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added a comment. In D64943#1633175 , @ABataev wrote: > In D64943#1633170 , @lebedev.ri > wrote: > > > In D64943#1633164 , @ABataev wrote: > > > > > In

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added a comment. In D64943#1633372 , @lebedev.ri wrote: > In D64943#1633357 , @vzakhari wrote: > > > In D64943#1633175 , @ABataev wrote: > > > > > In D64943#1633170

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added a comment. FYI, llvm.global_dtor fix is in https://reviews.llvm.org/D66373 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:226 +// Add this function to global destructors. +appendToGlobalDtors(M, Func, 0); + } FYI, llvm.global_dtors does not work on Windows. The symbol

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:226 +// Add this function to global destructors. +appendToGlobalDtors(M, Func, 0); + } ABataev wrote: > sdmitriev wrote: > > vzakhari wrote: > > > FYI,

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

vzakhari added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:291 // Add this function to global destructors. appendToGlobalDtors(M, Func, 0); } I think __tgt_unregister_lib should have a matching priority.

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

vzakhari added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75223/new/ https://reviews.llvm.org/D75223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

vzakhari added a comment. Herald added a project: LLVM. It does not work on Windows (msbuild) for me, because `${pathlist_escaped}` contains paths like `%(build_mode)s/bin` (caused by `set_llvm_build_mode`). This seems to break something so that `python` process does not produce any output at

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

vzakhari added a comment. In D77184#2056306 , @vzakhari wrote: > It does not work on Windows (msbuild) for me, because `${pathlist_escaped}` > contains paths like `%(build_mode)s/bin` (caused by `set_llvm_build_mode`). > This seems to break something

[PATCH] D80655: Define __SPIR__ macro for spir/spir64 targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1b07506c1f: Define __SPIR__ macro for spir/spir64 targets. (authored by vzakhari). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105375: [OPENMP]Remove const firstprivate allocation as a variable in a constant space.

vzakhari accepted this revision. vzakhari added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105375/new/ https://reviews.llvm.org/D105375

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari added a comment. In D99360#2652523 , @jhenderson wrote: > It might make sense to do the llvm-readobj portions of this patch in a > separate review, since they are somewhat independent. I agree. I actually have them in two patches, but I

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 78. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360 Files: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp llvm/include/llvm/BinaryFormat/ELF.h llvm/tools/llvm-readobj/ELFDumper.cpp

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari created this revision. vzakhari added a project: OpenMP. Herald added subscribers: kerbowa, rupprecht, guansong, yaxunl, mgorny, nhaehnle, jvesely. Herald added a reviewer: alexshap. Herald added a reviewer: jhenderson. vzakhari requested review of this revision. Herald added

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari added a comment. In D99360#2654244 , @MaskRay wrote: >> It might make sense to do the llvm-readobj portions of this patch in a >> separate review, since they are somewhat independent. > > +1. Patches touching

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari created this revision. vzakhari added reviewers: ABataev, sdmitriev, grokos. vzakhari added a project: OpenMP. Herald added a reviewer: alexshap. vzakhari requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1.

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D99551 Files: clang/test/Driver/Inputs/clang-offload-wrapper/elf32be clang/test/Driver/Inputs/clang-offload-wrapper/elf32le

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 333484. vzakhari edited the summary of this revision. vzakhari added a comment. Fixed issues detected in Windows testing downstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99360/new/ https://reviews.llvm.org/D99360 Files:

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari abandoned this revision. vzakhari added a comment. The revision was split into: D99612 , D99551 , D99552 , D99553 CHANGES SINCE LAST ACTION

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334282. vzakhari added a comment. I am not sure what is wrong with the uploaded ELF files. The test works locally. Let's try it with a thinner YAML template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334292. vzakhari added a comment. Herald added a subscriber: mgorny. Updated revision fixes //BUILD_SHARED_LIBS// build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D99551 Files:

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2952336 , @JonChesterfield wrote: > Nvptx broken here too, amdgpu is fine. I'm guessing one of the cuda tools > does some overly aggressive input validation that we're running afoul of. > > There was a discussion

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

vzakhari added a comment. Hi Jon, I am about to merge D108246 that disables the notes embedding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108303/new/ https://reviews.llvm.org/D108303

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ffbe8c04ff2: [clang-offload-wrapper] Disabled ELF offload notes embedding by default. (authored by vzakhari). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108303: [clang][openmp] Disable embedded elf notes

vzakhari added a comment. In D108303#2952393 , @JonChesterfield wrote: > I like D108246 more. None of the > offloading tests updated in D108246 failed > with the above patch,

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2950522 , @jhuber6 wrote: > In D99551#2950515 , @vzakhari wrote: > >> In D99551#2950464 , @jhuber6 wrote: >> >>> In D99551#2950281

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2950464 , @jhuber6 wrote: > In D99551#2950281 , @vzakhari wrote: > >> @jhuber6, thank you for reporting this. I do not have a properly setup CUDA >> system currently. Can you

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

vzakhari created this revision. vzakhari added a reviewer: jhuber6. vzakhari added a project: OpenMP. vzakhari requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This change-set puts

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. @jhuber6, thank you for reporting this. I do not have a properly setup CUDA system currently. Can you please invoke `clang-offload-wrapper` with `-save-temps` and send the temporary files to me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

vzakhari added a comment. In D108246#2950650 , @jdoerfert wrote: > I would prefer to revert 93d08acaacec951dbb302f77eeae51974985b6b2 > now and > then fix the CUDA toolchain rather

[PATCH] D108246: [clang-offload-wrapper] Disabled ELF offload notes embedding by default.

vzakhari updated this revision to Diff 367057. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108246/new/ https://reviews.llvm.org/D108246 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp Index:

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93d08acaacec: [clang-offload-wrapper] Add standard notes for ELF offload images (authored by vzakhari). Repository: rG LLVM Github Monorepo

[PATCH] D108673: [CodeExtractor] Preserve topological order for the return blocks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e192ab1f457: [CodeExtractor] Preserve topological order for the return blocks. (authored by vzakhari). Herald added a project: clang. Herald added

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 364193. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D99551 Files: clang/test/Driver/Inputs/empty-elf-template.yaml clang/test/Driver/clang-offload-wrapper.c

[PATCH] D112103: [WIP] Sample code for containerizing offload images into one ELF.

vzakhari created this revision. vzakhari added reviewers: saiislam, jdoerfert. Herald added a reviewer: alexander-shaposhnikov. vzakhari requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This code cannot currently work within llorg,

[PATCH] D112103: [WIP][RFC] Sample code for containerizing offload images into one ELF.

vzakhari abandoned this revision. vzakhari added a comment. Herald added a project: All. Not working on the project any more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112103/new/ https://reviews.llvm.org/D112103