[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

nullptr.cpp added a comment. @jdoerfert @ABataev I don't have commit access, can you help commit this? Yang Fan Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

nullptr.cpp added a comment. In D86858#2246925 , @jdoerfert wrote: > Can you add the test that exposed this? Sorry, this was discovered by a static analyzer checker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

nullptr.cpp added a comment. Herald added a subscriber: danielkiss. In D86691#2241886 , @martong wrote: > In D86691#2241604 , @nullptr.cpp > wrote: > >> In D86691#2241401 ,

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

nullptr.cpp created this revision. nullptr.cpp added a reviewer: ABataev. Herald added subscribers: cfe-commits, danielkiss, guansong, yaxunl. Herald added a project: clang. nullptr.cpp requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1.

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

nullptr.cpp updated this revision to Diff 288894. nullptr.cpp added a comment. Fix by changing the loop condition to `Level > 0`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 Files:

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

nullptr.cpp updated this revision to Diff 289069. nullptr.cpp added a comment. trigger rebuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 Files: clang/lib/Sema/SemaOpenMP.cpp Index:

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp updated this revision to Diff 290886. nullptr.cpp added a comment. [NFC] Fix pessimizing-move warnings due to std::move in return statements Gcc warning: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp updated this revision to Diff 290944. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347 Files: clang/lib/Lex/Pragma.cpp llvm/lib/Analysis/VectorUtils.cpp llvm/lib/MC/WasmObjectWriter.cpp

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp updated this revision to Diff 290864. nullptr.cpp added a comment. Fix by directly using `INT_MAX` and `INT32_MAX`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347 Files:

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp added a comment. I don't have commit access, can anyone help me commit this with `"Yang Fan "` ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, sbc100. Herald added projects: clang, LLVM. nullptr.cpp requested review of this revision. Herald added a subscriber: aheejin. Fix by explicitly expressing the conversions that caused by comparison.

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp added a comment. I don't have commit access, can anyone help commit this and D86997 ? Yang Fan Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. Ping! I don't have commit access, can anyone help me commit this with "Yang Fan " ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295

[PATCH] D86334: [analyzer] Remove redundant output errs

nullptr.cpp added a comment. I don't have commit access, can you help commit it? In D86334#2230032 , @xazax.hun wrote: > LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86334/new/

[PATCH] D86334: [analyzer] Remove redundant output errs

nullptr.cpp created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. nullptr.cpp requested review of this revision. No need to

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

nullptr.cpp added a comment. In D86691#2241401 , @Szelethus wrote: > Nice, thank you! Did you stumble across this, or found it with a tool? I just happened to see these code:-). Maybe we should write a checker to check this situation? I will start doing

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

nullptr.cpp created this revision. nullptr.cpp added reviewers: dcoughlin, NoQ, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang.

[PATCH] D86691: [analyzer] Fix wrong parameter name in printFormattedEntry

nullptr.cpp added a comment. @Szelethus @martong Sorry to interrupt, I don't have commit access, can you help commit this and D86334 ? Yang Fan Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86691/new/

[PATCH] D88220: [C++20] Implement more implicit moves for return statements(Part of P1825R0)

nullptr.cpp created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nullptr.cpp requested review of this revision. In P1825R0, the first parameter of overload resolution selected function does not need to be an rvalue reference to the returned object's type.

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp created this revision. nullptr.cpp added reviewers: Quuxplusone, rsmith, erik.pilkington. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. nullptr.cpp requested review of this revision. In C++11 standard, to become implicitly movable, the expression in

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. - C++11: > [class.copy]p32: > When **the criteria for elision of a copy operation **are met or would be met > save for the fact that the source object is a function parameter, and the > object to be copied is designated by an lvalue, overload resolution to select

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp updated this revision to Diff 294485. nullptr.cpp added a comment. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 Files: clang/lib/Sema/SemaStmt.cpp

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. Ping I don't have commit access, can anyone help me commit this with "Yang Fan " ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 309873. nullptr.cpp added a comment. Herald added a subscriber: lxfind. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files:

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4626 CES_AllowExceptionVariables = 4, -CES_FormerDefault = (CES_AllowParameters), -CES_Default = (CES_AllowParameters | CES_AllowDifferentTypes), -CES_AsIfByStdMove =

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 311137. nullptr.cpp added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp added a comment. Note: The failed test has nothing to do with this patch. Comment at: clang/lib/Sema/SemaInit.cpp:4146 CXXConstructorDecl *CtorDecl = cast(Best->Function); - if (Kind.getKind() == InitializationKind::IK_Default && -

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 313493. nullptr.cpp added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 311158. nullptr.cpp added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. Thanks for all your suggestions! But I don't have commit access, can anyone help me commit this with "Yang Fan " ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 304447. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88220: [C++20] Implement more implicit moves for return statements(Part of P1825R0)

nullptr.cpp updated this revision to Diff 302544. nullptr.cpp added a comment. Implement whole P1825R0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp updated this revision to Diff 301810. nullptr.cpp added a comment. make test more clearly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 Files: clang/lib/Sema/SemaStmt.cpp

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. In D88295#2358845 , @aaronpuchert wrote: > Could you perhaps integrate this into the existing test > `clang/test/CXX/special/class.copy/implicit-move.cpp` instead? > Whenever you have something that closely corresponds to

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp updated this revision to Diff 301822. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 Files: clang/lib/Sema/SemaStmt.cpp

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp updated this revision to Diff 302073. nullptr.cpp added a comment. move test to `class/class.init/class.copy.elision/p1.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 Files:

[PATCH] D93955: [Sema] Add support for reporting multiple errors during initialization

nullptr.cpp updated this revision to Diff 314177. nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93955/new/ https://reviews.llvm.org/D93955 Files:

[PATCH] D93955: [Sema] Add support for reporting multiple errors during initialization

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. During the initialization process, more than one error may be encountered, but Clang reports only one of them. This patch makes Clang report all

[PATCH] D93961: [clang-tidy][NFC] Fix a build warning due to an extra semicolon

nullptr.cpp created this revision. Herald added a subscriber: xazax.hun. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93961 Files:

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

This revision was automatically updated to reflect the committed changes. Closed by commit rG89b0972aa2f5: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93962: [Sema] Fix the program state in reference initialization

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to [dcl.init.ref]p5: > A reference to type “cv1 T1” is initialized by an expression of type “cv2 T2” > as follows: > > — If the

[PATCH] D93961: [clang-tidy][NFC] Fix a build warning due to an extra semicolon

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd5324c052b21: [clang-tidy][NFC] Fix a build warning due to an extra semicolon (authored by nullptr.cpp). Repository:

[PATCH] D93955: [Sema] Add support for reporting multiple errors during initialization

nullptr.cpp updated this revision to Diff 314214. nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Separate out D93962 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93955/new/

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 314208. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 314509. nullptr.cpp added a comment. Fix use-of-uninitialized-value and `-Wreturn-std-move` with delete function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

This revision was automatically updated to reflect the committed changes. Closed by commit rG74f93bc373d0: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. In D88220#2495071 , @Quuxplusone wrote: > I notice a lack of any explicitly `co_return`-related tests and/or code in > this patch. I'm just going to assume that is fine. `co_return` related implicit move is implemented by

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 318406. nullptr.cpp added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 318420. nullptr.cpp added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D94011: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In implicitly movable test, a two-stage overload resolution is performed. If the first overload resolution selects a deleted function, Clang

[PATCH] D94006: [Sema] Fix use-of-uninitialized-value cause by 89b0972aa2f58f927633c63570b36550a17f4e63

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94006 Files: clang/lib/Sema/SemaInit.cpp Index:

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 316302. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 313831. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 313828. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96478: [clang][cli] Fix gcc warning (NFC)

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC warning: /llvm-project/clang/lib/Frontend/TestModuleFileExtension.cpp:131:20: warning: ‘llvm::raw_ostream&

[PATCH] D96478: [clang][cli] Fix gcc warning (NFC)

nullptr.cpp updated this revision to Diff 322896. nullptr.cpp added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96478/new/ https://reviews.llvm.org/D96478 Files: clang/lib/Frontend/TestModuleFileExtension.cpp Index:

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. In D97361#2609616 , @nullptr.cpp wrote: > - Restrict to only run on C++ code > - Ignore `using` defined in macro > - Support inline namespace > - Support global namespace Ping. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Herald added a project: clang-tools-extra. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list

[PATCH] D97361: [clang-tidy] Add cppcoreguidelines-comparison-operator

nullptr.cpp updated this revision to Diff 331178. nullptr.cpp retitled this revision from "[clang-tidy] Add readability-redundant-using check" to "[clang-tidy] Add cppcoreguidelines-comparison-operator". nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Herald added

[PATCH] D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator

nullptr.cpp updated this revision to Diff 331170. nullptr.cpp marked 6 inline comments as done. nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Modify according to suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator

nullptr.cpp updated this revision to Diff 331179. nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98692/new/ https://reviews.llvm.org/D98692 Files:

[PATCH] D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator

nullptr.cpp added a comment. In D98692#2631182 , @njames93 wrote: > While we're here, I'm not sure if there is a cppcoreguideline for it, but > parameters to comparison functions should be passed by const ref usually, or > by value if they are cheap to

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp updated this revision to Diff 331188. nullptr.cpp retitled this revision from "[clang-tidy] Add cppcoreguidelines-comparison-operator" to "[clang-tidy] Add readability-redundant-using check". nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Rebase

[PATCH] D98692: [clang-tidy] Add cppcoreguidelines-comparison-operator

nullptr.cpp updated this revision to Diff 332145. nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. - Warn on both declarations and definitions - Add check for parameter passing - Add options `CheckParamPassing` and `ExpensiveToCopySize` Repository: rG LLVM Github

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `-Wreturn-std-move-in-c++11` has been removed in fbee4a0c79cc4ee87c34e51342742a5bc6fcf872

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. In D88220#2583486 , @aaronpuchert wrote: > In D88220#2581538 , @aaron.ballman > wrote: > >> We usually rely on the release notes to say something, but we didn't do that >> here. > >

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp updated this revision to Diff 328841. nullptr.cpp added a comment. - Restrict to only run on C++ code - Ignore `using` defined in macro - Support inline namespace - Support global namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

This revision was automatically updated to reflect the committed changes. Closed by commit rGb950de5c13ef: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11 (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

nullptr.cpp added a comment. In D97364#2586171 , @aaronpuchert wrote: > I assume you need someone to land this for you? I can do it by myself, I have the commit access now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97361: [clang-tidy] Add misc-redundant-using check

nullptr.cpp created this revision. nullptr.cpp added reviewers: alexfh, aaron.ballman, njames93, balazske. Herald added subscribers: xazax.hun, mgorny. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Finds redundant `using`

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp updated this revision to Diff 326320. nullptr.cpp retitled this revision from "[clang-tidy] Add misc-redundant-using check" to "[clang-tidy] Add readability-redundant-using check". nullptr.cpp added a comment. Modify according to suggestions Repository: rG LLVM Github Monorepo

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97361/new/ https://reviews.llvm.org/D97361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org