[PATCH] D62045: Modified global variable declaraction to fit updated objc guide.

yaqiji created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. yaqiji updated this revision to Diff 199931. yaqiji added a comment. yaqiji updated this revision to Diff 199932. removed unnecessary lines yaqiji added a comment. Removed unncessary comments.

[PATCH] D62045: Modified global variable declaraction to fit updated objc guide.

yaqiji updated this revision to Diff 199932. yaqiji added a comment. Removed unncessary comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableD

[PATCH] D62045: Modified global variable declaraction to fit updated objc guide.

yaqiji updated this revision to Diff 199931. yaqiji added a comment. removed unnecessary lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDecl

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 199939. yaqiji added a comment. Modified code to make it more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/Glob

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 199944. yaqiji added a comment. Changes matcher, test and removed fix it hint for global constants Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-e

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200102. yaqiji added a comment. Updated matching criteria to allow variable declarations for legacy code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-t

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200113. yaqiji marked an inline comment as done. yaqiji added a comment. Added fixithint for const as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clan

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200399. yaqiji marked 2 inline comments as done. yaqiji added a comment. Herald added a subscriber: mgorny. Modified CMakeList to include tests, otherwise clangTidyGoogleModule wouldn't compile. Added k_Alpha test case back. Added Extern case so that if it i

[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

yaqiji updated this revision to Diff 200401. yaqiji added a comment. Simplified method signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt

[PATCH] D62045: Do not emit fixes for extern global constants in google-objc-global-variable-declaration check.

yaqiji updated this revision to Diff 200613. yaqiji marked 4 inline comments as done. yaqiji added a comment. Restored fix. Added test case for extern Cap+Number prefixes. Restored reformatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/ne

[PATCH] D62045: Do not emit fixes for extern global constants in google-objc-global-variable-declaration check.

yaqiji updated this revision to Diff 200614. yaqiji added a comment. Removed extra space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt clang-

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 200637. yaqiji edited the summary of this revision. yaqiji added a comment. Removed other mdodified file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201352. yaqiji marked 3 inline comments as done. yaqiji added a comment. Added fix message, and change global to nonstatic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D6204

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji added a comment. Thank you so much for reviewing the code and providing great feedbacks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 ___ cfe-commits

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji added a comment. Yes please, thank you :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201968. yaqiji added a comment. Updated warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationChe

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201969. yaqiji added a comment. Added check-fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationChe

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201972. yaqiji added a comment. Remove cmake content Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarati

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201971. yaqiji added a comment. Removed check-fixes for those without fixithint. Changed name of Y2Good to Y2Bad to match meaning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.o

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201973. yaqiji added a comment. Added to check no fixit is generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/Global