[clang-tools-extra] cbd6ac6 - [clangd] Show parameter hints for operator()

2023-09-10 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-09-10T15:56:00+08:00 New Revision: cbd6ac6165e683f2eed4a5066c1ccf53bed0696d URL: https://github.com/llvm/llvm-project/commit/cbd6ac6165e683f2eed4a5066c1ccf53bed0696d DIFF: https://github.com/llvm/llvm-project/commit/cbd6ac6165e683f2eed4a5066c1ccf53bed0696d.diff

[clang] 2fd01d7 - [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

2023-09-01 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-09-01T15:49:39+08:00 New Revision: 2fd01d75a863184766ee0c82b5c0fc8be172448a URL: https://github.com/llvm/llvm-project/commit/2fd01d75a863184766ee0c82b5c0fc8be172448a DIFF: https://github.com/llvm/llvm-project/commit/2fd01d75a863184766ee0c82b5c0fc8be172448a.diff

[clang-tools-extra] e257c0a - [clang][clangd] Ensure the stack bottom before building AST

2023-09-02 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-09-02T18:53:06+08:00 New Revision: e257c0a9190637e44e292271103a13d70bec4b03 URL: https://github.com/llvm/llvm-project/commit/e257c0a9190637e44e292271103a13d70bec4b03 DIFF: https://github.com/llvm/llvm-project/commit/e257c0a9190637e44e292271103a13d70bec4b03.diff

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-30 Thread Younan Zhang via cfe-commits
@@ -3553,6 +3553,49 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thank you! I didn't realize that `getActiveBits` was calculated by the count of leading zeros, even for negative numbers. This generally looks good modulo a question on the test. https://github.com/llvm/llvm-project/pull/71415

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-06 Thread Younan Zhang via cfe-commits
@@ -0,0 +1,29 @@ +# RUN: clangd -lit-test < %s | FileCheck %s zyn0217 wrote: Rather than creating a lit-test, could you please move it to the `HoverTests.cpp` under the unittests directory? That would be more straightforward, and I think we could add the case

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/71366 >From 4a878b63cbdd33833b998896120a992178438180 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 6 Nov 2023 16:50:02 +0800 Subject: [PATCH 1/3] [clangd] Don't show inlay hints for PseudoObjectExprs in C++

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't show inlay hints for __builtin_dump_struct (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
zyn0217 wrote: On second thought I think I should not kill all the expressions involving `PseudoObjectExpr`: I'm not sure if our ObjC / CUDA support does need that for presenting useful hints. https://github.com/llvm/llvm-project/pull/71366 ___

[clang-tools-extra] [clangd] Allow hover over 128-bit variable without crashing (PR #71415)

2023-11-07 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Thanks! Please go ahead and merge it. :-) https://github.com/llvm/llvm-project/pull/71415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-29 Thread Younan Zhang via cfe-commits
@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-29 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-29 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 commented: Thank you for working on this! Some nit comments, hope you don't mind. (Also invited some clang folks to have a detailed look at this. :=) https://github.com/llvm/llvm-project/pull/70548 ___ cfe-commits mailing

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-29 Thread Younan Zhang via cfe-commits
@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-29 Thread Younan Zhang via cfe-commits
@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [Clang] Defer the instantiation of explicit-specifier until constraint checking completes (PR #70548)

2023-10-29 Thread Younan Zhang via cfe-commits
@@ -3553,6 +3553,56 @@ static unsigned getPackIndexForParam(Sema , llvm_unreachable("parameter index would not be produced from template"); } +// if `Specialization` is a `CXXConstructorDecl` or `CXXConversionDecl` +// we try to instantiate and update its explicit specifier

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-25 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/69224 >From 880f271cbad4aacb7647bc402f636adf12ca1147 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 16 Oct 2023 22:50:08 +0800 Subject: [PATCH] [clang][Sema] Avoid non-empty unexpanded pack assertion for

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-25 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Done. Sorry for leaving irrelevant changes ;) https://github.com/llvm/llvm-project/pull/69224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't show inlay hints for PseudoObjectExprs (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't show inlay hints for PseudoObjectExprs in C++ (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/71366 >From 4a878b63cbdd33833b998896120a992178438180 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 6 Nov 2023 16:50:02 +0800 Subject: [PATCH 1/2] [clangd] Don't show inlay hints for PseudoObjectExprs in C++

[clang-tools-extra] [clangd] Don't show inlay hints for PseudoObjectExprs (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't show inlay hints for PseudoObjectExprs in C++ (PR #71366)

2023-11-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/71366 This closes https://github.com/clangd/clangd/issues/1813. PseudoObjectExprs in C++ are currently not very interesting but probably mess up inlay hints. >From 4a878b63cbdd33833b998896120a992178438180 Mon Sep 17

[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-11-04 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/71279 This is an enhancement to the HeuristicResolver, trying to extract the deduced type from the single instantiation for a template. This partially addresses the point #1 from

[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-11-04 Thread Younan Zhang via cfe-commits
@@ -46,6 +50,98 @@ const Type *resolveDeclsToType(const std::vector , return nullptr; } +// Visitor that helps to extract deduced type from instantiated entities. +// This merely performs the source location comparison against each Decl +// until it finds a Decl with the

[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-11-04 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 23ef8bf - [clangd][CodeComplete] Improve FunctionCanBeCall

2023-09-28 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-09-28T21:42:02+08:00 New Revision: 23ef8bf9c0f338ee073c6c1b553c42e46d2f22ad URL: https://github.com/llvm/llvm-project/commit/23ef8bf9c0f338ee073c6c1b553c42e46d2f22ad DIFF: https://github.com/llvm/llvm-project/commit/23ef8bf9c0f338ee073c6c1b553c42e46d2f22ad.diff

[clang] [clang][Sema] Don't assert non-empty unexpanded packs following Colle… (PR #69224)

2023-10-21 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Sorry for my late update - I've had a busy week ;) > I don't think so as they don't have parameter or capture list +1. and it looks like we don't allow expanding a pack outside a statement expression, which more or less prevents the appearance of `FunctionParmPackExpr`. > so

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-21 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/69224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-21 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/69224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-21 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/69224 >From 89e486690f1a28900152d4eef023be6fdfcf296a Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 16 Oct 2023 22:50:08 +0800 Subject: [PATCH] [clang][Sema] Avoid non-empty unexpanded pack assertion for

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-22 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Thank you @Endilll for the explanation. The remaining part looks good; @sr-tream Do you have access to land the PR? If not, I'm glad to help you. :) https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-23 Thread Younan Zhang via cfe-commits
@@ -402,6 +402,20 @@ bool Sema::DiagnoseUnexpandedParameterPack(Expr *E, if (!E->containsUnexpandedParameterPack()) return false; + // Exception: The `CollectUnexpandedParameterPacksVisitor` collects nothing + // from a FunctionParmPackExpr. In the context where the

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/68177 >From f83f28d0d055066bb7660e24e2253a61273f014a Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 4 Oct 2023 11:59:31 +0800 Subject: [PATCH 1/3] [clangd] Adapt Inlay Hint support for Deducing This This is a

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/68177 >From f83f28d0d055066bb7660e24e2253a61273f014a Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 4 Oct 2023 11:59:31 +0800 Subject: [PATCH 1/4] [clangd] Adapt Inlay Hint support for Deducing This This is a

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/69224 >From ec6425590890e050dc212a7e13ca27c866a4fb22 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 16 Oct 2023 22:50:08 +0800 Subject: [PATCH 1/2] [clang][Sema] Avoid non-empty unexpanded pack assertion for

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-23 Thread Younan Zhang via cfe-commits
@@ -859,7 +872,9 @@ class InlayHintVisitor : public RecursiveASTVisitor { else ForwardedParams = {Params.begin(), Params.end()}; -NameVec ParameterNames = chooseParameterNames(ForwardedParams); +auto ForwardedParamsRef = zyn0217 wrote:

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/68177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/69224 >From 07749e92c55cb4dfd01e81c9c8413b77c915aa42 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 16 Oct 2023 22:50:08 +0800 Subject: [PATCH 1/2] [clang][Sema] Avoid non-empty unexpanded pack assertion for

[clang] 69a8636 - [clang][NFC] Remove redundant whitespaces

2023-08-19 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-08-19T19:25:32+08:00 New Revision: 69a8636c4dec2c9e561224e603ea9864a06bee3a URL: https://github.com/llvm/llvm-project/commit/69a8636c4dec2c9e561224e603ea9864a06bee3a DIFF: https://github.com/llvm/llvm-project/commit/69a8636c4dec2c9e561224e603ea9864a06bee3a.diff

[clang-tools-extra] 138adb0 - [clangd] Refine logic on $0 in completion snippets

2023-03-17 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-03-17T17:57:24+08:00 New Revision: 138adb0980328d6b958a732d6853d0111aa9cb51 URL: https://github.com/llvm/llvm-project/commit/138adb0980328d6b958a732d6853d0111aa9cb51 DIFF: https://github.com/llvm/llvm-project/commit/138adb0980328d6b958a732d6853d0111aa9cb51.diff

[clang-tools-extra] 0b103ed - [clangd] Fix a hover crash on unsigned 64bit value

2023-03-26 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-03-27T10:27:11+08:00 New Revision: 0b103edf5b2c6178c2725a9ff085c6ccc866bccb URL: https://github.com/llvm/llvm-project/commit/0b103edf5b2c6178c2725a9ff085c6ccc866bccb DIFF: https://github.com/llvm/llvm-project/commit/0b103edf5b2c6178c2725a9ff085c6ccc866bccb.diff

[clang-tools-extra] cb2d04d - [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

2023-02-26 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-02-26T19:06:44+08:00 New Revision: cb2d04d41e47e65812434f775215247bfe19b3dd URL: https://github.com/llvm/llvm-project/commit/cb2d04d41e47e65812434f775215247bfe19b3dd DIFF: https://github.com/llvm/llvm-project/commit/cb2d04d41e47e65812434f775215247bfe19b3dd.diff

[clang] d982643 - [clang] Implement CWG 2397

2023-04-12 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-04-12T22:30:23+08:00 New Revision: d9826433f31cd081d0229d47d7982b5bf3c0055f URL: https://github.com/llvm/llvm-project/commit/d9826433f31cd081d0229d47d7982b5bf3c0055f DIFF: https://github.com/llvm/llvm-project/commit/d9826433f31cd081d0229d47d7982b5bf3c0055f.diff

[clang] d4021ed - [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`

2023-02-13 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-02-14T01:07:39+08:00 New Revision: d4021ed3d79d8823317d894b55f4e6a30cfc3614 URL: https://github.com/llvm/llvm-project/commit/d4021ed3d79d8823317d894b55f4e6a30cfc3614 DIFF: https://github.com/llvm/llvm-project/commit/d4021ed3d79d8823317d894b55f4e6a30cfc3614.diff

[clang-tools-extra] 7d68f2e - [clangd] Desugar template parameter aliases in type hints

2023-06-13 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-06-13T19:15:24+08:00 New Revision: 7d68f2ef411ea2188666c2f67a8ee8b923adb12d URL: https://github.com/llvm/llvm-project/commit/7d68f2ef411ea2188666c2f67a8ee8b923adb12d DIFF: https://github.com/llvm/llvm-project/commit/7d68f2ef411ea2188666c2f67a8ee8b923adb12d.diff

[clang-tools-extra] 5cdb906 - [clangd] Unify printing policy for type hints

2023-06-13 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-06-13T21:31:10+08:00 New Revision: 5cdb906f1e4093600f99aab8660e1536514a57e8 URL: https://github.com/llvm/llvm-project/commit/5cdb906f1e4093600f99aab8660e1536514a57e8 DIFF: https://github.com/llvm/llvm-project/commit/5cdb906f1e4093600f99aab8660e1536514a57e8.diff

[clang] 0e08374 - [clang][NFC] Add a notice to desugarForDiagnostic

2023-06-14 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-06-15T11:55:06+08:00 New Revision: 0e08374abb2c61a3ae5c24d5f60be3b548da9778 URL: https://github.com/llvm/llvm-project/commit/0e08374abb2c61a3ae5c24d5f60be3b548da9778 DIFF: https://github.com/llvm/llvm-project/commit/0e08374abb2c61a3ae5c24d5f60be3b548da9778.diff

[clang-tools-extra] b1193c1 - [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

2023-08-01 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-08-01T20:12:35+08:00 New Revision: b1193c13a5f9e9a2dca6ae0dd8b4e911f54c09ce URL: https://github.com/llvm/llvm-project/commit/b1193c13a5f9e9a2dca6ae0dd8b4e911f54c09ce DIFF: https://github.com/llvm/llvm-project/commit/b1193c13a5f9e9a2dca6ae0dd8b4e911f54c09ce.diff

[clang] 76d72a7 - [clang] Fix a crash on invalid destructor

2023-06-25 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-06-26T09:35:12+08:00 New Revision: 76d72a715038ae3bce711ddc372e7e273a5c2b6b URL: https://github.com/llvm/llvm-project/commit/76d72a715038ae3bce711ddc372e7e273a5c2b6b DIFF: https://github.com/llvm/llvm-project/commit/76d72a715038ae3bce711ddc372e7e273a5c2b6b.diff

[clang-tools-extra] 84deed2 - [clangd] Fix a build failure. NFC

2023-05-09 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-05-10T08:28:07+08:00 New Revision: 84deed2b7b6325f99d50ce46512de2c078cefb3a URL: https://github.com/llvm/llvm-project/commit/84deed2b7b6325f99d50ce46512de2c078cefb3a DIFF: https://github.com/llvm/llvm-project/commit/84deed2b7b6325f99d50ce46512de2c078cefb3a.diff

[clang-tools-extra] 7385cc3 - [clangd] Support macro evaluation on hover

2023-05-09 Thread Younan Zhang via cfe-commits
Author: Younan Zhang Date: 2023-05-09T18:50:27+08:00 New Revision: 7385cc389abad29eb9044d260b23dd483d674718 URL: https://github.com/llvm/llvm-project/commit/7385cc389abad29eb9044d260b23dd483d674718 DIFF: https://github.com/llvm/llvm-project/commit/7385cc389abad29eb9044d260b23dd483d674718.diff

[clang] [Sema] 81145 (PR #81150)

2024-02-08 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/81150 None >From e2ea5d44935209d13c9eb33c089e4f58f2231acd Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 8 Feb 2024 23:44:56 +0800 Subject: [PATCH] [Sema] 81145 ---

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/80656 >From 48211eb7778db8fb8af144d59adb2e0941957c4c Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 5 Feb 2024 18:01:34 +0800 Subject: [PATCH] GH78524 --- clang/docs/ReleaseNotes.rst | 4

[clang] [Clang][Parser] GH78524 (PR #80656)

2024-02-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/80656 Poking the CI. >From 3ceeae611848b58f8d49c58295a625bdb052ac97 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 5 Feb 2024 18:01:34 +0800 Subject: [PATCH] GH78524 --- clang/lib/Parse/ParseExprCXX.cpp

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/80656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/80656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/80656 >From 48211eb7778db8fb8af144d59adb2e0941957c4c Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 5 Feb 2024 18:01:34 +0800 Subject: [PATCH 1/2] GH78524 --- clang/docs/ReleaseNotes.rst |

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/80656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] 81145 (PR #81150)

2024-02-09 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/81150 >From d9fe7f3777a27057181eaa008577fc13a30d30ee Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sat, 10 Feb 2024 15:34:36 +0800 Subject: [PATCH 1/2] fixup --- clang/include/clang/AST/DeclCXX.h | 6

[clang] [Sema] 81145 (PR #81150)

2024-02-09 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/81150 >From d9fe7f3777a27057181eaa008577fc13a30d30ee Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sat, 10 Feb 2024 15:34:36 +0800 Subject: [PATCH] fixup --- clang/include/clang/AST/DeclCXX.h | 6

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-15 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @cor3ntin gently ping https://github.com/llvm/llvm-project/pull/80656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Don't consider top-level cv-qualifiers in template partial orderings (PR #81449)

2024-02-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/81449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] 81145 (PR #81150)

2024-02-11 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/81150 >From d9fe7f3777a27057181eaa008577fc13a30d30ee Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sat, 10 Feb 2024 15:34:36 +0800 Subject: [PATCH 1/3] fixup --- clang/include/clang/AST/DeclCXX.h | 6

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-11 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/80656 >From 48211eb7778db8fb8af144d59adb2e0941957c4c Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 5 Feb 2024 18:01:34 +0800 Subject: [PATCH 1/3] GH78524 --- clang/docs/ReleaseNotes.rst |

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-11 Thread Younan Zhang via cfe-commits
@@ -168,3 +168,30 @@ auto lambda4 = [] requires(sizeof(char) == 1){}; // expected-error {{expected bo #if __cplusplus <= 202002L // expected-warning@-2{{lambda without a parameter clause is a C++23 extension}} #endif + +namespace GH78524 { + +template T Foo; + +template

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-11 Thread Younan Zhang via cfe-commits
@@ -1385,6 +1385,11 @@ ExprResult Parser::ParseLambdaExpressionAfterIntroducer( Diag(RAngleLoc, diag::err_lambda_template_parameter_list_empty); } else { + // We increase the template depth before recursing into a requires-clause. + // The

[clang] The lambda call inside of a type alias (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/82310 >From 0f97fae5d1ba4debe04824e5d2d98598504d003d Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 20 Feb 2024 14:54:14 +0800 Subject: [PATCH 1/2] The lambda call inside of a type alias ---

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
zyn0217 wrote: The Windows CI is still broken and I have to run the libc++ tests locally. https://github.com/llvm/llvm-project/pull/82310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] The lambda call inside of a type alias (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/82310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] The lambda call inside of a type alias (PR #82310)

2024-02-19 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/82310 None >From 0f97fae5d1ba4debe04824e5d2d98598504d003d Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 20 Feb 2024 14:54:14 +0800 Subject: [PATCH] The lambda call inside of a type alias ---

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/82310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix crash in codegen stage when an lambda expression declared in an unevaluated context (PR #80802)

2024-02-20 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @jcsxky Do you have more test cases other than the one from #76674? I wonder what'll happen if constraint checking is involved. https://github.com/llvm/llvm-project/pull/80802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/82310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Also added @shafik for some insights on tests / other existing issues. https://github.com/llvm/llvm-project/pull/82310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Result for libc++ tests: ``` Failed Tests (1): llvm-libc++-shared.cfg.in :: libcxx/headers_in_modulemap.sh.py Testing Time: 1232.89s Total Discovered Tests: 9673 Unsupported : 585 (6.05%) Passed : 9062 (93.68%) Expectedly Failed:

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/82310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Although this patch doesn't fix https://github.com/llvm/llvm-project/issues/82104 yet, which is a crash caused by a mismatch in the template argument during the return type deduction, I still tried a temporary workaround (turning some switches off / on for

[clang] [Clang][Sema] Fix the lambda call expression inside of a type alias declaration (PR #82310)

2024-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/82310 >From 0f97fae5d1ba4debe04824e5d2d98598504d003d Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 20 Feb 2024 14:54:14 +0800 Subject: [PATCH 1/3] The lambda call inside of a type alias ---

[clang] [clang][NFC] Regroup declarations in `Sema` (PR #82217)

2024-02-21 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > That's because you are filtering only opened PRs, not including drafts PRs. > For example there is this draft PR: > https://github.com/llvm/llvm-project/pull/81095/files (I think my recent PR https://github.com/llvm/llvm-project/pull/82310 now supersedes my two draft PRs,

[clang] GH70601 (PR #81095)

2024-02-21 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/81095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] 81145 (PR #81150)

2024-02-21 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/81150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Have the depth of the abbreviated generic lambdas inside a requires clause differ from the surrounding generic lambda (PR #80656)

2024-02-22 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @cor3ntin would you mind taking a look? thanks! https://github.com/llvm/llvm-project/pull/80656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Don't consider top-level cv-qualifiers in template partial orderings (PR #81449)

2024-02-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/81449 >From f4fb72075b8b3242656c10618eb5baa6a4204907 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 12 Feb 2024 15:47:59 +0800 Subject: [PATCH 1/2] [Clang][Sema] Don't consider top-level cv-qualifiers in

[clang] [Clang][Sema] Don't consider top-level cv-qualifiers in template partial orderings (PR #81449)

2024-02-12 Thread Younan Zhang via cfe-commits
zyn0217 wrote: The Windows CI is still not working; I ran the libc++ tests locally and they are green. https://github.com/llvm/llvm-project/pull/81449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Sema] Don't consider top-level cv-qualifiers in template partial orderings (PR #81449)

2024-02-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/81449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Don't consider top-level cv-qualifiers in template partial orderings (PR #81449)

2024-02-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/81449 >From f4fb72075b8b3242656c10618eb5baa6a4204907 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 12 Feb 2024 15:47:59 +0800 Subject: [PATCH 1/2] [Clang][Sema] Don't consider top-level cv-qualifiers in

[clang] [Clang][Sema] Don't consider top-level cv-qualifiers in template partial orderings (PR #81449)

2024-02-12 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/81449 This fixes a regression since https://github.com/llvm/llvm-project/commit/340eac01f7dad6c24cee35dd35f2484098dd6b1a, from which we compared function parameter types with cv-qualifiers taken into account.

[clang] GH70601 (PR #81095)

2024-02-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/81095 Testing libc++'s CI. >From 906fbf5b0796a85bf54028dfaa8e6343ea441a51 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 8 Feb 2024 15:07:47 +0800 Subject: [PATCH] GH70601 ---

[clang] [Concepts] Avoid substituting into constraints for invalid TemplateDecls (PR #75697)

2023-12-18 Thread Younan Zhang via cfe-commits
@@ -353,6 +353,10 @@ static ExprResult calculateConstraintSatisfaction( if (Inst.isInvalid()) return ExprError(); + // An empty expression for substitution failure messages. + if (Template && Template->isInvalidDecl()) +

[clang] [clang-tools-extra] [Sema][clangd] add noexcept to override functions during code completion (PR #75937)

2023-12-19 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > Maybe this deserves a new issue for clang Sema? Sounds reasonable to me. Feel free to put up a PR / issue for this if you are interested. https://github.com/llvm/llvm-project/pull/75937 ___ cfe-commits mailing list

[clang] [clang-tools-extra] [Sema][clangd] add noexcept to override functions during code completion (PR #75937)

2023-12-19 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Bonus: It appears that neither gcc nor clang implements a provision change from [CWG1351](https://cplusplus.github.io/CWG/issues/1351.html), > [except.spec]p4 > ..., **unless the overriding function is defined as deleted.** giving errors on the following code. ```cpp struct B

[clang] [clang-tools-extra] [Sema][clangd] add noexcept to override functions during code completion (PR #75937)

2023-12-19 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > ...which is called during code completion to generate the override function > declarator based on the FunctionDecl of the virtual function in the base. The place you're patching is not only specific to "completing override functions", but handles all completion strings

[clang-tools-extra] [clang] [Sema][clangd] add noexcept to override functions during code completion (PR #75937)

2023-12-19 Thread Younan Zhang via cfe-commits
zyn0217 wrote: In addition to Nathan’s advice, I have a question about the commit message > if the functions override a noexcept virtual function. I didn't see anything reflecting this condition; are you still working on this patch? Would you mind adding a WIP prefix to the title before

[clang-tools-extra] [WIP][clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-12-24 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/71279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [WIP][clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-12-24 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 converted_to_draft https://github.com/llvm/llvm-project/pull/71279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Handle lambda scopes inside Node::getDeclContext() (PR #76329)

2023-12-24 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/76329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Resolve the dependent type from its single instantiation. Take 1 (PR #71279)

2023-12-24 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Another issue I've encountered while at it is that, given the following code, ```cpp void foo(); auto lambda = [] { return ^foo(); }; ``` let `N` represent the selection node for the expression `foo()`, `N.getDeclContext()` then yields `TranslationUnitDecl` rather than the

  1   2   3   4   5   >