[PATCH] D64970: Handle windows line endings in QueryDriver

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. The previous patch did not fix the end mark. D64789

[PATCH] D64970: Handle windows line endings in QueryDriver

lh123 updated this revision to Diff 210735. lh123 added a comment. update test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64970/new/ https://reviews.llvm.org/D64970 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/c

[PATCH] D64970: Handle windows line endings in QueryDriver

lh123 updated this revision to Diff 210737. lh123 added a comment. update diff context. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64970/new/ https://reviews.llvm.org/D64970 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools

[PATCH] D64970: [clangd] Handle windows line endings in QueryDriver

lh123 added a comment. In D64970#1592881 , @kadircet wrote: > LGTM thanks! > > Do you have commit access? I don't have permission to commit. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64970/new/ https:/

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, ilya-biryukov. Herald added a project: clang. lh123 retitled this revision from "[CodeComplete] Tweak code completion for "typename" to "[CodeComplete] Tweak code completion f

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 updated this revision to Diff 272994. lh123 edited the summary of this revision. lh123 added a comment. address comment. Also tweak code completion behavior for `using`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82373/new/ https://revie

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

lh123 added a comment. If this patch looks good, please land it for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82373/new/ https://reviews.llvm.org/D82373 ___ cfe-commits mailing list cfe-commits

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058 Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); - Builder.AddPlaceholderChunk("qualifier"); - Builder.AddTextChunk("::"); ---

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058 Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); - Builder.AddPlaceholderChunk("qualifier"); - Builder.AddTextChunk("::"); ---

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`.

lh123 updated this revision to Diff 273074. lh123 retitled this revision from "[CodeComplete] Tweak code completion for `typename` and `using`." to "[CodeComplete] Tweak code completion for `typename`.". lh123 added a comment. Address comment. I will add `using $alias$ = $type$;` in a separate p

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. lh123 added a parent revision: D82373: [CodeComplete] Tweak code completion for `typename`.. Add code completion for using alias. Repository: rG LLVM Github Mo

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273287. lh123 added a comment. format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeCompletion/ordin

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273321. lh123 marked 3 inline comments as done. lh123 added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeCo

[PATCH] D82548: [CodeComplete] add code completion for `delete` and `default` specifier.

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. lh123 added a parent revision: D82535: [CodeComplete] Add code completion for using alias.. add code completion for `delete` and `default` specifier. Repository:

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

lh123 updated this revision to Diff 273631. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82535/new/ https://reviews.llvm.org/D82535 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/CodeCompletion/or

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

lh123 updated this revision to Diff 273928. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82714/new/ https://reviews.llvm.org/D82714 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/clan

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. lh123 updated this revision to Diff 273928. lh123 added a comment. Rebase to head. Remove redundan

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 273925. lh123 edited the summary of this revision. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sem

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 273942. lh123 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp clang/lib

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG84ced55d9b7b: [clangd] Remove redundant `findRefs` calls. NFC. (authored by lh123). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82714/new/ https://reviews

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274491. lh123 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274496. lh123 added a comment. Add the missing `operator!=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Pa

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 added a comment. In D82548#2124546 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > > arcfilter

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83fae3f76269: [CodeComplete] Add code completion after function equals (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D82548?vs=274496&id=274685#toc Repository: rG LLVM Github

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. In D72498#1814008 , @sammccall wrote: > I think i'm also comfortable with marking the linked bug as wontfix. The previous example is just minimal repo. template auto sum(T1 &t1, T2 &t2) ->decltype(t1 + t2)) { ret

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. > what do you think about unwrapping decltype only when it's a return value > (optional: of a function whose leading return type is auto) to narrowly catch > this idiom? I think it's worth fixing in the declarations too. int &bar(int a, int b); template auto ca

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. In D72498#1813902 , @ilya-biryukov wrote: > Could it be the case that we want to show the canonical types (i.e. without > all syntax sugar)? > Maybe we want both the normal type and the canonical type? +1,I think it would be hel

[PATCH] D72500: [clangd] Show hower info for expressions

lh123 added a comment. In D72500#1813975 , @sammccall wrote: > I think we should avoid triggering for literals. Maybe some exceptions, but a > hover saying that 0 is an int with value 0 seems silly. Yes, hovering over `IntegerLiteral/FloatingLiteral` ma

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. In D72498#1816339 , @sammccall wrote: > In D72498#1816244 , @ilya-biryukov > wrote: > > > In D72498#1815500 , @lh123 wrote: > > > > > - hover over the

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

lh123 added a comment. I think the character "🡺" should be avoided, as it may not display properly in some environments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/new/ https://reviews.llvm.org/D72623 __

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 created this revision. lh123 added reviewers: kadircet, sammccall. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Add canonical type to hover when

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389452. lh123 added a comment. add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389638. lh123 added a comment. format code and add testcase for template. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 added a comment. Related discussions: D72498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 ___ cfe-commits mailing lis

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389909. lh123 added a comment. Herald added a project: clang. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.c

[PATCH] D114522: [clangd] Add canonical type to hover

lh123 updated this revision to Diff 389911. lh123 added a comment. fix some bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hove

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389915. lh123 retitled this revision from "[clangd] Add canonical type to hover" to "[clangd] Add desugared type to hover". lh123 edited the summary of this revision. lh123 added a comment. 1. rename `CanType` to `DesugaredTy`. 2. fix some bug in compare `Print

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389921. lh123 added a comment. handle `TypeAliasTemplateDecl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389924. lh123 added a comment. rename `TTP` to `TAT`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cl

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389931. lh123 added a comment. Herald added a reviewer: gkistanova. Move some `desugared type` to `Definition`. Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files:

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:691 } else { HI.Definition = printType(QT, PP); sammccall wrote: > This seems like a pretty important case to handle. > A wrinkle is that this gets treated as C++ code (e.g. cli

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } It seems we lost `namespace qualifiers`. It always display `std::string` as `basic_string` Repository:

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } lh123 wrote: > It seems we lost `namespace qualifiers`. > It always display `std::string` as `basic_string`

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:166 +if (ShouldAKA) + AKA = Result + DesugaredTy.getAsString(PP); + } lh123 wrote: > lh123 wrote: > > It seems we lost `namespace qualifiers`. > > It always display `std::string

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Show parameters for construct.

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389968. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/unittest

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 updated this revision to Diff 390143. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114621/new/ https://reviews.llvm.org/D114621 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/u

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1065 + if (Parameters && !Parameters->empty()) { +Output.addParagraph().appendText("Parameters: "); kadircet wrote: > it's a subtle invarian

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390149. lh123 marked 13 inline comments as done. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clan

[PATCH] D114665: [clangd] Add a way to enable a.k.a print through config

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Currently, a.k.a printing is clo

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390153. lh123 added a comment. format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 390154. lh123 added a comment. format again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hove

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 updated this revision to Diff 390158. lh123 retitled this revision from "[clangd] Add a way to enable a.k.a print through config" to "[clangd] Make a.k.a printing configurable.". lh123 added a comment. fix testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 updated this revision to Diff 391537. lh123 marked 3 inline comments as done. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114621/new/ https://reviews.llvm.org/D114621 Files: clang-tools-extra/clang

[PATCH] D114621: [clangd] Show parameters for construct.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bb785cc339b: [clangd] Show parameters for construct. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D114621?vs=391537&id=391542#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 391545. lh123 added a comment. rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Ho

[PATCH] D114665: [clangd] Make a.k.a printing configurable.

lh123 updated this revision to Diff 391546. lh123 added a comment. rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114665/new/ https://reviews.llvm.org/D114665 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/clangd/Con

[PATCH] D115107: [clang][clangd] Desugar array type.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Desugar array type. Repo

[PATCH] D115108: [clangd] Print type for VarTemplateDecl in hover.

lh123 created this revision. lh123 added reviewers: kadircet, sammccall. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Print type for `VarTemplateDecl`

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. clangd should retain comments from system headers. fixes

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

lh123 added a comment. In D69928#1736569 , @ilya-biryukov wrote: > LGTM, thanks! > Do you need someone to land this? Yes, I can‘t commit it. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69928/new/ https

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov, hokein. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. vscode always escapes the colon on the file uri, w

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 planned changes to this revision. lh123 added a comment. it will cause whitspace escaped problem. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 ___ cfe-c

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 updated this revision to Diff 228393. lh123 added a comment. update diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/1.patch clang-tools-extra/clangd/clients/clangd-vscode/packa

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 updated this revision to Diff 228397. lh123 added a comment. Remove irrelevant files from the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/package.json clang-tools-extra/cl

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 updated this revision to Diff 228405. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/package.json clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts Index:

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 updated this revision to Diff 228421. lh123 added a comment. address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: package.json src/semantic-highlighting.ts Index: src/semantic-highlighting.ts

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 marked 2 inline comments as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:128 +this.highlighter.highlight( +vscode.Uri.parse(params.textDocument.uri).toString(), lines); } -

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

lh123 added a comment. Thanks for your reminder, I have sent an email to apply for commit access, but I don't know how long it will take. > Should I land this patch for you? Yes, you can land this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.or

[PATCH] D70078: [clangd] fixes semantic highlighting test

lh123 created this revision. lh123 added reviewers: ilya-biryukov, hokein, sammccall. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. fixes https://github.com/clangd/clangd/issues/176

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

lh123 added a comment. In D69996#1740412 , @hokein wrote: > I believe this patch fixes the issue, but we need to update the file > `test/semantic-highlighting.test.ts`), the test "Colorizer groups decorations > correctly" is diverged from the actual cod

[PATCH] D70164: [JSONCompilationDatabase] Fix backslash escaping on Windows

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov, hokein. Herald added subscribers: cfe-commits, usaxena95, mstorsjo, kadircet. Herald added a project: clang. We should always use `TokenizeWindowsCommandLine` on Windows. When compiling clangd with `MinGW-W64`, `Triple.

[PATCH] D70164: [Tooling][JSONCompilationDatabase] Fix backslash escaping on Windows

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/JSONCompilationDatabase.cpp:153 assert(Syntax == JSONCommandLineSyntax::Gnu); CommandLineArgumentParser parser(EscapedCommandLine); return parser.parse();

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov, hokein. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Add support for .rsp files in compile_commands.jso

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 added a comment. I don't know much about how to write unit tests, but it works fine on my computer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 ___ c

[PATCH] D70359: [clangd] Show values of more expressions on hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } I think we should also support hover on literal. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 229758. lh123 added a comment. update diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp Index: clang-tools-extra/clangd/GlobalCompilationData

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 229759. lh123 added a comment. format patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp Index: clang-tools-extra/clangd/GlobalCompilationDat

[PATCH] D70359: [clangd] Show values of more expressions on hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } sammccall wrote: > lh123 wrote: > > I think we should also support hover on literal. > sure - can you

[PATCH] D70359: [clangd] Show values of more expressions on hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } lh123 wrote: > sammccall wrote: > > lh123 wrote: > > > I think we should also support hover on literal

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 added a comment. In D70222#1749533 , @kadircet wrote: > Thanks for taking a look into this, the `rsp files` issue has came up before > in the past but there wasn't enough investment to implement it. > > Haven't checked the implementation in detail y

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 229807. lh123 added a comment. Move the implementation to `JSONCompilationDatabase`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/lib/Tooling/JSONCompilationDatabase.cpp Index: clang/lib/Too

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 229812. lh123 added a comment. Respect `JSONCommandLineSyntax` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/lib/Tooling/JSONCompilationDatabase.cpp Index: clang/lib/Tooling/JSONCompilationDa

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230031. lh123 edited the summary of this revision. lh123 added a comment. Address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230033. lh123 added a comment. fix typo in function document. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CompilationDatabase.

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230060. lh123 added a comment. fixes some bug and add more test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CompilationDatab

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230752. lh123 added a comment. Herald added a subscriber: mgorny. Address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230756. lh123 added a comment. Expand response files before `inferMissingCompileCommands` and `inferTargetAndDriverMode` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/Co

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto &Cmd : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} kadircet wrote: > so it looks like w

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/CompilationDatabase.cpp:402 llvm::sys::path::append(DatabasePath, "compile_flags.txt"); -return FixedCompilationDatabase::loadFromFile(DatabasePath, ErrorMessage); +aut

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231051. lh123 added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CMakeLists.txt clang/lib/Tooling

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto &Cmd : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} lh123 wrote: > kadircet wrote: > > s

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Tooling/ExpandResponseFilesCompilationDatabase.cpp:167 +for (auto &Cmd : Cmds) { + expandResponseFiles(Cmd, Tokenizer); +} lh123 wrote: > lh123 wrote: > > kadi

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 created this revision. lh123 added a reviewer: kadircet. Herald added subscribers: llvm-commits, cfe-commits, seiya, rupprecht, MaskRay, jakehehrlich, aheejin, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a review

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 added a comment. In D70769#1761394 , @jhenderson wrote: > Are there any instances where we DON'T want to get the real file system? If > not, could the `*llvm::vfs::getRealFileSystem()` call be put inside > `cl::ExpandResponseFiles`? This patch is

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231213. lh123 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/tools/driver/driver.cpp lld/COFF/DriverUtils.cpp lld/ELF/DriverUtils.cpp lld/MinGW/Driver.cp

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231215. lh123 added a comment. address comments and delete unused code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: clang/tools/driver/driver.cpp lld/COFF/DriverUtils.cpp lld/ELF/DriverUtils.c

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231217. lh123 set the repository for this revision to rG LLVM Github Monorepo. lh123 added a comment. rebase to D70769 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ ht

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231234. lh123 added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/ https://reviews.llvm.org/D70769 Files: llvm/include/llvm/Support/CommandLine.h llvm/lib/Support/Comma

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 231235. lh123 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/CMake

  1   2   >