[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

pgousseau created this revision. pgousseau added reviewers: rsmith, filcab, probinson, gbedwell. Herald added a subscriber: cfe-commits. NFC for targets other than PS4. Simplify users' workflow when enabling asan or ubsan and calling the linker separately. Repository: rC Clang https://revie

[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

pgousseau updated this revision to Diff 150124. pgousseau added a comment. Updated patch with requested changes. https://reviews.llvm.org/D47375 Files: lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/PS4CPU.cpp lib/Driver/ToolChains/PS4CPU.h test/Driver/fsanitize.c test/Driver/s

[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL334096: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4. (authored by pgousseau, committed by )

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1410387 , @riccibruno wrote: > I think this looks good now. Thanks ! Pushed at r354873, thanks for the help! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 _

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354873: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different… (authored by pgousseau, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5791

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. reverted at r354875 at this break lldb build. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau reopened this revision. pgousseau added a comment. This revision is now accepted and ready to land. Reopening because of buildbot failure http://green.lab.llvm.org/green/job/lldb-cmake/20537/ I have not been able to reproduce the error, the order of includes must be different on the f

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188576. pgousseau added a comment. move hash_value declaration to clang's namespace to solve lldb cmake bot build error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.t

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked an inline comment as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} riccibruno wrote: > What ? You are forward-declaring `hash_code` here and using it as a value a > few lines later.

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188748. pgousseau added a comment. Change `hash_value()` declaration's location as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sani

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} riccibruno wrote: > pgousseau wrote: > > riccibruno wrote: > > > What ? You are forward-declaring `hash_code` here

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

This revision was automatically updated to reflect the committed changes. pgousseau marked an inline comment as done. Closed by commit rL355190: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different… (authored by pgousseau, committed by ). Herald added a project: LLVM. Herald ad

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1416215 , @jyknight wrote: > The intricate initialization-order workarounds apparently don't work in all > build modes, so I've updated this code to have constexpr functions and > initializations in rL355278

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

pgousseau created this revision. pgousseau added reviewers: rsmith, filcab, wristow, gbedwell, kcc, riccibruno, probinson. Herald added subscribers: cfe-commits, jdoerfert, emaste. Herald added a project: clang. Disabled by default as this is still an experimental feature. This is the clang side

[PATCH] D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.

pgousseau created this revision. pgousseau added reviewers: probinson, filcab, gbedwell, rsmith, wristow. Herald added a project: clang. Herald added a subscriber: cfe-commits. Can be safely enabled on PS4. Repository: rC Clang https://reviews.llvm.org/D59815 Files: lib/Driver/SanitizerArg

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

pgousseau updated this revision to Diff 192447. pgousseau added a comment. Update patch to reflect changes to the llvm side of the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59221/new/ https://reviews.llvm.org/D59221 Files: include/clang/Basic/Sanitizers.def include/clang

[PATCH] D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.

pgousseau added a comment. In D59815#1442868 , @probinson wrote: > This is fine for PS4, I'm just curious whether anyone knows if there's a > predicate that means something like "target does not use GNU tools" so we > don't have to itemize Fuschia and PS

[PATCH] D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357480: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4. (authored by pgousseau, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

pgousseau added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59221/new/ https://reviews.llvm.org/D59221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358285: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and… (authored by pgousseau, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract.

pgousseau marked an inline comment as done. pgousseau added inline comments. Comment at: test/Driver/fsanitize.c:837 +// RUN: %clang -target x86_64-linux-gnu -fsanitize=pointer-compare -fno-sanitize=pointer-compare %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-NO-POINTER-CMP

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau created this revision. pgousseau added reviewers: rsmith, probinson, gbedwell, filcab, lebedev.ri, wristow. Herald added subscribers: cfe-commits, cryptoad. Herald added a project: clang. enum SanitizerOrdinal has reached maximum capacity, this change extends the capacity to 128 saniti

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 186201. pgousseau added a comment. Move num bits constant inside class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sanitizers.h include/cla

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187258. pgousseau edited the summary of this revision. pgousseau added a comment. Updated patch to not use APInt for representing the mask as it feels like a hammer solution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://review

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked an inline comment as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:43 + // Low bits of mask value. + uint64_t maskLo; + // High bits of mask value. riccibruno wrote: > Why not use a fixed size array of `ui

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187400. pgousseau added a comment. Updated to use an array as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sanitizers.def include/

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187553. pgousseau added a comment. Applied suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sanitizers.def include/clang/Basic

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked 7 inline comments as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:96 +return false; +} +return true; riccibruno wrote: > Is that vectorized by gcc/clang, or is that a sequence of branches ? c

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1404053 , @riccibruno wrote: > Wait no, can you really define the `SanitizerMask`s in the header ? Isn't > that an odr violation ? A yes I better move the definitions, thanks! CHANGES SINCE LAST ACTION https://re

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1405615 , @riccibruno wrote: > I think what you would really want to do is mark the masks as `inline > constexpr`, but sadly inline variables are C++17 only. I have seen some ways > to emulate inline variables but I a

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1405781 , @riccibruno wrote: > In D57914#1405665 , @pgousseau wrote: > > > In D57914#1405615 , @riccibruno > > wrote: > > > > > I think

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1405955 , @riccibruno wrote: > More explicitly something like: > > in `Sanitizer.h`: > > template struct SanitizerMasks { > static const SanitizerMask SomeMask; > /* and so on for each mask*/ > }; > > t

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187913. pgousseau added a comment. Fix odr violation issue using static data member of a class template as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187917. pgousseau added a comment. Rework FIXME comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.td include/clang/Basic/Sanitizers.def include/clang/Basic/Sani

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:148 +// workaround from n4424 to avoid odr issues. +// FIXME: Can be replaced by constexpr once c++14 can be used in llvm. +template struct SanitizerMasks {

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188128. pgousseau added a comment. Herald added a subscriber: jfb. Fix bad use of reference as pointed out, aliased SanitizerKind to SanitizerMasks<> instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D5791

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 188175. pgousseau added a comment. Keep `enum SanitizerOrdinal` as it was inside `SanitizerKind` namespace, fix comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 Files: include/clang/Basic/Attr.t

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:54 + static constexpr bool + checkBitPos(const SanitizerKind::SanitizerOrdinal &Pos) { +return Pos < kNumBits; riccibruno wrote: > `San

[PATCH] D55712: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or -nodefaultlibs on PS4.

pgousseau created this revision. pgousseau added reviewers: filcab, probinson, rsmith, gbedwell, dmikulin. Herald added a subscriber: cfe-commits. NFC for targets other than PS4. Respect -nostdlib and -nodefaultlibs when enabling asan or ubsan. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D55712: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or -nodefaultlibs on PS4.

pgousseau added a comment. In D55712#1334603 , @probinson wrote: > I missed that filcab had said ok internally. Go ahead Pierre. Will do! Thanks for reviewing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55712/new/ h

[PATCH] D55712: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or -nodefaultlibs on PS4.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349508: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or… (authored by pgousseau, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau created this revision. pgousseau added reviewers: craig.topper, probinson, filcab. Herald added a project: clang. Herald added a subscriber: cfe-commits. Warnings in emmintrin.h and xmmintrin.h are reported by -fsanitize=implicit-integer-sign-change Repository: rG LLVM Github Monore

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 254827. pgousseau added a comment. Renaming test and including x86intrin.h instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/Headers/xmmintrin.h

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 255626. pgousseau added a comment. Added label CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/Headers/xmmintrin.h clang/test/Headers/x86-header-warning

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: clang/test/Headers/x86-header-warnings.c:12 +void test() { + // CHECK-NOT: warning: + _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON); RKSimon wrote: > Add a LABEL check

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 255666. pgousseau added a comment. Fix false negative test introduce while attempting to add label check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau reopened this revision. pgousseau added a comment. This revision is now accepted and ready to land. Reopening to fix false negative test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 ___

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau added a comment. In D77393#1969419 , @probinson wrote: > It looks like you're not actually interested in the compiled output, but just > whether warnings occurred; in that case you'd be better off with `-verify > -fsyntax-only` and `// expected

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

pgousseau accepted this revision. pgousseau added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103953/new/ https://reviews.llvm.org/D103953