[PATCH] D88103: [JSON] Add error reporting facility, used in fromJSON and ObjectMapper.

wallace added a comment. I like this a lot!! Amazing work. I think it'll be useful for my Trace patch. I'll do a corresponding refactor using probably this new functionality. I find the diff straightforward to follow. Unless anyone has objections, I'm fine with the patch at it is. Repository:

[PATCH] D83731: Add Debug Info Size to Symbol Status

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. The logic looks very good, just some final comments and the code will be high quality Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:66

[PATCH] D83731: Add Debug Info Size to Symbol Status

wallace accepted this revision. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:65 +@skipIfWindows +@ skipUnlessDarwin +@skipIfRemote remove this whitespace Repository: rG LLVM Github

[PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:333-335 + if (section_name.startswith(".debug") || section_name.startswith("__debug")) +debug_info_size += section.GetFileByteSize(); + if (section_name.startswith(".apple") ||

[PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added a comment. @clayborg, the tests will fail on linux because the Makefile is expecting a .dsym file. I think it's okay if she does it just for Darwin and then I update the test to cover also linux, as I have my linux already well set up. Repository: rG LLVM Github Monorepo

[PATCH] D116113: Add LLDB synthetic child and summary scripts for llvm::SmallVector, llvm::Optional, llvm::ErrorOr and llvm::Expected.

wallace added a comment. thanks for doing this. Just a few minor comments and i think this is good to go Comment at: clang/utils/ClangDataFormat.py:215-218 +if self.hasVal: +result = self.value.GetIndexOfChildWithName(name) +return None if