[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06d4a76309cd: [NFC][AIX]Disable precompiled module file tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114481/new/ https://reviews.llvm.org/D114481 Files: clang/test/ClangScanDeps/modules-pch-common-submodule.c clang/test/ClangScanDeps/modules-pch-common-via-submodule.c clang/test/ClangScanDeps/modules-pch.c clang/test/PCH/debug-info-pch-path.c Index: clang/test/PCH/debug-info-pch-path.c === --- clang/test/PCH/debug-info-pch-path.c +++ clang/test/PCH/debug-info-pch-path.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // RUN: rm -rf %t // RUN: mkdir %t // RUN: cd %t Index: clang/test/ClangScanDeps/modules-pch.c === --- clang/test/ClangScanDeps/modules-pch.c +++ clang/test/ClangScanDeps/modules-pch.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // RUN: rm -rf %t && mkdir %t // RUN: cp %S/Inputs/modules-pch/* %t Index: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-via-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-via-submodule.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // Check that we discover dependency on a precompiled module (and generate the // appropriate `-fmodule-file=` argument) when it's imported by a **submodule** // instead of a top-level module. Index: clang/test/ClangScanDeps/modules-pch-common-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-submodule.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // Check that when depending on a precompiled module, we depend on the // **top-level** module. Submodules don't have some information present (for // example the path to the modulemap file) and depending on them might cause Index: clang/test/PCH/debug-info-pch-path.c === --- clang/test/PCH/debug-info-pch-path.c +++ clang/test/PCH/debug-info-pch-path.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // RUN: rm -rf %t // RUN: mkdir %t // RUN: cd %t Index: clang/test/ClangScanDeps/modules-pch.c === --- clang/test/ClangScanDeps/modules-pch.c +++ clang/test/ClangScanDeps/modules-pch.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // RUN: rm -rf %t && mkdir %t // RUN: cp %S/Inputs/modules-pch/* %t Index: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-via-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-via-submodule.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // Check that we discover dependency on a precompiled module (and generate the // appropriate `-fmodule-file=` argument) when it's imported by a **submodule** // instead of a top-level module. Index: clang/test/ClangScanDeps/modules-pch-common-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-submodule.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // Check that when depending on a precompiled module, we depend on the // **top-level** module. Submodules don't have some information present (for // example the path to the modulemap file) and depending on them might cause ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX
stevewan updated this revision to Diff 389535. stevewan added a comment. Explain the rationale Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114481/new/ https://reviews.llvm.org/D114481 Files: clang/test/ClangScanDeps/modules-pch-common-submodule.c clang/test/ClangScanDeps/modules-pch-common-via-submodule.c clang/test/ClangScanDeps/modules-pch.c clang/test/PCH/debug-info-pch-path.c Index: clang/test/PCH/debug-info-pch-path.c === --- clang/test/PCH/debug-info-pch-path.c +++ clang/test/PCH/debug-info-pch-path.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // RUN: rm -rf %t // RUN: mkdir %t // RUN: cd %t Index: clang/test/ClangScanDeps/modules-pch.c === --- clang/test/ClangScanDeps/modules-pch.c +++ clang/test/ClangScanDeps/modules-pch.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // RUN: rm -rf %t && mkdir %t // RUN: cp %S/Inputs/modules-pch/* %t Index: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-via-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-via-submodule.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // Check that we discover dependency on a precompiled module (and generate the // appropriate `-fmodule-file=` argument) when it's imported by a **submodule** // instead of a top-level module. Index: clang/test/ClangScanDeps/modules-pch-common-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-submodule.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // Check that when depending on a precompiled module, we depend on the // **top-level** module. Submodules don't have some information present (for // example the path to the modulemap file) and depending on them might cause Index: clang/test/PCH/debug-info-pch-path.c === --- clang/test/PCH/debug-info-pch-path.c +++ clang/test/PCH/debug-info-pch-path.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // RUN: rm -rf %t // RUN: mkdir %t // RUN: cd %t Index: clang/test/ClangScanDeps/modules-pch.c === --- clang/test/ClangScanDeps/modules-pch.c +++ clang/test/ClangScanDeps/modules-pch.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // RUN: rm -rf %t && mkdir %t // RUN: cp %S/Inputs/modules-pch/* %t Index: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-via-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-via-submodule.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // Check that we discover dependency on a precompiled module (and generate the // appropriate `-fmodule-file=` argument) when it's imported by a **submodule** // instead of a top-level module. Index: clang/test/ClangScanDeps/modules-pch-common-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-submodule.c @@ -1,3 +1,7 @@ +// Unsupported on AIX because we don't support the requisite "__clangast" +// section in XCOFF yet. +// UNSUPPORTED: aix + // Check that when depending on a precompiled module, we depend on the // **top-level** module. Submodules don't have some information present (for // example the path to the modulemap file) and depending on them might cause ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor nit. Comment at: clang/test/ClangScanDeps/modules-pch-common-submodule.c:1 +// UNSUPPORTED: aix + Let's add a comment, to let folks know what's going on with these. Something like: // Unsupported on AIX because we don't support the requisite __clangast section in XCOFF yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114481/new/ https://reviews.llvm.org/D114481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX
stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The PCH reader looks for `__clangast` section in the precompiled module file, which is not present in the file on AIX, and we don't support writing this custom section in XCOFF yet. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114481 Files: clang/test/ClangScanDeps/modules-pch-common-submodule.c clang/test/ClangScanDeps/modules-pch-common-via-submodule.c clang/test/ClangScanDeps/modules-pch.c clang/test/PCH/debug-info-pch-path.c Index: clang/test/PCH/debug-info-pch-path.c === --- clang/test/PCH/debug-info-pch-path.c +++ clang/test/PCH/debug-info-pch-path.c @@ -1,3 +1,5 @@ +// UNSUPPORTED: aix + // RUN: rm -rf %t // RUN: mkdir %t // RUN: cd %t Index: clang/test/ClangScanDeps/modules-pch.c === --- clang/test/ClangScanDeps/modules-pch.c +++ clang/test/ClangScanDeps/modules-pch.c @@ -1,3 +1,5 @@ +// UNSUPPORTED: aix + // RUN: rm -rf %t && mkdir %t // RUN: cp %S/Inputs/modules-pch/* %t Index: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-via-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-via-submodule.c @@ -1,3 +1,5 @@ +// UNSUPPORTED: aix + // Check that we discover dependency on a precompiled module (and generate the // appropriate `-fmodule-file=` argument) when it's imported by a **submodule** // instead of a top-level module. Index: clang/test/ClangScanDeps/modules-pch-common-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-submodule.c @@ -1,3 +1,5 @@ +// UNSUPPORTED: aix + // Check that when depending on a precompiled module, we depend on the // **top-level** module. Submodules don't have some information present (for // example the path to the modulemap file) and depending on them might cause Index: clang/test/PCH/debug-info-pch-path.c === --- clang/test/PCH/debug-info-pch-path.c +++ clang/test/PCH/debug-info-pch-path.c @@ -1,3 +1,5 @@ +// UNSUPPORTED: aix + // RUN: rm -rf %t // RUN: mkdir %t // RUN: cd %t Index: clang/test/ClangScanDeps/modules-pch.c === --- clang/test/ClangScanDeps/modules-pch.c +++ clang/test/ClangScanDeps/modules-pch.c @@ -1,3 +1,5 @@ +// UNSUPPORTED: aix + // RUN: rm -rf %t && mkdir %t // RUN: cp %S/Inputs/modules-pch/* %t Index: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-via-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-via-submodule.c @@ -1,3 +1,5 @@ +// UNSUPPORTED: aix + // Check that we discover dependency on a precompiled module (and generate the // appropriate `-fmodule-file=` argument) when it's imported by a **submodule** // instead of a top-level module. Index: clang/test/ClangScanDeps/modules-pch-common-submodule.c === --- clang/test/ClangScanDeps/modules-pch-common-submodule.c +++ clang/test/ClangScanDeps/modules-pch-common-submodule.c @@ -1,3 +1,5 @@ +// UNSUPPORTED: aix + // Check that when depending on a precompiled module, we depend on the // **top-level** module. Submodules don't have some information present (for // example the path to the modulemap file) and depending on them might cause ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
