kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116326/new/
https://reviews.llvm.org/D116326
sammccall updated this revision to Diff 397251.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116326/new/
https://reviews.llvm.org/D116326
Files:
sammccall marked 11 inline comments as done.
sammccall added inline comments.
Comment at: clang/lib/Sema/CodeCompleteConsumer.cpp:568
+
+ if (const auto *FD = getFunction()) {
+if (N < FD->param_size())
kadircet wrote:
> this doesn't cover the
kadircet added inline comments.
Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:1085
+const RecordDecl *getAggregate() const {
+ return getKind() == CK_Aggregate ? AggregateType : nullptr;
+}
either assert the kind and return
usaxena95 added inline comments.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3699
+ unsigned ChunkIndex = 0;
+ auto AddChunk = [&](std::string Placeholder) {
+if (ChunkIndex > 0)
nit: const ref.
Comment at:
sammccall updated this revision to Diff 397075.
sammccall marked an inline comment as done.
sammccall added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116326/new/
https://reviews.llvm.org/D116326
Files:
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1184
- auto Name = Ident->getName();
- if (!Name.empty())
-ParamNames.insert(Name.str());
kadircet wrote:
> we
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1184
- auto Name = Ident->getName();
- if (!Name.empty())
-ParamNames.insert(Name.str());
we were never recording unnamed params before, now they'll be
sammccall created this revision.
sammccall added reviewers: kadircet, usaxena95.
Herald added a subscriber: arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
The "parameter list" is the
