[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

2023-03-22 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. How does this check interact with macros that expand to `if` statements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https://reviews.llvm.org/D130630

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

2022-08-03 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 449621. njames93 added a comment. Handle cases where the fix is incorrect due to operator precedence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https://reviews.llvm.org/D130630 Files:

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

2022-07-27 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 448172. njames93 added a comment. Fix typo in test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https://reviews.llvm.org/D130630 Files:

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

2022-07-27 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 448064. njames93 marked an inline comment as done. njames93 added a comment. Remove Excessive Newline. Hopefully fix the windows test failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

2022-07-27 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/nested-ifs.rst:58 + } + Excessive newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

2022-07-27 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.