This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa8efcb96e6db: [AVR][Clang] Implement __AVR_HAVE_*__ macros
(authored by aykevl).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
benshi001 accepted this revision.
benshi001 added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/Basic/Targets/AVR.cpp:355
+.Cases("31", "51", "6", true)
+.Cases("104", "105", "106", "107", true)
+.Default(false);
aykevl added inline comments.
Comment at: clang/lib/Basic/Targets/AVR.cpp:355
+.Cases("31", "51", "6", true)
+.Cases("104", "105", "106", "107", true)
+.Default(false);
benshi001 wrote:
> benshi001 wrote:
> > ATxmega16a4 with family code 102 also
aykevl updated this revision to Diff 475419.
aykevl added a comment.
- Fix ArchHas3BytePC to remove arch 107 (of which no chips have more than 128kB
flash)
- Fix ArchHasELPM/ArchHasELPMX to add arch 102 (it does support elpm even
though avr-gcc claims it doesn't).
- Add notes where the provided
benshi001 added inline comments.
Comment at: clang/lib/Basic/Targets/AVR.cpp:355
+.Cases("31", "51", "6", true)
+.Cases("104", "105", "106", "107", true)
+.Default(false);
benshi001 wrote:
> ATxmega16a4 with family code 102 also supports ELPM. Could
benshi001 added inline comments.
Comment at: clang/lib/Basic/Targets/AVR.cpp:355
+.Cases("31", "51", "6", true)
+.Cases("104", "105", "106", "107", true)
+.Default(false);
ATxmega16a4 with family code 102 also supports ELPM. Could you please make a
aykevl created this revision.
aykevl added reviewers: benshi001, dylanmckay.
Herald added a subscriber: Jim.
Herald added a project: All.
aykevl requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
These macros are defined in avr-gcc and are
