[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c9db34a9b0: PR58819: Correct linkage and mangling of lambdas in inline static member… (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

efriedma accepted this revision as: efriedma. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/ https://reviews.llvm.org/D138247

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. In D138247#4217189 , @efriedma wrote: > The relevant text of the current Itanium ABI (which was updated in > https://github.com/itanium-cxx-abi/cxx-abi/commit/d8e9d102c83f177970f0db6cc8bee170f2779bc1) > >> In the following

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie updated this revision to Diff 508847. dblaikie added a comment. Rename VariableTemplate classification to TemplatedVariable to match ABI wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/ https://reviews.llvm.org/D138247

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie updated this revision to Diff 508842. dblaikie added a comment. Remove `StaticDataMember` and classify static member variables of templates as variable templates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

efriedma added a comment. The relevant text of the current Itanium ABI (which was updated in https://github.com/itanium-cxx-abi/cxx-abi/commit/d8e9d102c83f177970f0db6cc8bee170f2779bc1) > In the following contexts, however, the one-definition rule requires closure > types in different

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138247/new/ https://reviews.llvm.org/D138247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. GCC bug hasn't got much traction, so I pinged it. But probably still the right thing to continue with this fix, I think. @rjmccall Could you give a quick glance/confirm my ABI understanding/diagnosis/direction here? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. In D138247#3942744 , @mgorny wrote: > From Gentoo perspective, correct is better, correct and matching GCC is the > best (we support mixing compilers to some degree). I think it'd be best to > wait for confirmation on GCC end.

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

mgorny added a comment. From Gentoo perspective, correct is better, correct and matching GCC is the best (we support mixing compilers to some degree). I think it'd be best to wait for confirmation on GCC end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie added a comment. In D138247#3936928 , @probinson wrote: > If this is specifically for C++17, I believe Sony doesn't officially support > that yet although I am checking. Cool, thanks! > It looks like this is only part of the fix for #58819?

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

probinson added a comment. If this is specifically for C++17, I believe Sony doesn't officially support that yet although I am checking. It looks like this is only part of the fix for #58819? The original report also had a `static int n` with an internal-linkage name. Repository: rG LLVM

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie created this revision. dblaikie added reviewers: clang-vendors, rsmith, probinson, rjmccall. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://llvm.org/pr58819 - clang is giving an