This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGea064ee2a3bd: [AMDGPU] Create Subtarget Features for some of
16 bits atomic fadd instructions (authored by mariusz-sikora-at-amd).
Repository:
rG
foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
If you want to remove some of the other unnecessary predicates from Real
instructions you could do that in a separate NFC patch.
Repository:
rG LLVM Github Monorepo
CHANGES
mariusz-sikora-at-amd updated this revision to Diff 507871.
mariusz-sikora-at-amd added a comment.
Put back Real Instructions under SubtargetPredicate associated with gfx
generation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146701/new/
mariusz-sikora-at-amd added inline comments.
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:1915
+defm GLOBAL_ATOMIC_PK_ADD_F16 : FLAT_Global_Real_Atomics_vi <0x04e, 0>;
+defm GLOBAL_ATOMIC_PK_ADD_BF16 : FLAT_Global_Real_Atomics_vi<0x52>;
foad wrote:
>
foad added inline comments.
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:2891
+let SubtargetPredicate = HasAtomicFaddNoRtnInsts in {
+defm BUFFER_ATOMIC_ADD_F32: MUBUF_Real_Atomic_vi <0x4d>;
mariusz-sikora-at-amd wrote:
> foad wrote:
> > Is this
mariusz-sikora-at-amd added inline comments.
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:2891
+let SubtargetPredicate = HasAtomicFaddNoRtnInsts in {
+defm BUFFER_ATOMIC_ADD_F32: MUBUF_Real_Atomic_vi <0x4d>;
foad wrote:
> Is this still required?
mariusz-sikora-at-amd added inline comments.
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:1915
+defm GLOBAL_ATOMIC_PK_ADD_F16 : FLAT_Global_Real_Atomics_vi <0x04e, 0>;
+defm GLOBAL_ATOMIC_PK_ADD_BF16 : FLAT_Global_Real_Atomics_vi<0x52>;
foad wrote:
>
foad added inline comments.
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:2891
+let SubtargetPredicate = HasAtomicFaddNoRtnInsts in {
+defm BUFFER_ATOMIC_ADD_F32: MUBUF_Real_Atomic_vi <0x4d>;
Is this still required?
Comment at:
mariusz-sikora-at-amd updated this revision to Diff 507722.
mariusz-sikora-at-amd added a comment.
Changes after review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146701/new/
https://reviews.llvm.org/D146701
Files:
foad added inline comments.
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:2889
-defm BUFFER_ATOMIC_ADD_F32: MUBUF_Real_Atomic_vi <0x4d>;
+let SubtargetPredicate = HasAtomicBufferGlobalPkAddF16NoRtnInsts in {
defm BUFFER_ATOMIC_PK_ADD_F16 : MUBUF_Real_Atomic_vi
mariusz-sikora-at-amd added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:233
+TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2bf16, "V2sV2s*1V2s", "t",
"atomic-global-pk-add-bf16-inst")
+TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_v2bf16,
foad added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:233
+TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2bf16, "V2sV2s*1V2s", "t",
"atomic-global-pk-add-bf16-inst")
+TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_v2bf16, "V2sV2s*3V2s", "t",
mariusz-sikora-at-amd created this revision.
Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard,
yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
mariusz-sikora-at-amd requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits,
13 matches
Mail list logo