[PATCH] D146733: [clang] source range of variable template specialization should include initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa826b9034bbd: [clang] source range of variable template specialization should include… (authored by tomasz-kaminski-sonarsource). Repository: rG

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource added a comment. In D146733#4219448 , @erichkeane wrote: > LGTM! Let me know if you need someone to commit this for you, and include > "Name To Use " I have commit rights, but I will not be able to commit this before

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 508105. tomasz-kaminski-sonarsource added a comment. Rebasing on test commit. My applogies for noise, I still get confused with arc sometimes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM! Let me know if you need someone to commit this for you, and include "Name To Use " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 508081. tomasz-kaminski-sonarsource added a comment. Updated release note to be more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:228 antecipation of `CWG2563 _`. +- Fix ``getSourceRange`` behavior on ``VarTemplateSpecializationDecl`` + and

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 508077. tomasz-kaminski-sonarsource added a comment. Including release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733 Files:

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane added a comment. Test looks fine, still need a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733 ___ cfe-commits mailing list

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 507975. tomasz-kaminski-sonarsource added a comment. Adding tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733 Files:

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource added a comment. I have updated the description and implementation. Will look at adding a unit test tomorrow. Comment at: clang/lib/AST/DeclTemplate.cpp:1467 +SourceRange VarTemplatePartialSpecializationDecl::getSourceRange() const { + if (const

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 507784. tomasz-kaminski-sonarsource edited the summary of this revision. tomasz-kaminski-sonarsource added a comment. Simpified condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane added a comment. Just noticed your commit-notice reference to the 'breaking' change is incorrect, should be: https://reviews.llvm.org/D139705 As for the test, an AST-Dump test has the line/column info in it, so that should be a good enough test. Repository: rG LLVM Github

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource added a comment. In D146733#4216931 , @erichkeane wrote: > This needs a test and a release note. Patch otherwise looks fine to me. Do you have any pointers for a test of source ranges? The patch that caused regression used

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:1467 +SourceRange VarTemplatePartialSpecializationDecl::getSourceRange() const { + if (const Expr *Init = getInit()) { +SourceLocation InitEnd = Init->getEndLoc(); Looking

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource updated this revision to Diff 507776. tomasz-kaminski-sonarsource added a comment. Comments no longer misleading reffer to fallback to DeclatorDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

erichkeane added a comment. This needs a test and a release note. Patch otherwise looks fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146733/new/ https://reviews.llvm.org/D146733 ___

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

tomasz-kaminski-sonarsource created this revision. Herald added a project: All. tomasz-kaminski-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adjust the getSourceRange() for the VarTemplateSpecializationDecl and