[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGb321738f7125: [clang][parser] Fix namespace dropping after malformed declarations (authored by alejandro-alvarez-sonarsource, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

alejandro-alvarez-sonarsource added a comment. In D150258#4337880 , @aaron.ballman wrote: > LGTM! Do you need me to commit on your behalf? If so, what name and email > address would you like used for patch attribution? Thanks a lot! And yes, I would

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like used for patch attribution? Comment at:

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

alejandro-alvarez-sonarsource added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2306-2310 // Otherwise things are very confused and we skip to recover. if (!isDeclarationSpecifier(ImplicitTypenameContext::No)) { - SkipUntil(tok::r_brace, StopAtSemi

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

alejandro-alvarez-sonarsource updated this revision to Diff 521625. alejandro-alvarez-sonarsource added a comment. Applied suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150258/new/ https://reviews.llvm.org/D150258 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

aaron.ballman added a comment. Thank you for working on this! FWIW, I verified that the precommit CI failures are unrelated to this patch. Can you add a release note to `clang/docs/ReleaseNotes.rst` about the fix? Comment at: clang/lib/Parse/ParseDecl.cpp:2179-2180 -

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

alejandro-alvarez-sonarsource created this revision. alejandro-alvarez-sonarsource added a reviewer: aaron.ballman. alejandro-alvarez-sonarsource added a project: clang. Herald added a subscriber: kadircet. Herald added a project: All. alejandro-alvarez-sonarsource requested review of this