[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

2023-05-19 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4e935240f02: [clang][AST] Propagate the value-dependent bit for VAArgExpr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

2023-05-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks for the review. In D150955#4356580 , @aaron.ballman wrote: > LGTM assuming CI is okay with it -- the patch did not apply so precommit CI > never ran. I'm surprised no tests break as a result of this because it > changes

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

2023-05-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 523875. hokein added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150955/new/ https://reviews.llvm.org/D150955 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

2023-05-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming CI is okay with it -- the patch did not apply so precommit CI never ran. I'm surprised no tests break as a result of this because it changes both C and C++

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

2023-05-19 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/62711 We never set the value-dependent bit for the VAArgExpr before this