[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd06b92391513: [clang-format] Fix a bug that wraps before function arguments (authored by jp4a50, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 marked an inline comment as done. jp4a50 added a comment. @owenpan right you are! Missed those somehow. Made a further two changes. Hope I haven't missed anything else! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 552701. jp4a50 added a comment. Minor refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

owenpan added a comment. In D156259#4607177 , @jp4a50 wrote: > Addressed all comments. Please let me know if there's anything else required > before merging. There are still a couple of comments unaddressed plus another that asked for changing `!is()`

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 marked 4 inline comments as done. jp4a50 added a comment. Addressed all comments. Please let me know if there's anything else required before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 552403. jp4a50 added a comment. Minor refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 552401. jp4a50 added a comment. Minor refactoring and comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

owenpan added inline comments. Comment at: clang/docs/ReleaseNotes.rst:167-168 +- Fix a bug that erroneously placed function arguments on a new line despite +all arguments being able to fit on the same line. Please delete it. We only update the

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

HazardyKnusperkeks added a comment. In D156259#4558570 , @jp4a50 wrote: > @HazardyKnusperkeks could you merge this for me assuming the build is green > please? I don't have merge rights. Thanks. That will have to wait, but if no one else stepped in,

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 added a comment. @HazardyKnusperkeks could you merge this for me assuming the build is green please? I don't have merge rights. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 546972. jp4a50 added a comment. Format files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 updated this revision to Diff 546002. jp4a50 added a comment. More CR feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156259/new/ https://reviews.llvm.org/D156259 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

jp4a50 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:657-666 + bool DisallowLineBreaksOnThisLine = [ = this->Style, ] { +// Deal with lambda arguments in C++. The aim here is to ensure that we +// don't over-indent lambda function bodies