[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

This revision was automatically updated to reflect the committed changes. yronglin marked 2 inline comments as done. Closed by commit rGa2132d72bed1: [Clang] Fix the do while statement disappearing in AST when an error occurs in… (authored by yronglin). Repository: rG LLVM Github Monorepo

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

yronglin marked 2 inline comments as done. yronglin added a comment. Thanks for your review! @hokein @tbaeder Comment at: clang/lib/Parse/ParseStmt.cpp:1897-1898 if (Cond.isUsable()) -Cond = Actions.CorrectDelayedTyposInExpr(Cond); +Cond =

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

yronglin updated this revision to Diff 547712. yronglin added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157195/new/ https://reviews.llvm.org/D157195 Files: clang/lib/Parse/ParseStmt.cpp

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1897-1898 if (Cond.isUsable()) -Cond = Actions.CorrectDelayedTyposInExpr(Cond); +Cond = Actions.CorrectDelayedTyposInExpr(Cond, /*InitDecl*/ nullptr, +

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang/test/SemaCXX/constexpr-function-recovery-crash.cpp:81 +constexpr int test13() { do {} while (a < 10); return 0; } // expected-error

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yrong Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157195 Files: