This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG39a41c890561: [CGCall][RISCV] Handle function calls with
parameter of RVV tuple type (authored by eopXD).
Repository:
rG LLVM Github Monorepo
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157953/new/
https://reviews.llvm.org/D157953
eopXD updated this revision to Diff 551919.
eopXD marked 2 inline comments as done.
eopXD added a comment.
Address comments from Craig.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157953/new/
https://reviews.llvm.org/D157953
Files:
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:5278
+ for (unsigned i = 0, e = STy->getNumElements(); i != e; ++i) {
+llvm::Value *LI = Builder.CreateExtractValue(
+StoredStructValue, i, Src.getName() +
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:5268
+ assert(STy->containsHomogeneousScalableVectorTypes() &&
+ "ABI only supports structure with hmogeneous scalable vector "
+ "type");
kito-cheng added a comment.
Herald added a subscriber: sunshaoce.
LGTM, but I would like to wait few more days to make sure no other comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157953/new/
https://reviews.llvm.org/D157953
