[PATCH] D158402: [Clang][RISCV] Add vcreate intrinsics for RVV tuple types

2023-08-21 Thread Jim Lin via Phabricator via cfe-commits 
Jim added inline comments.



Comment at: clang/include/clang/Basic/riscv_vector.td:2833
   }
+  let Name = "vcreate_v",
+  UnMaskedPolicyScheme = NonePolicy,

Can we add a blank line before this.



Comment at: clang/include/clang/Basic/riscv_vector.td:2848
+  }] in {
+// foreach type = TypeList in {
+  foreach nf = NFList in {

Does this forget to be removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158402/new/

https://reviews.llvm.org/D158402

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158402: [Clang][RISCV] Add vcreate intrinsics for RVV tuple types

2023-08-21 Thread Craig Topper via Phabricator via cfe-commits 
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158402/new/

https://reviews.llvm.org/D158402

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits