m.ostapenko updated this revision to Diff 129985.
m.ostapenko added a comment.
Hi Devin,
now I'm very sorry for a such long delay. Now I have a bunch of time to proceed
development of this patch (if scope contexts are still needed, of course).
Regarding to approach you suggested (reuse
dcoughlin added a comment.
Maxim, thanks for commandeering the patch. I apologize for the long delay
reviewing!
I really like the approach of retrying without scopes enabled when we hit a
construct we can't handle yet. This will make is possible to turn the feature
on by default (and get it
m.ostapenko updated this revision to Diff 112547.
m.ostapenko added a comment.
Ping^4
Repository:
rL LLVM
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CFG.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
m.ostapenko updated this revision to Diff 111322.
m.ostapenko added a comment.
Ping^3
Repository:
rL LLVM
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CFG.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
m.ostapenko updated this revision to Diff 110329.
m.ostapenko added a comment.
Rebased and ping.
Repository:
rL LLVM
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CFG.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
m.ostapenko updated this revision to Diff 108644.
m.ostapenko added a comment.
Updated some comments. Could someone take a look please?
Repository:
rL LLVM
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisContext.h
include/clang/Analysis/CFG.h
m.ostapenko updated this revision to Diff 107894.
m.ostapenko added a comment.
Rebased and removed a bunch of stale changes. Also added a check for goto's: if
we see GotoStmt and have cfg-scopes == true, make badCFG = true and retry
without scopes enabled. This check will be removed once
m.ostapenko added a comment.
In https://reviews.llvm.org/D16403#808104, @NoQ wrote:
> I think the remaining switch-related code seems to be about C++17 switch
> condition variables, i.e. `switch (int x = ...)`(?)
Yeah, exactly. I can remove it from this patch if it looks confusing.
NoQ added a comment.
I think the remaining switch-related code seems to be about C++17 switch
condition variables, i.e. `switch (int x = ...)`(?)
Repository:
rL LLVM
https://reviews.llvm.org/D16403
___
cfe-commits mailing list
szepet added a comment.
Hello Maxim!
Thanks for working on this!
> Ugh, yeah, SwitchStmt is tricky (thank you for pointing to Duff's device
> example!). I've tried to resolve several issues with switch revealed by this
> testcase, but didn't succeed for now :(. So, it was decided to remove
>
m.ostapenko updated this revision to Diff 106408.
m.ostapenko retitled this revision from "Add scope information to CFG" to "Add
scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements".
m.ostapenko added a comment.
Updating the diff. I've dropped SwitchStmt support, let's
11 matches
Mail list logo
