This revision was automatically updated to reflect the committed changes.
Closed by commit rL284256: Link static PIE programs against rcrt0.o on OpenBSD
(authored by emaste).
Changed prior to commit:
https://reviews.llvm.org/D22130?vs=68046&id=74718#toc
Repository:
rL LLVM
https://reviews.l
On 09/10/16 05:27, Stefan Kempf via cfe-commits wrote:
Ed Maste wrote:
emaste added a comment.
Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's
toolchain.
Could you commit it please if it looks ok? This diff is what OpenBSD has
in its tree. We'd like to get it upstrea
Ed Maste wrote:
> emaste added a comment.
>
> Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's
> toolchain.
Could you commit it please if it looks ok? This diff is what OpenBSD has
in its tree. We'd like to get it upstream.
> https://reviews.llvm.org/D22130
>
>
>
__
emaste added a comment.
Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's
toolchain.
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
vsk resigned from this revision.
vsk removed a reviewer: vsk.
vsk added a comment.
I don't see any issues with this patch, but also don't know enough about the
openbsd toolchain to lgtm it.
https://reviews.llvm.org/D22130
___
cfe-commits mailing li
sisnkemp added a comment.
Ping?
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sisnkemp updated this revision to Diff 68046.
sisnkemp added a comment.
Now with test case.
https://reviews.llvm.org/D22130
Files:
lib/Driver/Tools.cpp
test/Driver/openbsd.c
Index: test/Driver/openbsd.c
===
--- test/Driver/ope
joerg added a comment.
This is missing a test case.
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sisnkemp added a comment.
Ping?
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sisnkemp created this revision.
sisnkemp added a reviewer: rafael.
sisnkemp added a subscriber: cfe-commits.
When building a static PIE binary, linking against /usr/lib/crt0.o results in
segfaults when trying to run the binary.
Static PIE programs must link against /usr/lib/rcrt0.o instead to run
10 matches
Mail list logo
