[PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

[John Brawn via Phabricator via cfe-commits]

john.brawn abandoned this revision.
john.brawn added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Abandoning this old obsolete patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D1/new/

https://reviews.llvm.org/D1



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

[Ehsan Akhgari via cfe-commits]

ehsan resigned from this revision.
ehsan removed a reviewer: ehsan.
ehsan added a comment.

I also don't know enough about the build system to review this, sorry!


Repository:
  rL LLVM

https://reviews.llvm.org/D1



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

[Philip Reames via cfe-commits]

reames resigned from this revision.
reames removed a reviewer: reames.
reames added a comment.

I know very little about our cmake infrastructure.


Repository:
  rL LLVM

https://reviews.llvm.org/D1



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

[John Brawn via cfe-commits]

john.brawn added a comment.

Ping.


Repository:
  rL LLVM

https://reviews.llvm.org/D1



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

[John Brawn via cfe-commits]

john.brawn created this revision.
john.brawn added reviewers: ehsan, reames, chapuni, Ilod.
john.brawn added a subscriber: cfe-commits.
john.brawn set the repository for this revision to rL LLVM.

Clang plugins work when either LLVM_ENABLE_PLUGINS or 
LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON, so enable the 'plugins' test feature 
when that is the case.


Repository:
  rL LLVM

http://reviews.llvm.org/D1

Files:
  test/lit.cfg
  test/lit.site.cfg.in

Index: test/lit.site.cfg.in
===
--- test/lit.site.cfg.in
+++ test/lit.site.cfg.in
@@ -7,6 +7,8 @@
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
 config.llvm_libs_dir = "@LLVM_LIBS_DIR@"
 config.llvm_shlib_dir = "@SHLIBDIR@"
+config.llvm_enable_plugins = "@LLVM_ENABLE_PLUGINS@"
+config.llvm_export_symbols_for_plugins = "@LLVM_EXPORT_SYMBOLS_FOR_PLUGINS@"
 config.llvm_plugin_ext = "@LLVM_PLUGIN_EXT@"
 config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
 config.clang_obj_root = "@CLANG_BINARY_DIR@"
Index: test/lit.cfg
===
--- test/lit.cfg
+++ test/lit.cfg
@@ -195,12 +195,8 @@
 lit_config.note('using clang: %r' % config.clang)
 
 # Plugins (loadable modules)
-# TODO: This should be supplied by Makefile or autoconf.
-if sys.platform in ['win32', 'cygwin']:
-has_plugins = (config.enable_shared == 1)
-else:
-has_plugins = True
-
+has_plugins = (config.llvm_enable_plugins == "ON" or
+   config.llvm_export_symbols_for_plugins == "ON")
 if has_plugins and config.llvm_plugin_ext:
 config.available_features.add('plugins')
 


Index: test/lit.site.cfg.in
===
--- test/lit.site.cfg.in
+++ test/lit.site.cfg.in
@@ -7,6 +7,8 @@
 config.llvm_tools_dir = "@LLVM_TOOLS_DIR@"
 config.llvm_libs_dir = "@LLVM_LIBS_DIR@"
 config.llvm_shlib_dir = "@SHLIBDIR@"
+config.llvm_enable_plugins = "@LLVM_ENABLE_PLUGINS@"
+config.llvm_export_symbols_for_plugins = "@LLVM_EXPORT_SYMBOLS_FOR_PLUGINS@"
 config.llvm_plugin_ext = "@LLVM_PLUGIN_EXT@"
 config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
 config.clang_obj_root = "@CLANG_BINARY_DIR@"
Index: test/lit.cfg
===
--- test/lit.cfg
+++ test/lit.cfg
@@ -195,12 +195,8 @@
 lit_config.note('using clang: %r' % config.clang)
 
 # Plugins (loadable modules)
-# TODO: This should be supplied by Makefile or autoconf.
-if sys.platform in ['win32', 'cygwin']:
-has_plugins = (config.enable_shared == 1)
-else:
-has_plugins = True
-
+has_plugins = (config.llvm_enable_plugins == "ON" or
+   config.llvm_export_symbols_for_plugins == "ON")
 if has_plugins and config.llvm_plugin_ext:
 config.available_features.add('plugins')
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits