ayartsev closed this revision.
ayartsev added a comment.
Closed by r283499.
https://reviews.llvm.org/D22494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
LGTM. Thanks.
https://reviews.llvm.org/D22494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev updated this revision to Diff 71056.
ayartsev added a comment.
Updated the patch. Important change in Options.td was missing in the last patch
+ indentation fixed.
Still Ok to commit?
https://reviews.llvm.org/D22494
Files:
include/clang/Driver/Options.td
lib/StaticAnalyzer/Core/Pa
ayartsev updated this revision to Diff 70772.
ayartsev added a comment.
Updated the patch, added help entry for the "--analyzer-output" driver option.
Please review.
https://reviews.llvm.org/D22494
Files:
lib/StaticAnalyzer/Core/PathDiagnostic.cpp
test/Analysis/diagnostics/diag-cross-file-
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216
@@ +215,3 @@
+llvm::raw_svector_ostream warning(buf);
+warning << "warning: Path diagnostic report is not generated. Current "
+<< "output format does not support diagnos
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216
@@ +215,3 @@
+llvm::raw_svector_ostream warning(buf);
+warning << "warning: Path diagnostic report is not generated. Current "
+<< "output format does not support diagno
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216
@@ +215,3 @@
+llvm::raw_svector_ostream warning(buf);
+warning << "warning: Path diagnostic report is not generated. Current "
+<< "output format does not support diagnos
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216
@@ +215,3 @@
+llvm::raw_svector_ostream warning(buf);
+warning << "warning: Path diagnostic report is not generated. Current "
+<< "output format does not support diagno
ayartsev added a comment.
Gentle ping.
https://reviews.llvm.org/D22494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev added a comment.
Ping.
https://reviews.llvm.org/D22494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216
@@ +215,3 @@
+llvm::raw_svector_ostream warning(buf);
+warning << "warning: Path diagnostic report is not generated. Current "
+<< "output format does not support diagnos
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216
@@ +215,3 @@
+llvm::raw_svector_ostream warning(buf);
+warning << "warning: Path diagnostic report is not generated. Current "
+<< "output format does not support diagno
ayartsev added inline comments.
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics
does not support diagnostics that cross file boundaries.
zaks.anna wrote:
> ayartsev wrote:
> > zaks.
zaks.anna added inline comments.
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics
does not support diagnostics that cross file boundaries.
ayartsev wrote:
> zaks.anna wrote:
> > We s
ayartsev updated this revision to Diff 65519.
ayartsev marked 2 inline comments as done.
https://reviews.llvm.org/D22494
Files:
lib/StaticAnalyzer/Core/PathDiagnostic.cpp
test/Analysis/diagnostics/diag-cross-file-boundaries.c
test/Analysis/diagnostics/diag-cross-file-boundaries.h
Index: te
ayartsev added inline comments.
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics
does not support diagnostics that cross file boundaries.
zaks.anna wrote:
> We should use the name of
zaks.anna added inline comments.
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics
does not support diagnostics that cross file boundaries.
We should use the name of the diagnostic co
ayartsev created this revision.
ayartsev added reviewers: zaks.anna, dcoughlin.
ayartsev added a subscriber: cfe-commits.
Hi all,
Currently if the path diagnostic consumer (e.g HTMLDiagnostics and
PlistDiagnostics) do not support cross file diagnostics then the path
diagnostic report is just si
18 matches
Mail list logo
