Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

2016-09-19 Thread Yaxun Liu via cfe-commits
yaxunl marked 6 inline comments as done. Comment at: lib/Sema/SemaDecl.cpp:7600 @@ +7599,3 @@ +// Do not diagnose half type since it is diagnosed as invalid argument +// type for any function eleswhere. +if (!PT->isHalfType()) Anastasia wrote: > ->

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

2016-09-19 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7599-7602 @@ -7595,3 +7598,6 @@ // of event_t type. -S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT; +// Do not diagnose half type since it is diagnosed as invalid argument +//

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

2016-09-17 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7600 @@ +7599,3 @@ +// Do not diagnose half type since it is diagnosed as invalid argument +// type for any function eleswhere. +if (!PT->isHalfType()) -> elsewhere

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

2016-09-16 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7599-7602 @@ -7595,3 +7598,6 @@ // of event_t type. -S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT; +// Do not diagnose half type since it is diagnosed as invalid argument +//

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

2016-09-16 Thread Alexey Bader via cfe-commits
bader added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7599-7602 @@ -7595,3 +7598,6 @@ // of event_t type. -S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT; +// Do not diagnose half type since it is diagnosed as invalid argument +//

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

2016-09-16 Thread Yaxun Liu via cfe-commits
yaxunl updated this revision to Diff 71667. yaxunl added a comment. Remove redundant diagnostic msg. https://reviews.llvm.org/D24666 Files: lib/Sema/SemaDecl.cpp test/SemaOpenCL/half.cl test/SemaOpenCL/invalid-kernel-parameters.cl Index: test/SemaOpenCL/invalid-kernel-parameters.cl

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

2016-09-16 Thread Alexey Bader via cfe-commits
bader added inline comments. Comment at: test/SemaOpenCL/half.cl:29 @@ +28,3 @@ +kernel void half_disabled_kernel(global half *p, + half h); // expected-error{{'half' cannot be used as the type of a kernel parameter}} // expected-error{{declaring

[PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

2016-09-16 Thread Yaxun Liu via cfe-commits
yaxunl created this revision. yaxunl added reviewers: Anastasia, bader. yaxunl added subscribers: cfe-commits, nhaustov, rampitec. Herald added a subscriber: yaxunl. https://reviews.llvm.org/D24666 Files: lib/Sema/SemaDecl.cpp test/SemaOpenCL/half.cl