smeenai closed this revision.
smeenai added a comment.
Not sure why Phabricator isn't closing this out, but this was committed as SVN
r284016
https://reviews.llvm.org/D25145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
smeenai added a comment.
In https://reviews.llvm.org/D25145#565027, @mclow.lists wrote:
> Sigh. Make an expedient choice that you don't really agree with, and you get
> immediately reminded of it. I suggested on an earlier review (not this
> patch) that I really didn't want to see `_WIN32`
mclow.lists added a comment.
Sigh. Make an expedient choice that you don't really agree with, and you get
immediately reminded of it. I suggested on an earlier review (not this patch)
that I really didn't want to see `_WIN32` in any files other than ``,
that we should have a libc++-specific
smeenai added a comment.
My initial understanding of the problem was incorrect; I did some further
experimentation and I think I properly understand what's going on here now.
Sorry for the churn.
https://reviews.llvm.org/D25145
___
cfe-commits
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
The behavior of this macro actually needs to apply universally on
Windows and not just when using the Microsoft CRT. Update the macro
definition and documentation
