[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-19 Thread Elad Cohen via cfe-commits
eladcohen added a comment. In https://reviews.llvm.org/D25337#571877, @rsmith wrote: > I really don't like the command-line interface you're proposing here. It > seems like it will be extremely confusing what something like `-fmodules > -fexclusive-builtin-modules` means, for instance

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-19 Thread Elad Cohen via cfe-commits
eladcohen added a comment. In https://reviews.llvm.org/D25337#571845, @bruno wrote: > > The long answer is that there is a history of problems regarding the > > intrinsic files: > > http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html > >

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-17 Thread Richard Smith via cfe-commits
rsmith added a comment. I really don't like the command-line interface you're proposing here. It seems like it will be extremely confusing what something like `-fmodules -fexclusive-builtin-modules` means, for instance (usually, later `-f` flags override earlier ones, so does this *turn off*

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. > The long answer is that there is a history of problems regarding the > intrinsic files: > http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html > http://lists.llvm.org/pipermail/cfe-dev/2016-September/050943.html > Mainly compatibility issues because MSVC

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-09 Thread Elad Cohen via cfe-commits
eladcohen added a comment. Hi Bruno, The short answer is yes. Essentially it can be done, but we would actually like for all the users to always get this behavior, implicitly. The long answer is that there is a history of problems regarding the intrinsic files:

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-06 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a reviewer: bruno. bruno added a comment. Hi Elad, Is there any reason why you can't explicit model this in your build system by pre-building the intrinsics and pointing to a module cache path containing the pcm files? By doing that we don't need to have a specific compile flag.

[PATCH] D25337: [Modules] Add a command line option for enabling the modules feature exclusively for the Clang builtins.

2016-10-06 Thread Elad Cohen via cfe-commits
eladcohen created this revision. eladcohen added reviewers: hans, rnk, zvi, rsmith, chandlerc. eladcohen added a subscriber: cfe-commits. -fexclusive-builtin-modules enables the clang 'modules' feature exclusively for the clang intrinsic header files. The end goal of this effort is to have this