[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

This revision was automatically updated to reflect the committed changes. Closed by commit rL285934: Fixed column shift when formatting line containing bit shift operators (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D25439?vs=75635&id=76869#toc Repository:

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode added a comment. No, not yet - I was about to ask someone to commit this for me :) https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

malcolm.parsons added a comment. Do you have commit access? https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you! https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode updated this revision to Diff 75635. https://reviews.llvm.org/D25439 Files: lib/Format/FormatTokenLexer.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp === --- unittests/Format/FormatTest.cpp

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode added a comment. Thanks for pointing it out, just a minute ago I found a proper document mentioning it (I have no idea how I could miss it). I hope to be more use in future :) Comment at: unittests/Format/FormatTest.cpp:11365 +

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

djasper added a comment. Generally, always upload diffs with the full file as context to phabricator. That way, it is easier to see how the diff fits into the rest of the file. Thanks for fixing this!! Comment at: lib/Format/FormatTokenLexer.cpp:528 FormatTok->TokenText

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode updated this revision to Diff 74412. https://reviews.llvm.org/D25439 Files: lib/Format/FormatTokenLexer.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp === --- unittests/Format/FormatTest.cpp

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode marked an inline comment as done. idlecode added a comment. Sure, I will upload diff as soon as I test it https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

djasper added inline comments. Comment at: test/Format/bitshift-operator-width.cpp:1 +// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format -style=LLVM \ +// RUN: | FileCheck -strict-whitespace %s Could you move this test into unittests/Format/FormatTest.cpp? htt

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

mprobst added a comment. Looks good to me, but Daniel is a better owner for this code. https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode created this revision. idlecode added a subscriber: cfe-commits. Herald added a subscriber: klimek. During clang-format source lexing >> and << operators are split and treated as two less/greater operators but column position of following tokens was not adjusted accordingly. https://rev