[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-23 Thread Petr Hosek via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284950: [libcxx] Use C++14 when building libc++ with musl (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D25491?vs=75553&id=75554#toc Repository: rL LLVM https://reviews.llv

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-23 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 75553. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -325,6 +325,11 @@ # Required flags ===

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-22 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 75540. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-21 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: CMakeLists.txt:331 + # not a constexpr in C++11 but is in C++14, so we use C++14 with musl. + set(LIBCXX_STANDARD_VER c++14) +endif() Thi

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-21 Thread Petr Hosek via cfe-commits
phosek added a comment. @EricWF is this fine with you? Repository: rL LLVM https://reviews.llvm.org/D25491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-15 Thread Hal Finkel via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D25491#571003, @phosek wrote: > Ping, do you have any other comments? Fine by me. Please wait for an okay by @EricWF . Repository: rL LLVM https://reviews.llvm.org/D25491 ___ cfe-commits mai

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-14 Thread Petr Hosek via cfe-commits
phosek added a comment. Ping, do you have any other comments? Repository: rL LLVM https://reviews.llvm.org/D25491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-12 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 74439. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-12 Thread Hal Finkel via cfe-commits
hfinkel added inline comments. Comment at: CMakeLists.txt:327 # Required flags == set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build dialect") add_compile_flags_if_supported(-std=${LIBCXX_S

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-12 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 74402. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-11 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: CMakeLists.txt:327 # Required flags == set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build dialect") add_compile_flags_if_supported(-std=${LIBCXX_ST

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-11 Thread Petr Hosek via cfe-commits
phosek added inline comments. Comment at: CMakeLists.txt:327 # Required flags == set(LIBCXX_STANDARD_VER c++11 CACHE INTERNAL "internal option to change build dialect") add_compile_flags_if_supported(-std=${LIBCXX_ST

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-11 Thread Eric Fiselier via cfe-commits
EricWF added a comment. > musl's pthread implementations use volatile types in their structs which is > not being constexpr in C++11 but is in C++14. This means that libc++'s std::mutex is unsafe to use during dynamic initialization in C++11 with MUSL, which would really suck except that Clang

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-11 Thread Petr Hosek via cfe-commits
phosek added a comment. libc++ was already building with musl after https://reviews.llvm.org/D21637 was commited, but this broke recently as a consequence of r282640 which introduced the use of `_LIBCPP_SAFE_STATIC` for libc++ internal globals. I'm not sure if this is the best solution, but it'

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-11 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added reviewers: EricWF, mclow.lists. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. Herald added subscribers: mgorny, beanz. musl's pthread implementations use volatile types in their structs which is not being