This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.
Closed by commit rL284158: [CUDA] Emit deferred diagnostics during Sema rather
than during codegen. (authored by jlebar).
Changed prior to commit:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk added a comment.
Nice! Looks like this wasn't too bad.
Comment at: clang/lib/Sema/SemaCUDA.cpp:546
+ // Externally-visible and similar functions are always emitted.
+ if (S.getASTContext().GetGVALinkageForFunction(FD) > GVA_DiscardableODR)
+return true;
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, rsmith, cfe-commits.
Emitting deferred diagnostics during codegen was a hack. It did work,
but usability was poor, both for us as compiler devs and for users. We
don't codegen if there are any sema
