jlebar added a comment.
Thank you for the reviews, everyone!
Repository:
rL LLVM
https://reviews.llvm.org/D25647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284873: [clang-tidy] Don't use a SmallSetVector of an enum.
(authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25647?vs=75443=75478#toc
Repository:
rL LLVM
jlebar added inline comments.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kind);
+}
jlebar
jlebar updated this revision to Diff 75443.
jlebar marked 5 inline comments as done.
jlebar added a comment.
Adjust formatting, write out type of 'auto'.
https://reviews.llvm.org/D25647
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
jlebar added a comment.
Thank you very much for the review!
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kind);
+
jlebar added a comment.
Thank you very much for the review!
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kind);
+
bkramer added inline comments.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:103
+ auto = ClassWithSpecialMembers[ID];
+ if (find(Members, Kind) == Members.end()) Members.push_back(Kind);
+}
jlebar
jlebar added a comment.
Hi, friendly ping? This trivial patch is the only blocker remaining before I
can land https://reviews.llvm.org/D25648, which is the first part of my Grand
Set Refactoring (see mail to llvm-dev about a week ago).
Repository:
rL LLVM
https://reviews.llvm.org/D25647
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with two minor nits.
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:102
+ SpecialMemberFunctionKind Kind
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
This doesn't work after converting SmallSetVector to use DenseSet.
Instead we can just use a SmallVector.
https://reviews.llvm.org/D25647
Files:
10 matches
Mail list logo