This revision was automatically updated to reflect the committed changes.
Closed by commit rL284643: [CUDA] Emit errors for wrong-side calls made on the
same line as non-wrong-side… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25702?vs=74910=75220#toc
Repository:
jlebar added a comment.
In https://reviews.llvm.org/D25702#574289, @rnk wrote:
> lgtm
>
> I'm assuming you're going to follow this up with CanonicalDeclPtr usage.
Yes, that's in https://reviews.llvm.org/D25704.
https://reviews.llvm.org/D25702
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I'm assuming you're going to follow this up with CanonicalDeclPtr usage.
https://reviews.llvm.org/D25702
___
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, rnk.
This fixes two related bugs:
1. Previously, if you had a non-wrong side call at some source code
location L, we wouldn't emit errors for wrong-side calls that appeared
at L.
2. We'd only
