This revision was automatically updated to reflect the committed changes.
Closed by commit rL284647: [CUDA] When we emit an error that might have been
deferred, also print a… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25704?vs=75178=75226#toc
Repository:
rL
jlebar marked 2 inline comments as done.
jlebar added a comment.
Thank you for the review, Reid.
https://reviews.llvm.org/D25704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar marked 2 inline comments as done.
jlebar added a comment.
I'm going to submit this and send a patch to reuse FunctionDeclAndLoc. But I'm
happy to add a comment about the note as well.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6707
+def
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6707
+def note_called_by : Note<"called by %0">;
def err_kern_type_not_void_return : Error<
jlebar added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:9292
+ llvm::DenseMap,
+ /* Callees = */ llvm::SetVector>
+ CUDACallGraph;
rnk wrote:
> Rather than having a custom key type, maybe it would be better to phrase this
jlebar updated this revision to Diff 75178.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address rnk's comments.
https://reviews.llvm.org/D25704
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
rnk added inline comments.
Comment at: clang/include/clang/Sema/Sema.h:9292
+ llvm::DenseMap,
+ /* Callees = */ llvm::SetVector>
+ CUDACallGraph;
Rather than having a custom key type, maybe it would be better to phrase this
as a
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
Previously, when you did something not allowed in a host+device function
and then caused it to be codegen'ed, we would print out an error telling
you that you did something bad, but we wouldn't
