hokein added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30
+AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) {
+ return Node.hasDefaultConstructor();
aaron.ballman wrote:
> I think this should be a public AST matcher
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284727: [clang-tidy] Fix an assertion failure in
cppcoreguidelines-pro-type-member-init. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25747?vs=75066=75291#toc
Repository:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30
+AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) {
+ return
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
The matcher for matching "class with default constructor" still match
some classes without default constructor, which trigger an assert at
Line 307.
