This revision was automatically updated to reflect the committed changes.
Closed by commit rL300187: [analyzer] Add numerous assertions to SVal, SymExpr,
and MemRegion classes. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D26837?vs=79538=95092#toc
Repository:
baloghadamsoftware added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:282
+ static inline bool isCompoundType(QualType T) {
+return T->isArrayType() || T->isRecordType() ||
Could you please move this function into a
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:737
/// either a real region, a NULL pointer, etc. It essentially is used to
/// map the concept of symbolic values into the domain of regions. Symbolic
/// regions
zaks.anna added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:23
#include "clang/StaticAnalyzer/Core/PathSensitive/StoreRef.h"
+#include "clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h"
It's a bit sad
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:319
public:
- SymbolVal(SymbolRef sym) : NonLoc(SymbolValKind, sym) {}
+ SymbolVal() = delete;
+ SymbolVal(SymbolRef sym) : NonLoc(SymbolValKind, sym) { assert(sym); }
NoQ updated this revision to Diff 79538.
NoQ marked 3 inline comments as done.
NoQ added a comment.
Thanks for the comments!
Addressed.
https://reviews.llvm.org/D26837
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h
xazax.hun added a comment.
LGTM!
https://reviews.llvm.org/D26837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added a comment.
Personally, I like this change because it makes our assumptions clearer. My
comments are below.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:54
+ : store(st), region(r) {
+
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:334
void BlockCodeRegion::Profile(llvm::FoldingSetNodeID& ID) const {
+ locTy->getTypePtr()->isBlockPointerType();
BlockCodeRegion::ProfileRegion(ID, BD, locTy, AC, superRegion);
NoQ updated this revision to Diff 78489.
NoQ marked an inline comment as done.
NoQ added a comment.
Remove unused expression.
https://reviews.llvm.org/D26837
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h
seaneveson added inline comments.
Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:334
void BlockCodeRegion::Profile(llvm::FoldingSetNodeID& ID) const {
+ locTy->getTypePtr()->isBlockPointerType();
BlockCodeRegion::ProfileRegion(ID, BD, locTy, AC, superRegion);
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added a subscriber: cfe-commits.
Put a lot of run-time checks on how our SVals are constructed, in order to
maintain the existing status quo.
This should make understanding the hierarchy easier, and
12 matches
Mail list logo
