[PATCH] D26953: clang-format: handle formatting on constexpr if

2017-06-19 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg added a comment. In https://reviews.llvm.org/D26953#783497, @jtbandes wrote: > Hm, I probably should've searched first — but I just re-implemented this in > https://reviews.llvm.org/D34330. Actually, I think my implementation solves > the `AllowShortIfStatementsOnASingleLine` issue yo

[PATCH] D26953: clang-format: handle formatting on constexpr if

2017-06-19 Thread Daniel Jasper via Phabricator via cfe-commits
djasper closed this revision. djasper added a comment. Submitted the other implementation of this as r305666. https://reviews.llvm.org/D26953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D26953: clang-format: handle formatting on constexpr if

2017-06-18 Thread Jacob Bandes-Storch via Phabricator via cfe-commits
jtbandes added a comment. Hm, I probably should've searched first — but I just re-implemented this in https://reviews.llvm.org/D34330. Actually, I think my implementation solves the `AllowShortIfStatementsOnASingleLine` issue you were mentioning here 🎉 https://reviews.llvm.org/D26953 _

[PATCH] D26953: clang-format: handle formatting on constexpr if

2017-05-10 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg added a comment. In https://reviews.llvm.org/D26953#751021, @thakis wrote: > This looks good to me, thanks. Sorry about the slow turnaround. Do you have > commit access? If not, I can land it for you – but it also looks like you've > contributed several patches by now, so you could als

[PATCH] D26953: clang-format: handle formatting on constexpr if

2017-05-10 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. This looks good to me, thanks. Sorry about the slow turnaround. Do you have commit access? If not, I can land it for you – but it also looks like you've contributed several patches by now, so

[PATCH] D26953: clang-format: handle formatting on constexpr if

2017-04-03 Thread Denis Gladkikh via Phabricator via cfe-commits
outcoldman added a comment. In https://reviews.llvm.org/D26953#716504, @gnzlbg wrote: > any progress on this? It is getting tracked in mailing list http://lists.llvm.org/pipermail/cfe-dev/2017-April/053397.html https://reviews.llvm.org/D26953 __

[PATCH] D26953: clang-format: handle formatting on constexpr if

2017-04-03 Thread Gonzalo BG via Phabricator via cfe-commits
gnzlbg added a comment. any progress on this? https://reviews.llvm.org/D26953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26953: clang-format: handle formatting on constexpr if

2017-03-10 Thread Denis Gladkikh via Phabricator via cfe-commits
outcoldman added a comment. The actual problem is with that clang-format does not know anything about c++17 features, because it does not set it in lang options. Not sure if that will fix constexpr problem as well, but I could solve some other problems with tools/clang

[PATCH] D26953: clang-format: handle formatting on constexpr if

2016-11-21 Thread Visoiu Mistrih Francis via cfe-commits
thegameg created this revision. thegameg added reviewers: djasper, mprobst, ioeric, klimek. thegameg added a subscriber: cfe-commits. c++1z adds the following constructions to the language: if constexpr (cond) statement1; else if constexpr (cond) statement2; else if constexpr (cond) st