[PATCH] D27434: [libc++abi] Disable failing test on Darwin
ldionne added a comment. Note for posterity in case someone does some archeology and ends up here (as I am doing): the Radar number is 29523281. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27434/new/ https://reviews.llvm.org/D27434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D27434: [libc++abi] Disable failing test on Darwin
This revision was automatically updated to reflect the committed changes. Closed by commit rL289513: [libc++abi] Mark failing test on Darwin as XFAIL (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D27434?vs=80344=81174#toc Repository: rL LLVM https://reviews.llvm.org/D27434 Files: libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp Index: libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp === --- libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp +++ libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp @@ -7,6 +7,10 @@ // //===--===// +// Darwin TLV finalization routines fail when creating a thread-local variable +// in the destructor for another thread-local variable: +// http://lists.llvm.org/pipermail/cfe-dev/2016-November/051376.html +// XFAIL: darwin // UNSUPPORTED: c++98, c++03 // UNSUPPORTED: libcxxabi-no-threads Index: libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp === --- libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp +++ libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp @@ -7,6 +7,10 @@ // //===--===// +// Darwin TLV finalization routines fail when creating a thread-local variable +// in the destructor for another thread-local variable: +// http://lists.llvm.org/pipermail/cfe-dev/2016-November/051376.html +// XFAIL: darwin // UNSUPPORTED: c++98, c++03 // UNSUPPORTED: libcxxabi-no-threads ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D27434: [libc++abi] Disable failing test on Darwin
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. If this caused by a bug it should be marked `XFAIL` and have a comment explaining why it fails and links to the relevant PR's. Feel free to commit after making those changes. https://reviews.llvm.org/D27434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D27434: [libc++abi] Disable failing test on Darwin
smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The macOS thread-local variable finalizer routines do not handle the case where a termination function registers another termination function correctly, causing this test to fail. I've filed a radar for this; disable the test in the meantime. See [1] for more details. [1] http://lists.llvm.org/pipermail/cfe-dev/2016-November/051376.html https://reviews.llvm.org/D27434 Files: test/thread_local_destruction_order.pass.cpp Index: test/thread_local_destruction_order.pass.cpp === --- test/thread_local_destruction_order.pass.cpp +++ test/thread_local_destruction_order.pass.cpp @@ -9,6 +9,7 @@ // UNSUPPORTED: c++98, c++03 // UNSUPPORTED: libcxxabi-no-threads +// UNSUPPORTED: darwin #include #include Index: test/thread_local_destruction_order.pass.cpp === --- test/thread_local_destruction_order.pass.cpp +++ test/thread_local_destruction_order.pass.cpp @@ -9,6 +9,7 @@ // UNSUPPORTED: c++98, c++03 // UNSUPPORTED: libcxxabi-no-threads +// UNSUPPORTED: darwin #include #include ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
