[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader closed this revision. bader added a comment. Herald added subscribers: ebevhan, arphaman. Closed by https://reviews.llvm.org/rG18e165f50d8c1ab3afe7098dc00557d5f1a43cfa. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28080/new/ https://reviews.llvm.org/D28080

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. @Pekka, do you think there is something more to be done here or can I close this revision now? Apparently, I won't be able to pass` -target` in all cases because `-cc` has to be always the first parameter. Also I am preparing additional text and some minor

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

pekka.jaaskelainen added a comment. In https://reviews.llvm.org/D28080#653493, @Anastasia wrote: > > Also, for me the command without -emit-llvm doesn't output anything. > > What targets do you use? In this case I used only SPIR. I suppose this is fine as the concept of linking is unclear in

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. > (I should pass -finclude-default-header after -cc1 without -Xclang then it > works, but I think also the > latter version should work, no?) In general -cc1 and -Xclang have similar effect so I either should work indeed. > Also, I cannot add -S (even with

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

pekka.jaaskelainen added a comment. In https://reviews.llvm.org/D28080#651732, @Anastasia wrote: > @pekka.jaaskelainen, I just compiled the release 4.0 branch and it all works > for me as expected: > clang -cc1 -triple spir64-unknown-unknown test.cl > clang -target spir64-unknown-unknown

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. @pekka.jaaskelainen, I just compiled the release 4.0 branch and it all works for me as expected: clang -cc1 -triple spir64-unknown-unknown test.cl clang -target spir64-unknown-unknown test.cl https://reviews.llvm.org/D28080

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader added inline comments. Comment at: docs/UsersManual.rst:2065 + + $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl + pekka.jaaskelainen wrote: > Anastasia wrote: > > pekka.jaaskelainen wrote: > > > Is this correct? I cannot make

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

pekka.jaaskelainen added inline comments. Comment at: docs/UsersManual.rst:2065 + + $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl + Anastasia wrote: > pekka.jaaskelainen wrote: > > Is this correct? I cannot make it work: > > > >

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added inline comments. Comment at: docs/UsersManual.rst:2065 + + $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl + pekka.jaaskelainen wrote: > Is this correct? I cannot make it work: > > ``` >

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

pekka.jaaskelainen requested changes to this revision. pekka.jaaskelainen added inline comments. This revision now requires changes to proceed. Comment at: docs/UsersManual.rst:2065 + + $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl +

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

pekka.jaaskelainen accepted this revision. pekka.jaaskelainen added inline comments. This revision is now accepted and ready to land. Comment at: docs/UsersManual.rst:2130 + +- x86 is used by some implementations that are x86 compatible + (e.g. `POCL `_)

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. In https://reviews.llvm.org/D28080#644222, @yaxunl wrote: > > @yaxunl Sam, I think it would be nice to describe your recent change for > > adding OpenCL extensions. Would you like to write up some text? Otherwise I > > can draft something and you can review. :) > >

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

yaxunl added a comment. > @yaxunl Sam, I think it would be nice to describe your recent change for > adding OpenCL extensions. Would you like to write up some text? Otherwise I > can draft something and you can review. :) Anastasia, I am busy with some other work. If you can add it I will be

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. Since everyone agreed on the core part of this documentation I have committed the current revision in 291780 to make it easier for the release. Feel free to give me more feedback (if any) as small changes can still be merged in. @yaxunl Sam, I think it would be

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added inline comments. Comment at: docs/UsersManual.rst:2130 + +- x86 is used by some implementations that are x86 compatible + (e.g. `POCL `_) and currently remains for backwards pekka.jaaskelainen wrote: > Anastasia wrote: >

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia updated this revision to Diff 84136. Anastasia added a comment. Update based on comments from Pekka. https://reviews.llvm.org/D28080 Files: docs/UsersManual.rst www/index.html Index: docs/UsersManual.rst === ---

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

pekka.jaaskelainen added inline comments. Comment at: docs/UsersManual.rst:2120 + that can be used across GPU toolchains. The implementation follows `the SPIR + specification `_. There are two flavors available + for 32 and 64 bits.

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

yaxunl accepted this revision. yaxunl added a comment. Great work. LGTM. Thanks! https://reviews.llvm.org/D28080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader accepted this revision. bader added a comment. LGTM. Thanks! https://reviews.llvm.org/D28080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia marked 16 inline comments as done. Anastasia added inline comments. Comment at: docs/UsersManual.rst:2013 +to perform machine code generation. + +Clang currently supports OpenCL standards up to v2.0. pekka.jaaskelainen wrote: > I'd like to add a

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia updated this revision to Diff 83962. Anastasia added a comment. Addressed comments from Alexey, Pekka, and Sam! https://reviews.llvm.org/D28080 Files: docs/UsersManual.rst www/index.html Index: www/index.html ===

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader added a comment. Thanks for working on this! Looks good, except a few pedantic notes. Comment at: docs/UsersManual.rst:44 - :ref:`Objective C++ Language ` +- :ref:`OpenCL Language `: v1.0, v1.1, v1.2, v2.0. It should and to be perfectly clear we

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

yaxunl added inline comments. Comment at: docs/UsersManual.rst:2003 + $ clang -target nvptx64-unknown-unknown test.cl + $ clang -target amdgcn-unknown-amdhsa test.cl + $ clang -target amdgcn-amd-amdhsa-opencl test.cl Comment at:

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia marked 4 inline comments as done. Anastasia added a comment. Ping! Any more comments here? It would be nice to commit this before the 4.0 rel branch is taken (on Jan 12). https://reviews.llvm.org/D28080 ___ cfe-commits mailing list

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia updated this revision to Diff 83824. Anastasia added a comment. Updated with comments from Mats! https://reviews.llvm.org/D28080 Files: docs/UsersManual.rst www/index.html Index: www/index.html === ---

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Leporacanthicus added inline comments. Comment at: docs/UsersManual.rst:2083 +space is represented by the absence of an address space attribute in the IR (see +also :ref:`the section on address space attribute `). + Should this be `opencl_addrsp` (two d's)?

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia created this revision. Anastasia added reviewers: yaxunl, pekka.jaaskelainen, bader. Anastasia added subscribers: cfe-commits, rsmith. Adding information on OpenCL to Clang documentation. This currently contain the main features only. I am hoping we can improve it with time documenting