This revision was automatically updated to reflect the committed changes.
Closed by commit rL296140: [Preprocessor] Fix incorrect token caching that
occurs when lexing _Pragma (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D28772?vs=87801=89688#toc
Repository:
rL
akyrtzi accepted this revision.
akyrtzi added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D28772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D28772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 87801.
arphaman added a comment.
Sorry about the delay.
As per Richard's suggestion, the updated patch now makes the `_Pragma` parser
responsible for initiating the removal of cached tokens.
Repository:
rL LLVM
https://reviews.llvm.org/D28772
Files:
rsmith added a comment.
Can we instead address this locally in `_Pragma` handling, by getting it to
clear out the junk it inserted into the token stream when it's done (if
backtracking is enabled)?
Repository:
rL LLVM
https://reviews.llvm.org/D28772