[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

This revision was automatically updated to reflect the committed changes. Closed by commit rL293209: IRGen: When loading the main module in the distributed ThinLTO backend, look… (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D29067?vs=85618=85958#toc Repository: rL

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D29067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

pcc added inline comments. Comment at: clang/include/clang/CodeGen/BackendUtil.h:51 + llvm::Expected + FindThinLTOModule(llvm::MemoryBufferRef MBRef); } mehdi_amini wrote: > Indentation seems strange? Yes, it's what clang-format does though.

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

pcc updated this revision to Diff 85618. pcc added a comment. Address review comments https://reviews.llvm.org/D29067 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/test/CMakeLists.txt clang/test/CodeGen/thinlto-multi-module.ll Index: clang/test/CodeGen/thinlto-multi-module.ll

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:867 +Expected clang::FindThinLTOModule(MemoryBufferRef MBRef) { + Expected BMsOrErr = getBitcodeModuleList(MBRef); Would it be better to have this in llvm (e.g. in

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

mehdi_amini added inline comments. Comment at: clang/include/clang/CodeGen/BackendUtil.h:51 + llvm::Expected + FindThinLTOModule(llvm::MemoryBufferRef MBRef); } Indentation seems strange? Comment at: clang/lib/CodeGen/CodeGenAction.cpp:841

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

pcc created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D29067 Files: clang/include/clang/CodeGen/BackendUtil.h clang/include/clang/CodeGen/CodeGenAction.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CMakeLists.txt